overlayfs: unrecognized mount option "" or missing value ====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.5/28834 is trying to acquire lock: 000000003102d325 (&ovl_i_mutex_dir_key[depth]){++++}, at: inode_lock_shared include/linux/fs.h:758 [inline] 000000003102d325 (&ovl_i_mutex_dir_key[depth]){++++}, at: do_last fs/namei.c:3326 [inline] 000000003102d325 (&ovl_i_mutex_dir_key[depth]){++++}, at: path_openat+0x17ec/0x2df0 fs/namei.c:3537 but task is already holding lock: 000000009c8099dc (&sig->cred_guard_mutex){+.+.}, at: prepare_bprm_creds fs/exec.c:1419 [inline] 000000009c8099dc (&sig->cred_guard_mutex){+.+.}, at: __do_execve_file+0x38c/0x2360 fs/exec.c:1762 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sig->cred_guard_mutex){+.+.}: lock_trace fs/proc/base.c:402 [inline] proc_pid_stack+0x160/0x350 fs/proc/base.c:452 proc_single_show+0xeb/0x170 fs/proc/base.c:755 seq_read+0x4e0/0x11c0 fs/seq_file.c:232 do_loop_readv_writev fs/read_write.c:701 [inline] do_loop_readv_writev fs/read_write.c:688 [inline] do_iter_read+0x471/0x630 fs/read_write.c:925 vfs_readv+0xe5/0x150 fs/read_write.c:987 do_preadv fs/read_write.c:1071 [inline] __do_sys_preadv fs/read_write.c:1121 [inline] __se_sys_preadv fs/read_write.c:1116 [inline] __x64_sys_preadv+0x22b/0x310 fs/read_write.c:1116 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #2 (&p->lock){+.+.}: seq_read+0x6b/0x11c0 fs/seq_file.c:164 proc_reg_read+0x1bd/0x2d0 fs/proc/inode.c:231 do_loop_readv_writev fs/read_write.c:701 [inline] do_loop_readv_writev fs/read_write.c:688 [inline] do_iter_read+0x471/0x630 fs/read_write.c:925 vfs_readv+0xe5/0x150 fs/read_write.c:987 kernel_readv fs/splice.c:362 [inline] default_file_splice_read+0x457/0xa00 fs/splice.c:417 do_splice_to+0x10e/0x160 fs/splice.c:881 splice_direct_to_actor+0x2b9/0x8d0 fs/splice.c:959 do_splice_direct+0x1a7/0x270 fs/splice.c:1068 do_sendfile+0x550/0xc30 fs/read_write.c:1447 __do_sys_sendfile64 fs/read_write.c:1508 [inline] __se_sys_sendfile64+0x147/0x160 fs/read_write.c:1494 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #1 (sb_writers#3){.+.+}: sb_start_write include/linux/fs.h:1579 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:360 ovl_xattr_set+0x53/0x600 fs/overlayfs/inode.c:338 __vfs_setxattr+0x10e/0x170 fs/xattr.c:149 __vfs_setxattr_noperm+0x11a/0x420 fs/xattr.c:180 __vfs_setxattr_locked+0x176/0x250 fs/xattr.c:238 vfs_setxattr+0xe5/0x270 fs/xattr.c:255 setxattr+0x23d/0x330 fs/xattr.c:520 path_setxattr+0x170/0x190 fs/xattr.c:539 __do_sys_lsetxattr fs/xattr.c:561 [inline] __se_sys_lsetxattr fs/xattr.c:557 [inline] __x64_sys_lsetxattr+0xbd/0x150 fs/xattr.c:557 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&ovl_i_mutex_dir_key[depth]){++++}: down_read+0x36/0x80 kernel/locking/rwsem.c:24 inode_lock_shared include/linux/fs.h:758 [inline] do_last fs/namei.c:3326 [inline] path_openat+0x17ec/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_open_execat+0x11d/0x5b0 fs/exec.c:853 __do_execve_file+0x1a8b/0x2360 fs/exec.c:1770 do_execveat_common fs/exec.c:1879 [inline] do_execveat+0x3d/0x50 fs/exec.c:1907 __do_sys_execveat fs/exec.c:1988 [inline] __se_sys_execveat fs/exec.c:1980 [inline] __x64_sys_execveat+0xe1/0x120 fs/exec.c:1980 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: &ovl_i_mutex_dir_key[depth] --> &p->lock --> &sig->cred_guard_mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sig->cred_guard_mutex); lock(&p->lock); lock(&sig->cred_guard_mutex); lock(&ovl_i_mutex_dir_key[depth]); *** DEADLOCK *** 1 lock held by syz-executor.5/28834: #0: 000000009c8099dc (&sig->cred_guard_mutex){+.+.}, at: prepare_bprm_creds fs/exec.c:1419 [inline] #0: 000000009c8099dc (&sig->cred_guard_mutex){+.+.}, at: __do_execve_file+0x38c/0x2360 fs/exec.c:1762 stack backtrace: CPU: 1 PID: 28834 Comm: syz-executor.5 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 down_read+0x36/0x80 kernel/locking/rwsem.c:24 inode_lock_shared include/linux/fs.h:758 [inline] do_last fs/namei.c:3326 [inline] path_openat+0x17ec/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_open_execat+0x11d/0x5b0 fs/exec.c:853 __do_execve_file+0x1a8b/0x2360 fs/exec.c:1770 do_execveat_common fs/exec.c:1879 [inline] do_execveat+0x3d/0x50 fs/exec.c:1907 __do_sys_execveat fs/exec.c:1988 [inline] __se_sys_execveat fs/exec.c:1980 [inline] __x64_sys_execveat+0xe1/0x120 fs/exec.c:1980 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7f6d24b02409 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f6d23477168 EFLAGS: 00000246 ORIG_RAX: 0000000000000142 RAX: ffffffffffffffda RBX: 00007f6d24c14f80 RCX: 00007f6d24b02409 RDX: 0000000020001400 RSI: 0000000020000000 RDI: 0000000000000003 RBP: 00007f6d24b5d367 R08: 0000000000001000 R09: 0000000000000000 R10: 0000000020001500 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffee144e06f R14: 00007f6d23477300 R15: 0000000000022000 team0: Device macvtap41 is already an upper device of the team interface overlayfs: overlapping lowerdir path overlayfs: unrecognized mount option "18446744073709551615" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "le0" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "le0" or missing value team0: Device macvtap41 is already an upper device of the team interface team0: Device macvtap41 is already an upper device of the team interface overlayfs: failed to resolve 'file;M': -2 overlayfs: failed to resolve 'file;M': -2 team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lowele0" or missing value overlayfs: failed to resolve 'file;M': -2 team0: Device macvtap41 is already an upper device of the team interface team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lo" or missing value team0: Device macvtap1 is already an upper device of the team interface team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "y;C78+.wele0" or missing value overlayfs: unrecognized mount option "lo" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lo" or missing value overlayfs: unrecognized mount option "y;C78+.wele0" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: missing 'lowerdir' overlayfs: unrecognized mount option "y;C78+.wele0" or missing value overlayfs: unrecognized mount option "lowardir=.:file0Z2MMhAi09E]X[P*YU7#~B RꌔVgqhȓňŨ ີi_m쩞ag)pnBsDyK(muul ?SC_" or missing value overlayfs: missing 'lowerdir' overlayfs: missing 'lowerdir' overlayfs: unrecognized mount option "lowle0" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lowardir=.:file0Z2MMhAi09E]X[P*YU7#~B RꌔVgqhȓňŨ ີi_m쩞ag)pnBsDyK(muul ?SC_" or missing value overlayfs: unrecognized mount option "lowerd)r=.:file0" or missing value overlayfs: unrecognized mount option "lowle0" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lowerd)r=.:file0" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lowerdr=.:file0" or missing value overlayfs: failed to resolve 'file0!y=7v': -2 overlayfs: unrecognized mount option "lowerd)r=.:file0" or missing value team0: Device macvtap41 is already an upper device of the team interface team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lowerdr=.:file0" or missing value overlayfs: failed to resolve 'fil': -2 overlayfs: failed to resolve 'fil': -2 team0: Device macvtap41 is already an upper device of the team interface overlayfs: unrecognized mount option "lo" or missing value team0: Device macvtap41 is already an upper device of the team interface overlayfs: failed to resolve 'file0bA8هE4e/68هE4e/6