====================================================== WARNING: possible circular locking dependency detected 6.1.115-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.362/5741 is trying to acquire lock: ffff0000d9498ae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xbc/0x664 fs/gfs2/quota.c:682 but task is already holding lock: ffff0000e2b885e8 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x210/0x17a0 fs/gfs2/bmap.c:679 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 __gfs2_iomap_get+0x138/0x1058 fs/gfs2/bmap.c:856 gfs2_iomap_get+0xd8/0x154 fs/gfs2/bmap.c:1396 bh_get+0x208/0x6ac fs/gfs2/quota.c:385 qdsb_get+0x1e0/0x398 fs/gfs2/quota.c:522 gfs2_quota_hold+0x16c/0x558 fs/gfs2/quota.c:608 gfs2_quota_lock+0xbc/0x404 fs/gfs2/quota.c:1076 gfs2_quota_lock_check fs/gfs2/quota.h:50 [inline] alloc_dinode+0x180/0x478 fs/gfs2/inode.c:393 gfs2_create_inode+0xc58/0x1548 fs/gfs2/inode.c:711 gfs2_atomic_open+0xd8/0x1c4 fs/gfs2/inode.c:1292 atomic_open fs/namei.c:3345 [inline] lookup_open fs/namei.c:3453 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0xbf8/0x2548 fs/namei.c:3780 do_filp_open+0x1bc/0x3cc fs/namei.c:3810 do_sys_openat2+0x128/0x3e0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xbc/0x664 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x174c/0x207c fs/gfs2/rgrp.c:2494 __gfs2_iomap_alloc+0x3b8/0x17a0 fs/gfs2/bmap.c:705 gfs2_iomap_begin_write fs/gfs2/bmap.c:1047 [inline] gfs2_iomap_begin+0xb1c/0x142c fs/gfs2/bmap.c:1112 iomap_iter+0x634/0x120c fs/iomap/iter.c:91 iomap_file_buffered_write+0x1f4/0x940 fs/iomap/buffered-io.c:846 gfs2_file_buffered_write+0x49c/0x800 fs/gfs2/file.c:1056 gfs2_file_write_iter+0x3d4/0xc3c fs/gfs2/file.c:1157 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x91c fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 6 locks held by syz.4.362/5741: #0: ffff0000da5559e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x124/0x16c fs/file.c:1031 #1: ffff0000d506a460 (sb_writers#25){.+.+}-{0:0}, at: vfs_write+0x244/0x91c fs/read_write.c:580 #2: ffff0000e2b88150 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff0000e2b88150 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: gfs2_file_write_iter+0x2cc/0xc3c fs/gfs2/file.c:1114 #3: ffff0000d506a650 (sb_internal#6){.+.+}-{0:0}, at: gfs2_trans_begin+0xa8/0x11c fs/gfs2/trans.c:118 #4: ffff0000d9499058 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x524/0x91c fs/gfs2/trans.c:87 #5: ffff0000e2b885e8 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x210/0x17a0 fs/gfs2/bmap.c:679 stack backtrace: CPU: 0 PID: 5741 Comm: syz.4.362 Not tainted 6.1.115-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xbc/0x664 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x174c/0x207c fs/gfs2/rgrp.c:2494 __gfs2_iomap_alloc+0x3b8/0x17a0 fs/gfs2/bmap.c:705 gfs2_iomap_begin_write fs/gfs2/bmap.c:1047 [inline] gfs2_iomap_begin+0xb1c/0x142c fs/gfs2/bmap.c:1112 iomap_iter+0x634/0x120c fs/iomap/iter.c:91 iomap_file_buffered_write+0x1f4/0x940 fs/iomap/buffered-io.c:846 gfs2_file_buffered_write+0x49c/0x800 fs/gfs2/file.c:1056 gfs2_file_write_iter+0x3d4/0xc3c fs/gfs2/file.c:1157 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x91c fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585