====================================================== WARNING: possible circular locking dependency detected 6.1.74-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/15417 is trying to acquire lock: ffff0000eab68fc0 (&ni->ni_lock){+.+.}-{3:3}, at: ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 but task is already holding lock: ffff0000ea976fa0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline] ffff0000ea976fa0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_lookup+0xf8/0x1f8 fs/ntfs3/namei.c:82 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock/4){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x360/0x2bd4 fs/ntfs3/inode.c:524 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3208 ni_write_inode+0xc4c/0xfb8 fs/ntfs3/frecord.c:3303 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1030 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1733 write_inode_now+0x198/0x230 fs/fs-writeback.c:2769 ntfs_extend+0x310/0x408 fs/ntfs3/file.c:456 ntfs_file_write_iter+0x2a0/0x580 fs/ntfs3/file.c:1159 call_write_iter include/linux/fs.h:2249 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x914 fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ni->ni_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 ntfs_iget5+0x718/0x2bd4 fs/ntfs3/inode.c:531 dir_search_u+0x298/0x324 fs/ntfs3/dir.c:264 ntfs_lookup+0x108/0x1f8 fs/ntfs3/namei.c:83 lookup_open fs/namei.c:3468 [inline] open_last_lookups fs/namei.c:3558 [inline] path_openat+0xd3c/0x2548 fs/namei.c:3788 do_filp_open+0x1bc/0x3cc fs/namei.c:3818 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); *** DEADLOCK *** 3 locks held by syz-executor.2/15417: #0: ffff0000cf53e460 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000ea977240 (&type->i_mutex_dir_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff0000ea977240 (&type->i_mutex_dir_key#8){++++}-{3:3}, at: open_last_lookups fs/namei.c:3555 [inline] #1: ffff0000ea977240 (&type->i_mutex_dir_key#8){++++}-{3:3}, at: path_openat+0x5ec/0x2548 fs/namei.c:3788 #2: ffff0000ea976fa0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline] #2: ffff0000ea976fa0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_lookup+0xf8/0x1f8 fs/ntfs3/namei.c:82 stack backtrace: CPU: 1 PID: 15417 Comm: syz-executor.2 Not tainted 6.1.74-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 ntfs_iget5+0x718/0x2bd4 fs/ntfs3/inode.c:531 dir_search_u+0x298/0x324 fs/ntfs3/dir.c:264 ntfs_lookup+0x108/0x1f8 fs/ntfs3/namei.c:83 lookup_open fs/namei.c:3468 [inline] open_last_lookups fs/namei.c:3558 [inline] path_openat+0xd3c/0x2548 fs/namei.c:3788 do_filp_open+0x1bc/0x3cc fs/namei.c:3818 do_sys_openat2+0x128/0x3d8 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 ntfs3: loop2: Mark volume as dirty due to NTFS errors