bcachefs (loop3): snapshots_read... done bcachefs (loop3): check_allocations... ====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc6-syzkaller-00061-ge9d22f7a6655 #0 Not tainted ------------------------------------------------------ syz.3.3365/18016 is trying to acquire lock: ffff888044180988 (&c->sb_lock){+.+.}-{3:3}, at: bch2_gc_mark_key+0xc6a/0x1010 fs/bcachefs/btree_gc.c:600 but task is already holding lock: ffff888044181a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_gc_btree fs/bcachefs/btree_gc.c:644 [inline] ffff888044181a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_gc_btrees fs/bcachefs/btree_gc.c:697 [inline] ffff888044181a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_check_allocations+0x2e31/0xccc0 fs/bcachefs/btree_gc.c:1224 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&c->btree_root_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 bch2_btree_roots_to_journal_entries+0xbb/0x980 fs/bcachefs/btree_update_interior.c:2633 bch2_fs_mark_clean+0x2cc/0x6d0 fs/bcachefs/sb-clean.c:376 bch2_fs_read_only+0x1101/0x1210 fs/bcachefs/super.c:381 __bch2_fs_stop+0x105/0x540 fs/bcachefs/super.c:614 generic_shutdown_super+0x138/0x2d0 fs/super.c:642 bch2_kill_sb+0x41/0x50 fs/bcachefs/fs.c:2044 deactivate_locked_super+0xc6/0x130 fs/super.c:473 cleanup_mnt+0x41f/0x4b0 fs/namespace.c:1267 task_work_run+0x251/0x310 kernel/task_work.c:180 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x168/0x360 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&c->sb_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 bch2_gc_mark_key+0xc6a/0x1010 fs/bcachefs/btree_gc.c:600 bch2_gc_btree fs/bcachefs/btree_gc.c:648 [inline] bch2_gc_btrees fs/bcachefs/btree_gc.c:697 [inline] bch2_check_allocations+0x3e06/0xccc0 fs/bcachefs/btree_gc.c:1224 bch2_run_recovery_pass+0xf2/0x1e0 fs/bcachefs/recovery_passes.c:182 bch2_run_recovery_passes+0x19e/0x820 fs/bcachefs/recovery_passes.c:225 bch2_fs_recovery+0x2386/0x3730 fs/bcachefs/recovery.c:813 bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1035 bch2_fs_open+0xa8d/0xdf0 fs/bcachefs/super.c:2132 bch2_mount+0x6b0/0x13a0 fs/bcachefs/fs.c:1926 legacy_get_tree+0xf0/0x190 fs/fs_context.c:662 vfs_get_tree+0x92/0x2a0 fs/super.c:1789 do_new_mount+0x2be/0xb40 fs/namespace.c:3352 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&c->btree_root_lock); lock(&c->sb_lock); lock(&c->btree_root_lock); lock(&c->sb_lock); *** DEADLOCK *** 4 locks held by syz.3.3365/18016: #0: ffff888044180278 (&c->state_lock){+.+.}-{3:3}, at: bch2_fs_start+0x45/0x5b0 fs/bcachefs/super.c:1005 #1: ffff8880441a6750 (&c->gc_lock){++++}-{3:3}, at: bch2_check_allocations+0x258/0xccc0 fs/bcachefs/btree_gc.c:1209 #2: ffff8880441842d8 (&c->btree_trans_barrier){.+.+}-{0:0}, at: srcu_lock_acquire include/linux/srcu.h:116 [inline] #2: ffff8880441842d8 (&c->btree_trans_barrier){.+.+}-{0:0}, at: srcu_read_lock include/linux/srcu.h:215 [inline] #2: ffff8880441842d8 (&c->btree_trans_barrier){.+.+}-{0:0}, at: __bch2_trans_get+0x840/0xce0 fs/bcachefs/btree_iter.c:3193 #3: ffff888044181a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_gc_btree fs/bcachefs/btree_gc.c:644 [inline] #3: ffff888044181a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_gc_btrees fs/bcachefs/btree_gc.c:697 [inline] #3: ffff888044181a58 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_check_allocations+0x2e31/0xccc0 fs/bcachefs/btree_gc.c:1224 stack backtrace: CPU: 1 PID: 18016 Comm: syz.3.3365 Not tainted 6.10.0-rc6-syzkaller-00061-ge9d22f7a6655 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 bch2_gc_mark_key+0xc6a/0x1010 fs/bcachefs/btree_gc.c:600 bch2_gc_btree fs/bcachefs/btree_gc.c:648 [inline] bch2_gc_btrees fs/bcachefs/btree_gc.c:697 [inline] bch2_check_allocations+0x3e06/0xccc0 fs/bcachefs/btree_gc.c:1224 bch2_run_recovery_pass+0xf2/0x1e0 fs/bcachefs/recovery_passes.c:182 bch2_run_recovery_passes+0x19e/0x820 fs/bcachefs/recovery_passes.c:225 bch2_fs_recovery+0x2386/0x3730 fs/bcachefs/recovery.c:813 bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1035 bch2_fs_open+0xa8d/0xdf0 fs/bcachefs/super.c:2132 bch2_mount+0x6b0/0x13a0 fs/bcachefs/fs.c:1926 legacy_get_tree+0xf0/0x190 fs/fs_context.c:662 vfs_get_tree+0x92/0x2a0 fs/super.c:1789 do_new_mount+0x2be/0xb40 fs/namespace.c:3352 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f36cd7772da Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 7e 1a 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f36ce487e78 EFLAGS: 00000206 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f36ce487f00 RCX: 00007f36cd7772da RDX: 0000000020005b00 RSI: 0000000020005b40 RDI: 00007f36ce487ec0 RBP: 0000000020005b00 R08: 00007f36ce487f00 R09: 0000000000000005 R10: 0000000000000005 R11: 0000000000000206 R12: 0000000020005b40 R13: 00007f36ce487ec0 R14: 0000000000005b16 R15: 0000000020000180 bucket 0:9 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:9 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:10 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:10 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:11 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:11 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:12 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:12 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:13 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:13 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:14 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:14 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:15 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:15 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:24 gen 0 has wrong data_type: got journal, should be need_discard, fixing bucket 0:24 gen 0 data type need_discard has wrong dirty_sectors: got 256, should be 0, fixing bucket 0:121 gen 0 has wrong data_type: got free, should be sb, fixing bucket 0:121 gen 0 data type sb has wrong dirty_sectors: got 0, should be 256, fixing dev 0 has wrong journal buckets: got 8, should be 0, fixing dev 0 has wrong journal sectors: got 2048, should be 0, fixing dev 0 has wrong need_discard buckets: got 0, should be 8, fixing fs has wrong hidden: got 8448, should be 6400, fixing done bcachefs (loop3): going read-write bcachefs (loop3): journal_replay... bcachefs (loop3): bch2_journal_replay(): error erofs_journal_err bcachefs (loop3): bch2_fs_recovery(): error erofs_journal_err bcachefs (loop3): bch2_fs_start(): error starting filesystem erofs_journal_err bcachefs (loop3): shutting down bcachefs (loop3): shutdown complete