====================================================== WARNING: possible circular locking dependency detected 5.15.174-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.1409/8807 is trying to acquire lock: ffff88802356e650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266 but task is already holding lock: ffff8880603dea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xbd1/0x1ce0 fs/ocfs2/file.c:1265 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:988 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:310 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x299/0xb40 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:988 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1517 ocfs2_get_init_inode+0x154/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xdcb/0x2cd0 fs/ocfs2/namei.c:310 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6173 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x932/0xe40 fs/quota/dquot.c:1942 dquot_free_space_nodirty include/linux/quotaops.h:376 [inline] dquot_free_space include/linux/quotaops.h:381 [inline] dquot_free_block include/linux/quotaops.h:392 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6156 [inline] ext4_free_blocks+0x1f5c/0x2e90 fs/ext4/mballoc.c:6286 ext4_remove_blocks fs/ext4/extents.c:2523 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2689 [inline] ext4_ext_remove_space+0x24da/0x4db0 fs/ext4/extents.c:2937 ext4_ext_truncate+0x191/0x250 fs/ext4/extents.c:4471 ext4_truncate+0x9fd/0x1130 fs/ext4/inode.c:4249 ext4_evict_inode+0xba1/0x1100 fs/ext4/inode.c:289 evict+0x529/0x930 fs/inode.c:622 ext4_orphan_cleanup+0x9d9/0x1240 fs/ext4/orphan.c:474 ext4_fill_super+0x98de/0xa110 fs/ext4/super.c:4975 mount_bdev+0x2c9/0x3f0 fs/super.c:1400 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #3 (&ei->i_data_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ext4_map_blocks+0x9a2/0x1c70 fs/ext4/inode.c:665 mpage_map_one_extent fs/ext4/inode.c:2407 [inline] mpage_map_and_submit_extent fs/ext4/inode.c:2460 [inline] ext4_writepages+0x160e/0x3d10 fs/ext4/inode.c:2828 do_writepages+0x481/0x730 mm/page-writeback.c:2386 __writeback_single_inode+0x15b/0xe30 fs/fs-writeback.c:1647 writeback_sb_inodes+0xbce/0x1a40 fs/fs-writeback.c:1930 __writeback_inodes_wb+0x114/0x400 fs/fs-writeback.c:2001 wb_writeback+0x465/0xc50 fs/fs-writeback.c:2106 wb_check_background_flush fs/fs-writeback.c:2172 [inline] wb_do_writeback fs/fs-writeback.c:2260 [inline] wb_workfn+0xd07/0x1130 fs/fs-writeback.c:2288 process_one_work+0x8a1/0x10c0 kernel/workqueue.c:2310 worker_thread+0xaca/0x1280 kernel/workqueue.c:2457 kthread+0x3f6/0x4f0 kernel/kthread.c:334 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:287 -> #2 ( jbd2_handle){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354 ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:361 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_open fs/open.c:1277 [inline] __se_sys_open fs/open.c:1273 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1273 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352 ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:361 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_open fs/open.c:1277 [inline] __se_sys_open fs/open.c:1273 [inline] __x64_sys_open+0x221/0x270 fs/open.c:1273 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266 notify_change+0xc6d/0xf50 fs/attr.c:505 ovl_workdir_create+0x5a3/0x7d0 fs/overlayfs/super.c:830 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: sb_internal#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#4); *** DEADLOCK *** 5 locks held by syz.1.1409/8807: #0: ffff88807a2920e0 (&type->s_umount_key#65/1){+.+.}-{3:3}, at: alloc_super+0x210/0x940 fs/super.c:229 #1: ffff88802356e460 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #2: ffff8880603d9808 (&sb->s_type->i_mutex_key#34/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #2: ffff8880603d9808 (&sb->s_type->i_mutex_key#34/1){+.+.}-{3:3}, at: ovl_workdir_create+0x12e/0x7d0 fs/overlayfs/super.c:768 #3: ffff8880603ded88 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #3: ffff8880603ded88 (&sb->s_type->i_mutex_key#34){+.+.}-{3:3}, at: ovl_workdir_create+0x575/0x7d0 fs/overlayfs/super.c:829 #4: ffff8880603dea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xbd1/0x1ce0 fs/ocfs2/file.c:1265 stack backtrace: CPU: 1 PID: 8807 Comm: syz.1.1409 Not tainted 5.15.174-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xbe0/0x1ce0 fs/ocfs2/file.c:1266 notify_change+0xc6d/0xf50 fs/attr.c:505 ovl_workdir_create+0x5a3/0x7d0 fs/overlayfs/super.c:830 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f589ccfcd19 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f589ab6d038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f589ceecfa0 RCX: 00007f589ccfcd19 RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000 RBP: 00007f589cd78a20 R08: 0000000020000380 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f589ceecfa0 R15: 00007ffec3bab2f8 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: failed to set xattr on upper overlayfs: ...falling back to index=off,metacopy=off. overlayfs: upper fs missing required features.