====================================================== WARNING: possible circular locking dependency detected 5.15.173-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.278/5079 is trying to acquire lock: ffff0000c88ce650 (sb_internal#5){.+.+}-{0:0}, at: ocfs2_write_info+0x114/0x354 fs/ocfs2/quota_global.c:977 but task is already holding lock: ffff0000de31ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811 dqget+0x664/0xd0c fs/quota/dquot.c:986 ocfs2_setattr+0xce8/0x1920 fs/ocfs2/file.c:1246 notify_change+0xa34/0xcf8 fs/attr.c:505 chown_common+0x4ac/0x74c fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xe0/0x158 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:765 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:789 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x258/0xa90 fs/ocfs2/quota_global.c:811 dqget+0x664/0xd0c fs/quota/dquot.c:986 ocfs2_setattr+0xce8/0x1920 fs/ocfs2/file.c:1246 notify_change+0xa34/0xcf8 fs/attr.c:505 chown_common+0x4ac/0x74c fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xe0/0x158 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:765 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_free_space+0x878/0xce8 fs/quota/dquot.c:1940 dquot_free_space_nodirty include/linux/quotaops.h:376 [inline] dquot_free_space include/linux/quotaops.h:381 [inline] dquot_free_block include/linux/quotaops.h:392 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6156 [inline] ext4_free_blocks+0x1bf8/0x2bdc fs/ext4/mballoc.c:6286 ext4_remove_blocks fs/ext4/extents.c:2523 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2689 [inline] ext4_ext_remove_space+0x1c48/0x4254 fs/ext4/extents.c:2937 ext4_ext_truncate+0x188/0x250 fs/ext4/extents.c:4471 ext4_truncate+0x9c4/0x1058 fs/ext4/inode.c:4249 ext4_evict_inode+0xc30/0x124c fs/ext4/inode.c:289 evict+0x418/0x894 fs/inode.c:622 iput_final fs/inode.c:1744 [inline] iput+0x744/0x824 fs/inode.c:1770 ext4_process_orphan+0x244/0x2b8 fs/ext4/orphan.c:360 ext4_orphan_cleanup+0x8bc/0x1048 fs/ext4/orphan.c:474 ext4_fill_super+0x8044/0x8768 fs/ext4/super.c:4975 mount_bdev+0x274/0x370 fs/super.c:1400 ext4_mount+0x44/0x58 fs/ext4/super.c:6603 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #3 (&ei->i_data_sem){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ext4_truncate+0x7c0/0x1058 fs/ext4/inode.c:4244 ext4_setattr+0xc48/0x1440 fs/ext4/inode.c:5553 notify_change+0xa34/0xcf8 fs/attr.c:505 do_truncate+0x1c0/0x28c fs/open.c:65 do_sys_ftruncate+0x288/0x31c fs/open.c:193 __do_sys_ftruncate fs/open.c:204 [inline] __se_sys_ftruncate fs/open.c:202 [inline] __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfc0/0x12a4 fs/jbd2/transaction.c:464 jbd2__journal_start+0x29c/0x7b4 fs/jbd2/transaction.c:521 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560 ocfs2_start_trans+0x468/0x804 fs/ocfs2/journal.c:354 ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927 ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140 mount_bdev+0x274/0x370 fs/super.c:1400 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x45c/0x804 fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe4/0x498 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:768 dquot_load_quota_sb+0x6f0/0xb1c fs/quota/dquot.c:2461 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2498 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:927 ocfs2_fill_super+0x3698/0x498c fs/ocfs2/super.c:1140 mount_bdev+0x274/0x370 fs/super.c:1400 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187 legacy_get_tree+0xd4/0x16c fs/fs_context.c:611 vfs_get_tree+0x90/0x274 fs/super.c:1530 do_new_mount+0x278/0x8fc fs/namespace.c:3012 path_mount+0x594/0x101c fs/namespace.c:3342 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount fs/namespace.c:3540 [inline] __arm64_sys_mount+0x510/0x5e0 fs/namespace.c:3540 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (sb_internal#5){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_write_info+0x114/0x354 fs/ocfs2/quota_global.c:977 dquot_set_dqinfo+0x398/0x5f4 fs/quota/dquot.c:2902 quota_setinfo+0x3d8/0x524 fs/quota/quota.c:173 do_quotactl+0x4c0/0x698 fs/quota/quota.c:795 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: sb_internal#5 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2); lock(&ocfs2_quota_ip_alloc_sem_key); lock(sb_internal#5); *** DEADLOCK *** 3 locks held by syz.4.278/5079: #0: ffff0000c88ce0e0 (&type->s_umount_key#92){.+.+}-{3:3}, at: user_get_super+0x11c/0x240 fs/super.c:850 #1: ffff0000de31ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000de31ed88 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 #2: ffff0000de31ea20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 0 PID: 5079 Comm: syz.4.278 Not tainted 5.15.173-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2dc/0x804 fs/ocfs2/journal.c:350 ocfs2_write_info+0x114/0x354 fs/ocfs2/quota_global.c:977 dquot_set_dqinfo+0x398/0x5f4 fs/quota/dquot.c:2902 quota_setinfo+0x3d8/0x524 fs/quota/quota.c:173 do_quotactl+0x4c0/0x698 fs/quota/quota.c:795 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584