====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc6-syzkaller-00157-g6e7ffa180a53 #0 Not tainted ------------------------------------------------------ syz-executor.0/28377 is trying to acquire lock: ffff88807a1ca3f0 ( clock-AF_UNIX){++..}-{2:2}, at: sk_psock_drop+0x34/0x500 net/core/skmsg.c:837 but task is already holding lock: ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_hash_delete_from_link net/core/sock_map.c:920 [inline] ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_unlink net/core/sock_map.c:1572 [inline] ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_remove_links+0x1c5/0x6c0 net/core/sock_map.c:1584 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&htab->buckets[i].lock){+.-.}-{2:2}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:356 [inline] sock_hash_delete_elem+0x17c/0x400 net/core/sock_map.c:945 0xffffffffa0000d37 bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline] __bpf_prog_run include/linux/filter.h:657 [inline] bpf_prog_run include/linux/filter.h:664 [inline] __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline] bpf_trace_run2+0x204/0x420 kernel/trace/bpf_trace.c:2420 trace_kfree include/trace/events/kmem.h:94 [inline] kfree+0x2af/0x3a0 mm/slub.c:4377 __bpf_prog_put_noref+0xd7/0x310 kernel/bpf/syscall.c:2244 bpf_prog_put_deferred+0x2f3/0x3e0 kernel/bpf/syscall.c:2270 __bpf_prog_put kernel/bpf/syscall.c:2282 [inline] bpf_prog_put+0x264/0x2a0 kernel/bpf/syscall.c:2289 psock_set_prog include/linux/skmsg.h:477 [inline] sk_psock_stop_verdict net/core/skmsg.c:1248 [inline] sk_psock_drop+0x24d/0x500 net/core/skmsg.c:843 sk_psock_put include/linux/skmsg.h:459 [inline] sock_map_close+0x209/0x2d0 net/core/sock_map.c:1654 unix_release+0x85/0xc0 net/unix/af_unix.c:1048 __sock_release net/socket.c:659 [inline] sock_close+0xbc/0x240 net/socket.c:1421 __fput+0x429/0x8a0 fs/file_table.c:422 task_work_run+0x24f/0x310 kernel/task_work.c:180 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0xa1b/0x27e0 kernel/exit.c:878 do_group_exit+0x207/0x2c0 kernel/exit.c:1027 get_signal+0x16a1/0x1740 kernel/signal.c:2911 arch_do_signal_or_restart+0x96/0x860 arch/x86/kernel/signal.c:310 exit_to_user_mode_loop kernel/entry/common.c:111 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0xc9/0x370 kernel/entry/common.c:218 do_syscall_64+0x102/0x240 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (clock-AF_UNIX){++..}-{2:2}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __raw_write_lock_bh include/linux/rwlock_api_smp.h:202 [inline] _raw_write_lock_bh+0x35/0x50 kernel/locking/spinlock.c:334 sk_psock_drop+0x34/0x500 net/core/skmsg.c:837 sock_hash_delete_from_link net/core/sock_map.c:925 [inline] sock_map_unlink net/core/sock_map.c:1572 [inline] sock_map_remove_links+0x573/0x6c0 net/core/sock_map.c:1584 sock_map_unhash+0x17c/0x310 net/core/sock_map.c:1601 unix_shutdown+0x232/0x410 net/unix/af_unix.c:3013 __sys_shutdown_sock net/socket.c:2425 [inline] __sys_shutdown net/socket.c:2437 [inline] __do_sys_shutdown net/socket.c:2445 [inline] __se_sys_shutdown+0x14e/0x1b0 net/socket.c:2443 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&htab->buckets[i].lock); lock( clock-AF_UNIX); lock(&htab->buckets[i].lock); lock(clock-AF_UNIX); *** DEADLOCK *** 2 locks held by syz-executor.0/28377: #0: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline] #0: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:781 [inline] #0: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: sock_map_unhash+0x21/0x310 net/core/sock_map.c:1594 #1: ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline] #1: ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_hash_delete_from_link net/core/sock_map.c:920 [inline] #1: ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_unlink net/core/sock_map.c:1572 [inline] #1: ffff88801f172e20 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_map_remove_links+0x1c5/0x6c0 net/core/sock_map.c:1584 stack backtrace: CPU: 1 PID: 28377 Comm: syz-executor.0 Not tainted 6.9.0-rc6-syzkaller-00157-g6e7ffa180a53 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __raw_write_lock_bh include/linux/rwlock_api_smp.h:202 [inline] _raw_write_lock_bh+0x35/0x50 kernel/locking/spinlock.c:334 sk_psock_drop+0x34/0x500 net/core/skmsg.c:837 sock_hash_delete_from_link net/core/sock_map.c:925 [inline] sock_map_unlink net/core/sock_map.c:1572 [inline] sock_map_remove_links+0x573/0x6c0 net/core/sock_map.c:1584 sock_map_unhash+0x17c/0x310 net/core/sock_map.c:1601 unix_shutdown+0x232/0x410 net/unix/af_unix.c:3013 __sys_shutdown_sock net/socket.c:2425 [inline] __sys_shutdown net/socket.c:2437 [inline] __do_sys_shutdown net/socket.c:2445 [inline] __se_sys_shutdown+0x14e/0x1b0 net/socket.c:2443 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fa93307dd69 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa933dd90c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000030 RAX: ffffffffffffffda RBX: 00007fa9331abf80 RCX: 00007fa93307dd69 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000008 RBP: 00007fa9330ca49e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fa9331abf80 R15: 00007ffc5757c9c8