ip_tables: iptables: counters copy to user failed while replacing table Dead loop on virtual device sit0, fix it urgently! ====================================================== WARNING: possible circular locking dependency detected 4.14.171-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/26447 is trying to acquire lock: (rtnl_mutex){+.+.}, at: [] rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72 but task is already holding lock: (&xt[i].mutex){+.+.}, at: [] xt_find_table_lock+0x3c/0x3d0 net/netfilter/x_tables.c:1092 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&xt[i].mutex){+.+.}: lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 xt_find_revision+0x82/0x200 net/netfilter/x_tables.c:373 nfnl_compat_get+0x229/0x950 net/netfilter/nft_compat.c:678 nfnetlink_rcv_msg+0xa08/0xc00 net/netfilter/nfnetlink.c:214 netlink_rcv_skb+0x14f/0x3c0 net/netlink/af_netlink.c:2432 nfnetlink_rcv+0x1ab/0x1650 net/netfilter/nfnetlink.c:515 netlink_unicast_kernel net/netlink/af_netlink.c:1286 [inline] netlink_unicast+0x44d/0x650 net/netlink/af_netlink.c:1312 netlink_sendmsg+0x7c4/0xc60 net/netlink/af_netlink.c:1877 sock_sendmsg_nosec net/socket.c:646 [inline] sock_sendmsg+0xce/0x110 net/socket.c:656 PM: Basic memory bitmaps created ___sys_sendmsg+0x70a/0x840 net/socket.c:2062 __sys_sendmsg+0xb9/0x140 net/socket.c:2096 SYSC_sendmsg net/socket.c:2107 [inline] SyS_sendmsg+0x2d/0x50 net/socket.c:2103 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 -> #1 (&table[i].mutex){+.+.}: lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 Dead loop on virtual device sit0, fix it urgently! mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 nfnl_lock+0x24/0x30 net/netfilter/nfnetlink.c:61 nf_tables_netdev_event+0x13f/0x580 net/netfilter/nf_tables_netdev.c:122 notifier_call_chain+0x111/0x1b0 kernel/notifier.c:93 __raw_notifier_call_chain kernel/notifier.c:394 [inline] raw_notifier_call_chain+0x2e/0x40 kernel/notifier.c:401 syz-executor.4 (26455) used greatest stack depth: 5896 bytes left call_netdevice_notifiers_info+0x56/0x70 net/core/dev.c:1671 call_netdevice_notifiers net/core/dev.c:1687 [inline] rollback_registered_many+0x70d/0xb60 net/core/dev.c:7205 rollback_registered+0xdd/0x180 net/core/dev.c:7247 unregister_netdevice_queue net/core/dev.c:8259 [inline] unregister_netdevice_queue+0x1ae/0x230 net/core/dev.c:8252 br_dev_delete+0x13a/0x190 net/bridge/br_if.c:318 br_del_bridge+0xb4/0xf0 net/bridge/br_if.c:419 br_ioctl_deviceless_stub+0x23b/0x6a0 net/bridge/br_ioctl.c:380 sock_ioctl+0x26a/0x470 net/socket.c:1038 vfs_ioctl fs/ioctl.c:46 [inline] file_ioctl fs/ioctl.c:500 [inline] do_vfs_ioctl+0x7ae/0x1060 fs/ioctl.c:684 PM: Basic memory bitmaps freed SYSC_ioctl fs/ioctl.c:701 [inline] SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 -> #0 (rtnl_mutex){+.+.}: check_prev_add kernel/locking/lockdep.c:1901 [inline] check_prevs_add kernel/locking/lockdep.c:2018 [inline] validate_chain kernel/locking/lockdep.c:2460 [inline] __lock_acquire+0x2cb3/0x4620 kernel/locking/lockdep.c:3487 lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 PM: Marking nosave pages: [mem 0x00000000-0x00000fff] mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72 unregister_netdevice_notifier+0x5f/0x2c0 net/core/dev.c:1634 tee_tg_destroy+0x61/0xc0 net/netfilter/xt_TEE.c:123 PM: Marking nosave pages: [mem 0x0009f000-0x000fffff] cleanup_entry+0x17d/0x230 net/ipv4/netfilter/ip_tables.c:666 __do_replace+0x3c5/0x5b0 net/ipv4/netfilter/ip_tables.c:1086 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline] do_ipt_set_ctl+0x296/0x3ee net/ipv4/netfilter/ip_tables.c:1674 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x67/0xc0 net/netfilter/nf_sockopt.c:115 PM: Marking nosave pages: [mem 0xbfffd000-0xffffffff] ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline] ip_setsockopt+0x9b/0xb0 net/ipv4/ip_sockglue.c:1240 udp_setsockopt+0x4e/0x90 net/ipv4/udp.c:2451 sock_common_setsockopt+0x94/0xd0 net/core/sock.c:2968 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x13c/0x210 net/socket.c:1844 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 other info that might help us debug this: Chain exists of: rtnl_mutex --> &table[i].mutex --> &xt[i].mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&xt[i].mutex); lock(&table[i].mutex); lock(&xt[i].mutex); lock(rtnl_mutex); *** DEADLOCK *** 1 lock held by syz-executor.4/26447: #0: (&xt[i].mutex){+.+.}, at: [] xt_find_table_lock+0x3c/0x3d0 net/netfilter/x_tables.c:1092 stack backtrace: CPU: 1 PID: 26447 Comm: syz-executor.4 Not tainted 4.14.171-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x142/0x197 lib/dump_stack.c:58 print_circular_bug.isra.0.cold+0x1cc/0x28f kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1901 [inline] check_prevs_add kernel/locking/lockdep.c:2018 [inline] validate_chain kernel/locking/lockdep.c:2460 [inline] __lock_acquire+0x2cb3/0x4620 kernel/locking/lockdep.c:3487 lock_acquire+0x16f/0x430 kernel/locking/lockdep.c:3994 __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xe8/0x1470 kernel/locking/mutex.c:893 mutex_lock_nested+0x16/0x20 kernel/locking/mutex.c:908 rtnl_lock+0x17/0x20 net/core/rtnetlink.c:72 unregister_netdevice_notifier+0x5f/0x2c0 net/core/dev.c:1634 tee_tg_destroy+0x61/0xc0 net/netfilter/xt_TEE.c:123 cleanup_entry+0x17d/0x230 net/ipv4/netfilter/ip_tables.c:666 __do_replace+0x3c5/0x5b0 net/ipv4/netfilter/ip_tables.c:1086 do_replace net/ipv4/netfilter/ip_tables.c:1142 [inline] do_ipt_set_ctl+0x296/0x3ee net/ipv4/netfilter/ip_tables.c:1674 nf_sockopt net/netfilter/nf_sockopt.c:106 [inline] nf_setsockopt+0x67/0xc0 net/netfilter/nf_sockopt.c:115 ip_setsockopt net/ipv4/ip_sockglue.c:1255 [inline] ip_setsockopt+0x9b/0xb0 net/ipv4/ip_sockglue.c:1240 udp_setsockopt+0x4e/0x90 net/ipv4/udp.c:2451 sock_common_setsockopt+0x94/0xd0 net/core/sock.c:2968 SYSC_setsockopt net/socket.c:1865 [inline] SyS_setsockopt+0x13c/0x210 net/socket.c:1844 do_syscall_64+0x1e8/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x42/0xb7 RIP: 0033:0x45c449 RSP: 002b:00007fa94a1d0c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000036 RAX: ffffffffffffffda RBX: 00007fa94a1d16d4 RCX: 000000000045c449 RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003 RBP: 000000000076bf20 R08: 0000000000000001 R09: 0000000000000000 R10: 0000000020000840 R11: 0000000000000246 R12: 00000000ffffffff R13: 0000000000000a0b R14: 00000000004cc75d R15: 000000000076bf2c ip_tables: iptables: counters copy to user failed while replacing table PM: Basic memory bitmaps created syz-executor.4 (26447) used greatest stack depth: 5760 bytes left netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'. PM: Basic memory bitmaps freed netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'. ip_tables: iptables: counters copy to user failed while replacing table ip_tables: iptables: counters copy to user failed while replacing table Dead loop on virtual device sit0, fix it urgently! netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'. PM: Marking nosave pages: [mem 0x00000000-0x00000fff] Dead loop on virtual device sit0, fix it urgently! PM: Marking nosave pages: [mem 0x0009f000-0x000fffff] PM: Marking nosave pages: [mem 0xbfffd000-0xffffffff] ip_tables: iptables: counters copy to user failed while replacing table netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'. Dead loop on virtual device sit0, fix it urgently! netlink: 12 bytes leftover after parsing attributes in process `syz-executor.2'. PM: Basic memory bitmaps created PM: Basic memory bitmaps freed PM: Marking nosave pages: [mem 0x00000000-0x00000fff] PM: Marking nosave pages: [mem 0x0009f000-0x000fffff] PM: Marking nosave pages: [mem 0xbfffd000-0xffffffff] PM: Basic memory bitmaps created PM: Basic memory bitmaps freed PM: Marking nosave pages: [mem 0x00000000-0x00000fff] PM: Marking nosave pages: [mem 0x0009f000-0x000fffff] PM: Marking nosave pages: [mem 0xbfffd000-0xffffffff] PM: Basic memory bitmaps created PM: Basic memory bitmaps freed netlink: 4 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 4 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 4 bytes leftover after parsing attributes in process `syz-executor.3'. device vxcan2 entered promiscuous mode cgroup: cgroup2: unknown option "" netlink: 4 bytes leftover after parsing attributes in process `syz-executor.3'. cgroup: cgroup2: unknown option "" device vxcan2 entered promiscuous mode netlink: 4 bytes leftover after parsing attributes in process `syz-executor.3'. device vxcan2 entered promiscuous mode device vxcan2 entered promiscuous mode usb usb7: usbfs: process 27010 (syz-executor.3) did not claim interface 0 before use usb usb7: usbfs: process 27010 (syz-executor.3) did not claim interface 0 before use usb usb7: usbfs: process 27014 (syz-executor.3) did not claim interface 0 before use usb usb7: usbfs: process 27017 (syz-executor.3) did not claim interface 0 before use