====================================================== WARNING: possible circular locking dependency detected 6.12.0-syzkaller-00971-g158f238aa69d #0 Not tainted ------------------------------------------------------ syz.9.1063/9491 is trying to acquire lock: ffff8880575c1800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:818 [inline] ffff8880575c1800 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}, at: ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2726 but task is already holding lock: ffff888054494da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write+0x1a7/0xf30 fs/ocfs2/aops.c:2321 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0x93/0x200 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x158/0xb40 fs/ocfs2/quota_local.c:1231 ocfs2_acquire_dquot+0x629/0xaf0 fs/ocfs2/quota_global.c:878 dqget+0x694/0x1160 fs/quota/dquot.c:976 __dquot_initialize+0x588/0xd50 fs/quota/dquot.c:1504 ocfs2_get_init_inode+0xe8/0x1a0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x938/0x2440 fs/ocfs2/namei.c:308 ocfs2_mkdir+0x185/0x450 fs/ocfs2/namei.c:655 vfs_mkdir+0x580/0x860 fs/namei.c:4311 do_mkdirat+0x301/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x5f2/0x1160 fs/quota/dquot.c:971 __dquot_initialize+0x588/0xd50 fs/quota/dquot.c:1504 ocfs2_get_init_inode+0xe8/0x1a0 fs/ocfs2/namei.c:202 ocfs2_mknod+0x938/0x2440 fs/ocfs2/namei.c:308 ocfs2_mkdir+0x185/0x450 fs/ocfs2/namei.c:655 vfs_mkdir+0x580/0x860 fs/namei.c:4311 do_mkdirat+0x301/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}: down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_remove_inode+0x15c/0x8a0 fs/ocfs2/inode.c:655 ocfs2_wipe_inode+0x455/0x1220 fs/ocfs2/inode.c:818 ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline] ocfs2_evict_inode+0x6c5/0x15d0 fs/ocfs2/inode.c:1216 evict+0x40c/0x960 fs/inode.c:796 iput_final fs/inode.c:1947 [inline] iput fs/inode.c:1973 [inline] iput+0x530/0x890 fs/inode.c:1959 ocfs2_dentry_iput+0x13a/0x340 fs/ocfs2/dcache.c:411 dentry_unlink_inode+0x282/0x480 fs/dcache.c:420 __dentry_kill+0x1d0/0x600 fs/dcache.c:625 dput.part.0+0x4b1/0x9b0 fs/dcache.c:867 dput+0x1f/0x30 fs/dcache.c:857 ovl_check_rename_whiteout fs/overlayfs/super.c:586 [inline] ovl_make_workdir fs/overlayfs/super.c:685 [inline] ovl_get_workdir fs/overlayfs/super.c:808 [inline] ovl_fill_super+0x1300/0x6720 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xdd/0x190 fs/super.c:1299 vfs_get_tree+0x92/0x380 fs/super.c:1814 do_new_mount fs/namespace.c:3507 [inline] path_mount+0x14e6/0x1f20 fs/namespace.c:3834 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount fs/namespace.c:4034 [inline] __x64_sys_mount+0x294/0x320 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x250b/0x3ce0 kernel/locking/lockdep.c:5202 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5825 down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2726 ocfs2_dio_end_io_write+0x2cc/0xf30 fs/ocfs2/aops.c:2329 ocfs2_dio_end_io+0x139/0x2a0 fs/ocfs2/aops.c:2427 dio_complete+0x21b/0x8e0 fs/direct-io.c:281 __blockdev_direct_IO+0x3412/0x40b0 fs/direct-io.c:1303 ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2464 generic_file_direct_write+0x19a/0x410 mm/filemap.c:3979 __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4143 ocfs2_file_write_iter+0xb70/0x20e0 fs/ocfs2/file.c:2467 do_iter_readv_writev+0x535/0x7f0 fs/read_write.c:820 vfs_writev+0x363/0xdd0 fs/read_write.c:1050 do_writev+0x133/0x340 fs/read_write.c:1096 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&dquot->dq_lock); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); *** DEADLOCK *** 4 locks held by syz.9.1063/9491: #0: ffff88807efefeb8 (&f->f_pos_lock){+.+.}-{3:3}, at: fdget_pos+0x267/0x390 fs/file.c:1191 #1: ffff88805c57c420 (sb_writers#18){.+.+}-{0:0}, at: do_writev+0x133/0x340 fs/read_write.c:1096 #2: ffff888054495100 (&sb->s_type->i_mutex_key#26){++++}-{3:3}, at: inode_lock include/linux/fs.h:818 [inline] #2: ffff888054495100 (&sb->s_type->i_mutex_key#26){++++}-{3:3}, at: ocfs2_file_write_iter+0x1170/0x20e0 fs/ocfs2/file.c:2399 #3: ffff888054494da0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_dio_end_io_write+0x1a7/0xf30 fs/ocfs2/aops.c:2321 stack backtrace: CPU: 0 UID: 0 PID: 9491 Comm: syz.9.1063 Not tainted 6.12.0-syzkaller-00971-g158f238aa69d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x41c/0x610 kernel/locking/lockdep.c:2074 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x250b/0x3ce0 kernel/locking/lockdep.c:5202 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5825 down_write+0x93/0x200 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_del_inode_from_orphan+0x112/0x700 fs/ocfs2/namei.c:2726 ocfs2_dio_end_io_write+0x2cc/0xf30 fs/ocfs2/aops.c:2329 ocfs2_dio_end_io+0x139/0x2a0 fs/ocfs2/aops.c:2427 dio_complete+0x21b/0x8e0 fs/direct-io.c:281 __blockdev_direct_IO+0x3412/0x40b0 fs/direct-io.c:1303 ocfs2_direct_IO+0x263/0x360 fs/ocfs2/aops.c:2464 generic_file_direct_write+0x19a/0x410 mm/filemap.c:3979 __generic_file_write_iter+0x11b/0x240 mm/filemap.c:4143 ocfs2_file_write_iter+0xb70/0x20e0 fs/ocfs2/file.c:2467 do_iter_readv_writev+0x535/0x7f0 fs/read_write.c:820 vfs_writev+0x363/0xdd0 fs/read_write.c:1050 do_writev+0x133/0x340 fs/read_write.c:1096 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f713517e759 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f7135f7d038 EFLAGS: 00000246 ORIG_RAX: 0000000000000014 RAX: ffffffffffffffda RBX: 00007f7135335f80 RCX: 00007f713517e759 RDX: 0000000000000001 RSI: 0000000020000140 RDI: 0000000000000005 RBP: 00007f71351f175e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f7135335f80 R15: 00007ffe346f8188