====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc2-syzkaller-g2e7aff49b5da #0 Not tainted ------------------------------------------------------ syz.2.43/6710 is trying to acquire lock: ffff0000f2464610 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_setattr+0xa90/0x19e4 fs/ocfs2/file.c:1263 but task is already holding lock: ffff0000dd32b120 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0xa84/0x19e4 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x670/0x1448 fs/ocfs2/xattr.c:3669 ocfs2_set_acl+0x410/0x4b4 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x230/0x374 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_remove_acl+0x470/0x6f4 fs/posix_acl.c:1241 ovl_do_remove_acl fs/overlayfs/overlayfs.h:352 [inline] ovl_workdir_create+0x3f4/0x74c fs/overlayfs/super.c:334 ovl_make_workdir fs/overlayfs/super.c:650 [inline] ovl_get_workdir+0x2b4/0x142c fs/overlayfs/super.c:808 ovl_fill_super+0x1004/0x2e40 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1299 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:676 vfs_get_tree+0x90/0x28c fs/super.c:1814 do_new_mount+0x278/0x900 fs/namespace.c:3507 path_mount+0x590/0xe04 fs/namespace.c:3834 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount fs/namespace.c:4034 [inline] __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_xattr_set_handle+0x40c/0x824 fs/ocfs2/xattr.c:3501 ocfs2_init_security_set+0xb4/0xd8 fs/ocfs2/xattr.c:7307 ocfs2_symlink+0x1a34/0x24d0 fs/ocfs2/namei.c:2011 vfs_symlink+0x138/0x28c fs/namei.c:4669 do_symlinkat+0x1bc/0x45c fs/namei.c:4695 __do_sys_symlinkat fs/namei.c:4711 [inline] __se_sys_symlinkat fs/namei.c:4708 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4708 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2820 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3182 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4287 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1873 vfs_symlink+0x138/0x28c fs/namei.c:4669 do_symlinkat+0x1bc/0x45c fs/namei.c:4695 __do_sys_symlinkat fs/namei.c:4711 [inline] __se_sys_symlinkat fs/namei.c:4708 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4708 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2820 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3182 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4287 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1873 vfs_symlink+0x138/0x28c fs/namei.c:4669 do_symlinkat+0x1bc/0x45c fs/namei.c:4695 __do_sys_symlinkat fs/namei.c:4711 [inline] __se_sys_symlinkat fs/namei.c:4708 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4708 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_setattr+0xa90/0x19e4 fs/ocfs2/file.c:1263 notify_change+0x9f0/0xca0 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x5b4/0x74c fs/overlayfs/super.c:344 ovl_make_workdir fs/overlayfs/super.c:650 [inline] ovl_get_workdir+0x2b4/0x142c fs/overlayfs/super.c:808 ovl_fill_super+0x1004/0x2e40 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1299 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:676 vfs_get_tree+0x90/0x28c fs/super.c:1814 do_new_mount+0x278/0x900 fs/namespace.c:3507 path_mount+0x590/0xe04 fs/namespace.c:3834 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount fs/namespace.c:4034 [inline] __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: sb_internal#4 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(&oi->ip_xattr_sem); lock(&oi->ip_alloc_sem); rlock(sb_internal#4); *** DEADLOCK *** 5 locks held by syz.2.43/6710: #0: ffff0000da3ac0e0 (&type->s_umount_key#71/1){+.+.}-{4:4}, at: alloc_super+0x1b0/0x834 fs/super.c:344 #1: ffff0000f2464420 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:515 #2: ffff0000dd329800 (&sb->s_type->i_mutex_key#28/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:853 [inline] #2: ffff0000dd329800 (&sb->s_type->i_mutex_key#28/1){+.+.}-{4:4}, at: ovl_workdir_create+0x138/0x74c fs/overlayfs/super.c:284 #3: ffff0000dd32b480 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #3: ffff0000dd32b480 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: ovl_workdir_create+0x548/0x74c fs/overlayfs/super.c:343 #4: ffff0000dd32b120 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0xa84/0x19e4 fs/ocfs2/file.c:1262 stack backtrace: CPU: 0 UID: 0 PID: 6710 Comm: syz.2.43 Not tainted 6.13.0-rc2-syzkaller-g2e7aff49b5da #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:484 (C) __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_setattr+0xa90/0x19e4 fs/ocfs2/file.c:1263 notify_change+0x9f0/0xca0 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x5b4/0x74c fs/overlayfs/super.c:344 ovl_make_workdir fs/overlayfs/super.c:650 [inline] ovl_get_workdir+0x2b4/0x142c fs/overlayfs/super.c:808 ovl_fill_super+0x1004/0x2e40 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb4/0x144 fs/super.c:1299 ovl_get_tree+0x28/0x38 fs/overlayfs/params.c:676 vfs_get_tree+0x90/0x28c fs/super.c:1814 do_new_mount+0x278/0x900 fs/namespace.c:3507 path_mount+0x590/0xe04 fs/namespace.c:3834 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount fs/namespace.c:4034 [inline] __arm64_sys_mount+0x4d4/0x5ac fs/namespace.c:4034 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features.