vcan0: j1939_tp_rxtimer: 0xffff888036e04c00: rx timeout, send abort ====================================================== WARNING: possible circular locking dependency detected 6.1.0-syzkaller-07445-g7e68dd7d07a2 #0 Not tainted ------------------------------------------------------ syz-executor.4/10981 is trying to acquire lock: ffff88803af050d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff88803af050d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 but task is already holding lock: ffff88803af05088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff88803af05088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff88803af05088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe9/0x220 net/can/j1939/transport.c:1248 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&priv->active_session_list_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1561 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x1b6/0x450 net/can/j1939/socket.c:208 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1109 [inline] j1939_session_completed+0x19a/0x1f0 net/can/j1939/transport.c:1222 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1392 [inline] j1939_xtp_rx_eoma+0x2a1/0x5e0 net/can/j1939/transport.c:1407 j1939_tp_cmd_recv net/can/j1939/transport.c:2096 [inline] j1939_tp_recv+0x71c/0xcd0 net/can/j1939/transport.c:2141 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x580 net/can/af_can.c:663 can_rcv+0x1e1/0x230 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5482 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5596 process_backlog+0x3e4/0x810 net/core/dev.c:5924 __napi_poll+0xb8/0x770 net/core/dev.c:6485 napi_poll net/core/dev.c:6552 [inline] net_rx_action+0xa00/0xde0 net/core/dev.c:6663 __do_softirq+0x1fb/0xadc kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306 -> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1275 j1939_netdev_notify+0x19d/0x1d0 net/can/j1939/main.c:379 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1944 call_netdevice_notifiers_extack net/core/dev.c:1982 [inline] call_netdevice_notifiers net/core/dev.c:1996 [inline] dev_close_many+0x309/0x630 net/core/dev.c:1530 unregister_netdevice_many_notify+0x416/0x19e0 net/core/dev.c:10813 rtnl_delete_link net/core/rtnetlink.c:3162 [inline] rtnl_dellink+0x38a/0xa90 net/core/rtnetlink.c:3214 rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6141 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2564 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1356 netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1932 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xd3/0x120 net/socket.c:734 ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1132 j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1257 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x690/0xfb0 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x1fb/0xadc kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:650 irq_exit_rcu+0x9/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:649 __sanitizer_cov_trace_pc+0x0/0x70 kernel/kcov.c:526 console_emit_next_record.constprop.0+0x550/0x890 arch/x86/include/asm/irqflags.h:45 console_flush_all+0x547/0x6e0 kernel/printk/printk.c:2887 console_unlock+0xb8/0x1f0 kernel/printk/printk.c:2964 vprintk_emit+0x1bd/0x600 kernel/printk/printk.c:2357 vprintk+0x84/0xa0 kernel/printk/printk_safe.c:50 _printk+0xbe/0xf1 kernel/printk/printk.c:2378 validate_nla lib/nlattr.c:389 [inline] __nla_validate_parse.cold+0x24/0xa7 lib/nlattr.c:600 __nla_parse+0x41/0x50 lib/nlattr.c:697 nla_parse_nested_deprecated include/net/netlink.h:1280 [inline] __rtnl_newlink+0x505/0x1840 net/core/rtnetlink.c:3528 rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3637 rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6141 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2564 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1356 netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1932 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xd3/0x120 net/socket.c:734 ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&priv->active_session_list_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); lock(&priv->j1939_socks_lock); *** DEADLOCK *** 4 locks held by syz-executor.4/10981: #0: ffffffff8e0c8928 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:75 [inline] #0: ffffffff8e0c8928 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x3e9/0xca0 net/core/rtnetlink.c:6138 #1: ffffffff8c77eb40 (console_lock){+.+.}-{0:0}, at: vprintk+0x84/0xa0 kernel/printk/printk_safe.c:50 #2: ffffffff8c77ef28 (console_srcu){....}-{0:0}, at: cpumask_check include/linux/cpumask.h:117 [inline] #2: ffffffff8c77ef28 (console_srcu){....}-{0:0}, at: cpumask_test_cpu include/linux/cpumask.h:444 [inline] #2: ffffffff8c77ef28 (console_srcu){....}-{0:0}, at: cpu_online include/linux/cpumask.h:1030 [inline] #2: ffffffff8c77ef28 (console_srcu){....}-{0:0}, at: console_is_usable kernel/printk/printk.c:2732 [inline] #2: ffffffff8c77ef28 (console_srcu){....}-{0:0}, at: console_flush_all+0x9a/0x6e0 kernel/printk/printk.c:2877 #3: ffff88803af05088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] #3: ffff88803af05088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] #3: ffff88803af05088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe9/0x220 net/can/j1939/transport.c:1248 stack backtrace: CPU: 1 PID: 10981 Comm: syz-executor.4 Not tainted 6.1.0-syzkaller-07445-g7e68dd7d07a2 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1132 j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1257 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x690/0xfb0 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x1fb/0xadc kernel/softirq.c:571 invoke_softirq kernel/softirq.c:445 [inline] __irq_exit_rcu+0x123/0x180 kernel/softirq.c:650 irq_exit_rcu+0x9/0x20 kernel/softirq.c:662 sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107 asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:649 RIP: 0010:__sanitizer_cov_trace_pc+0x0/0x70 kernel/kcov.c:200 Code: 56 6a 88 02 66 0f 1f 44 00 00 f3 0f 1e fa 48 8b be a8 01 00 00 e8 b0 ff ff ff 31 c0 c3 66 66 2e 0f 1f 84 00 00 00 00 00 66 90 0f 1e fa 65 8b 05 65 cc 81 7e 89 c1 48 8b 34 24 81 e1 00 01 00 RSP: 0018:ffffc90017d26f70 EFLAGS: 00000212 RAX: 0000000000003cc2 RBX: 0000000000000000 RCX: ffffc9000d24e000 RDX: 0000000000040000 RSI: ffffffff81657bca RDI: 0000000000000007 RBP: ffffc90017d27178 R08: 0000000000000007 R09: 0000000000000000 R10: 0000000000000200 R11: 0000000000000000 R12: 0000000000000001 R13: ffffffff91bc1e60 R14: 0000000000000200 R15: 0000000000000000 console_emit_next_record.constprop.0+0x550/0x890 arch/x86/include/asm/irqflags.h:45 console_flush_all+0x547/0x6e0 kernel/printk/printk.c:2887 console_unlock+0xb8/0x1f0 kernel/printk/printk.c:2964 vprintk_emit+0x1bd/0x600 kernel/printk/printk.c:2357 vprintk+0x84/0xa0 kernel/printk/printk_safe.c:50 _printk+0xbe/0xf1 kernel/printk/printk.c:2378 validate_nla lib/nlattr.c:389 [inline] __nla_validate_parse.cold+0x24/0xa7 lib/nlattr.c:600 __nla_parse+0x41/0x50 lib/nlattr.c:697 nla_parse_nested_deprecated include/net/netlink.h:1280 [inline] __rtnl_newlink+0x505/0x1840 net/core/rtnetlink.c:3528 rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3637 rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6141 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2564 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1356 netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1932 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xd3/0x120 net/socket.c:734 ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f2b3188c0d9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f2b3260a168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007f2b319abf80 RCX: 00007f2b3188c0d9 RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000000000004 RBP: 00007f2b318e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffead1f4f7f R14: 00007f2b3260a300 R15: 0000000000022000 vcan0: j1939_tp_rxtimer: 0xffff888036e04c00: abort rx timeout. Force session deactivation ---------------- Code disassembly (best guess), 2 bytes skipped: 0: 88 02 mov %al,(%rdx) 2: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1) 8: f3 0f 1e fa endbr64 c: 48 8b be a8 01 00 00 mov 0x1a8(%rsi),%rdi 13: e8 b0 ff ff ff callq 0xffffffc8 18: 31 c0 xor %eax,%eax 1a: c3 retq 1b: 66 66 2e 0f 1f 84 00 data16 nopw %cs:0x0(%rax,%rax,1) 22: 00 00 00 00 26: 66 90 xchg %ax,%ax * 28: f3 0f 1e fa endbr64 <-- trapping instruction 2c: 65 8b 05 65 cc 81 7e mov %gs:0x7e81cc65(%rip),%eax # 0x7e81cc98 33: 89 c1 mov %eax,%ecx 35: 48 8b 34 24 mov (%rsp),%rsi 39: 81 .byte 0x81 3a: e1 00 loope 0x3c 3c: 01 00 add %eax,(%rax)