====================================================== WARNING: possible circular locking dependency detected 6.4.0-rc6-syzkaller-00037-gb6dad5178cea #0 Not tainted ------------------------------------------------------ syz-executor.4/16179 is trying to acquire lock: ffff88807e284968 (&mm->mmap_lock){++++}-{3:3}, at: mmap_read_lock include/linux/mmap_lock.h:142 [inline] (&mm->mmap_lock){++++}-{3:3}, at: do_user_addr_fault arch/x86/mm/fault.c:1391 [inline] (&mm->mmap_lock){++++}-{3:3}, at: handle_page_fault arch/x86/mm/fault.c:1534 [inline] (&mm->mmap_lock){++++}-{3:3}, at: exc_page_fault+0x6a8/0x910 arch/x86/mm/fault.c:1590 but task is already holding lock: ffff88807c8d00b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&tree->tree_lock#2){+.+.}-{3:3}: lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_file_truncate+0x811/0xb40 fs/hfsplus/extents.c:595 hfsplus_file_release+0xf7/0x3e0 fs/hfsplus/inode.c:238 __fput+0x3b7/0x890 fs/file_table.c:321 task_work_run+0x24a/0x300 kernel/task_work.c:179 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xd9/0x100 kernel/entry/common.c:171 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:204 __syscall_exit_to_user_mode_work kernel/entry/common.c:286 [inline] syscall_exit_to_user_mode+0x64/0x280 kernel/entry/common.c:297 do_syscall_64+0x4d/0xc0 arch/x86/entry/common.c:86 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&hip->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x47b/0x1000 fs/buffer.c:2349 read_pages+0x5fa/0x830 mm/readahead.c:181 page_cache_ra_unbounded+0x697/0x7c0 mm/readahead.c:270 do_sync_mmap_readahead+0x7b6/0x9a0 mm/filemap.c:3193 filemap_fault+0x81b/0x1810 mm/filemap.c:3285 __do_fault+0x136/0x500 mm/memory.c:4176 do_read_fault mm/memory.c:4530 [inline] do_fault mm/memory.c:4659 [inline] do_pte_missing mm/memory.c:3647 [inline] handle_pte_fault mm/memory.c:4947 [inline] __handle_mm_fault mm/memory.c:5089 [inline] handle_mm_fault+0x41a8/0x5860 mm/memory.c:5243 faultin_page mm/gup.c:925 [inline] __get_user_pages+0x5d9/0x12b0 mm/gup.c:1147 __get_user_pages_locked mm/gup.c:1381 [inline] __gup_longterm_locked+0x203b/0x2ab0 mm/gup.c:2079 internal_get_user_pages_fast+0x2824/0x2c20 mm/gup.c:2985 __iov_iter_get_pages_alloc+0x3c9/0x940 lib/iov_iter.c:1522 iov_iter_get_pages lib/iov_iter.c:1565 [inline] iov_iter_get_pages2+0xd2/0x130 lib/iov_iter.c:1573 dio_refill_pages fs/direct-io.c:171 [inline] dio_get_page fs/direct-io.c:214 [inline] do_direct_IO fs/direct-io.c:904 [inline] __blockdev_direct_IO+0x1233/0x40e0 fs/direct-io.c:1237 blockdev_direct_IO include/linux/fs.h:2808 [inline] hfsplus_direct_IO+0xf8/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x208/0x460 mm/filemap.c:3853 __generic_file_write_iter+0x1c8/0x400 mm/filemap.c:4013 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4089 do_iter_write+0x7b1/0xcb0 fs/read_write.c:860 vfs_writev fs/read_write.c:933 [inline] do_pwritev+0x21a/0x360 fs/read_write.c:1030 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (mapping.invalidate_lock#12){.+.+}-{3:3}: lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705 down_read+0x47/0x2f0 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:830 [inline] filemap_fault+0x647/0x1810 mm/filemap.c:3277 __do_fault+0x136/0x500 mm/memory.c:4176 do_shared_fault mm/memory.c:4585 [inline] do_fault mm/memory.c:4663 [inline] do_pte_missing mm/memory.c:3647 [inline] handle_pte_fault mm/memory.c:4947 [inline] __handle_mm_fault mm/memory.c:5089 [inline] handle_mm_fault+0x2098/0x5860 mm/memory.c:5243 do_user_addr_fault arch/x86/mm/fault.c:1440 [inline] handle_page_fault arch/x86/mm/fault.c:1534 [inline] exc_page_fault+0x7d2/0x910 arch/x86/mm/fault.c:1590 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain+0x166b/0x58f0 kernel/locking/lockdep.c:3847 __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705 down_read+0x47/0x2f0 kernel/locking/rwsem.c:1520 mmap_read_lock include/linux/mmap_lock.h:142 [inline] do_user_addr_fault arch/x86/mm/fault.c:1391 [inline] handle_page_fault arch/x86/mm/fault.c:1534 [inline] exc_page_fault+0x6a8/0x910 arch/x86/mm/fault.c:1590 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 filldir+0x2a1/0x6a0 fs/readdir.c:249 dir_emit include/linux/fs.h:3159 [inline] hfsplus_readdir+0x67d/0x1300 fs/hfsplus/dir.c:181 iterate_dir+0x228/0x570 __do_sys_getdents fs/readdir.c:286 [inline] __se_sys_getdents+0x1ef/0x4c0 fs/readdir.c:271 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &hip->extents_lock --> &tree->tree_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock#2); lock(&hip->extents_lock); lock(&tree->tree_lock#2); rlock(&mm->mmap_lock); *** DEADLOCK *** 3 locks held by syz-executor.4/16179: #0: ffff888028700fe8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x254/0x2f0 fs/file.c:1047 #1: ffff88806342ef00 (&type->i_mutex_dir_key#20){++++}-{3:3}, at: iterate_dir+0x10e/0x570 fs/readdir.c:55 #2: ffff88807c8d00b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 stack backtrace: CPU: 1 PID: 16179 Comm: syz-executor.4 Not tainted 6.4.0-rc6-syzkaller-00037-gb6dad5178cea #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/27/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2188 check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain+0x166b/0x58f0 kernel/locking/lockdep.c:3847 __lock_acquire+0x1316/0x2070 kernel/locking/lockdep.c:5088 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5705 down_read+0x47/0x2f0 kernel/locking/rwsem.c:1520 mmap_read_lock include/linux/mmap_lock.h:142 [inline] do_user_addr_fault arch/x86/mm/fault.c:1391 [inline] handle_page_fault arch/x86/mm/fault.c:1534 [inline] exc_page_fault+0x6a8/0x910 arch/x86/mm/fault.c:1590 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 RIP: 0010:filldir+0x2a1/0x6a0 fs/readdir.c:253 Code: 93 ff 4c 89 f7 48 89 de e8 9c 08 93 ff 49 01 df 0f 88 5e 02 00 00 49 39 df 0f 82 55 02 00 00 0f 01 cb 0f ae e8 48 8b 44 24 30 <48> 89 43 08 48 8b 4c 24 10 48 8b 44 24 60 48 89 01 48 8b 44 24 18 RSP: 0018:ffffc900169df8a0 EFLAGS: 00050206 RAX: 0000000000000001 RBX: 0000000000000000 RCX: ffff8880373c9dc0 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000018 RBP: 0000000000000000 R08: ffffffff81f87914 R09: 0000000000000004 R10: 6600050002000000 R11: 300065006c006900 R12: ffffffff8affb000 R13: 0000000000000002 R14: 0000000000000018 R15: 0000000000000018 dir_emit include/linux/fs.h:3159 [inline] hfsplus_readdir+0x67d/0x1300 fs/hfsplus/dir.c:181 iterate_dir+0x228/0x570 __do_sys_getdents fs/readdir.c:286 [inline] __se_sys_getdents+0x1ef/0x4c0 fs/readdir.c:271 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f502d28c199 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f502e04a168 EFLAGS: 00000246 ORIG_RAX: 000000000000004e RAX: ffffffffffffffda RBX: 00007f502d3ac050 RCX: 00007f502d28c199 RDX: 0000000000000058 RSI: 0000000000000000 RDI: 0000000000000004 RBP: 00007f502d2e7ca1 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc6d82f6cf R14: 00007f502e04a300 R15: 0000000000022000 ---------------- Code disassembly (best guess): 0: 93 xchg %eax,%ebx 1: ff 4c 89 f7 decl -0x9(%rcx,%rcx,4) 5: 48 89 de mov %rbx,%rsi 8: e8 9c 08 93 ff callq 0xff9308a9 d: 49 01 df add %rbx,%r15 10: 0f 88 5e 02 00 00 js 0x274 16: 49 39 df cmp %rbx,%r15 19: 0f 82 55 02 00 00 jb 0x274 1f: 0f 01 cb stac 22: 0f ae e8 lfence 25: 48 8b 44 24 30 mov 0x30(%rsp),%rax * 2a: 48 89 43 08 mov %rax,0x8(%rbx) <-- trapping instruction 2e: 48 8b 4c 24 10 mov 0x10(%rsp),%rcx 33: 48 8b 44 24 60 mov 0x60(%rsp),%rax 38: 48 89 01 mov %rax,(%rcx) 3b: 48 8b 44 24 18 mov 0x18(%rsp),%rax