====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc6-next-20241108-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.1781/14579 is trying to acquire lock: ffff8880253e6870 (&q->limits_lock){+.+.}-{4:4}, at: queue_limits_start_update include/linux/blkdev.h:944 [inline] ffff8880253e6870 (&q->limits_lock){+.+.}-{4:4}, at: loop_reconfigure_limits+0x287/0x9f0 drivers/block/loop.c:1003 but task is already holding lock: ffff8880253e6228 (&q->q_usage_counter(io)#24){++++}-{0:0}, at: loop_set_block_size drivers/block/loop.c:1472 [inline] ffff8880253e6228 (&q->q_usage_counter(io)#24){++++}-{0:0}, at: lo_simple_ioctl drivers/block/loop.c:1496 [inline] ffff8880253e6228 (&q->q_usage_counter(io)#24){++++}-{0:0}, at: lo_ioctl+0x1344/0x1f50 drivers/block/loop.c:1559 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&q->q_usage_counter(io)#24){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 bio_queue_enter block/blk.h:75 [inline] blk_mq_submit_bio+0x1510/0x2490 block/blk-mq.c:3095 __submit_bio+0x2c2/0x560 block/blk-core.c:629 __submit_bio_noacct_mq block/blk-core.c:710 [inline] submit_bio_noacct_nocheck+0x4d3/0xe30 block/blk-core.c:739 ocfs2_read_blocks+0x8c3/0x1600 fs/ocfs2/buffer_head_io.c:330 ocfs2_read_inode_block_full fs/ocfs2/inode.c:1593 [inline] ocfs2_read_inode_block+0x106/0x1e0 fs/ocfs2/inode.c:1605 ocfs2_get_clusters+0x3d2/0xbd0 fs/ocfs2/extent_map.c:615 ocfs2_extent_map_get_blocks+0x24c/0x7d0 fs/ocfs2/extent_map.c:668 ocfs2_read_virt_blocks+0x313/0xb20 fs/ocfs2/extent_map.c:983 ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline] ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline] ocfs2_find_entry+0x43b/0x2780 fs/ocfs2/dir.c:1080 ocfs2_find_files_on_disk+0xff/0x360 fs/ocfs2/dir.c:1981 ocfs2_lookup_ino_from_name+0xb1/0x1e0 fs/ocfs2/dir.c:2003 _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline] ocfs2_get_system_file_inode+0x305/0x7b0 fs/ocfs2/sysfile.c:112 ocfs2_init_global_system_inodes+0x32c/0x730 fs/ocfs2/super.c:457 ocfs2_initialize_super fs/ocfs2/super.c:2248 [inline] ocfs2_fill_super+0x2f5b/0x5760 fs/ocfs2/super.c:994 mount_bdev+0x20a/0x2d0 fs/super.c:1693 legacy_get_tree+0xee/0x190 fs/fs_context.c:662 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&oi->ip_io_mutex){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 ocfs2_read_blocks+0x228/0x1600 fs/ocfs2/buffer_head_io.c:233 ocfs2_read_inode_block_full fs/ocfs2/inode.c:1593 [inline] ocfs2_read_inode_block+0x106/0x1e0 fs/ocfs2/inode.c:1605 ocfs2_assign_bh fs/ocfs2/dlmglue.c:2414 [inline] ocfs2_inode_lock_full_nested+0x300/0x1be0 fs/ocfs2/dlmglue.c:2509 ocfs2_inode_lock_atime+0x2d6/0x5b0 ocfs2_mmap+0xf8/0x2b0 fs/ocfs2/mmap.c:166 call_mmap include/linux/fs.h:2182 [inline] mmap_file mm/internal.h:124 [inline] __mmap_new_file_vma mm/vma.c:2291 [inline] __mmap_new_vma mm/vma.c:2355 [inline] __mmap_region+0x2204/0x2cd0 mm/vma.c:2456 mmap_region+0x1d0/0x2c0 mm/mmap.c:1347 do_mmap+0x8f0/0x1000 mm/mmap.c:496 vm_mmap_pgoff+0x214/0x430 mm/util.c:580 ksys_mmap_pgoff+0x4eb/0x720 mm/mmap.c:542 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&mm->mmap_lock){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __might_fault+0xc6/0x120 mm/memory.c:6751 _inline_copy_from_user include/linux/uaccess.h:162 [inline] _copy_from_user+0x2a/0xc0 lib/usercopy.c:18 copy_from_user include/linux/uaccess.h:212 [inline] __blk_trace_setup kernel/trace/blktrace.c:626 [inline] blk_trace_ioctl+0x1ad/0x9a0 kernel/trace/blktrace.c:740 blkdev_ioctl+0x40c/0x6a0 block/ioctl.c:682 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf5/0x170 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&q->debugfs_mutex){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 blk_mq_init_sched+0x3fa/0x830 block/blk-mq-sched.c:473 elevator_init_mq+0x20e/0x320 block/elevator.c:610 add_disk_fwnode+0x10d/0xf80 block/genhd.c:413 sd_probe+0xba6/0x1100 drivers/scsi/sd.c:4024 really_probe+0x2b8/0xad0 drivers/base/dd.c:658 __driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800 driver_probe_device+0x50/0x430 drivers/base/dd.c:830 __device_attach_driver+0x2d6/0x530 drivers/base/dd.c:958 bus_for_each_drv+0x24e/0x2e0 drivers/base/bus.c:459 __device_attach_async_helper+0x22d/0x300 drivers/base/dd.c:987 async_run_entry_fn+0xa8/0x420 kernel/async.c:129 process_one_work kernel/workqueue.c:3229 [inline] process_scheduled_works+0xa63/0x1850 kernel/workqueue.c:3310 worker_thread+0x870/0xd30 kernel/workqueue.c:3391 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #1 (&q->q_usage_counter(queue)#50){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 blk_queue_enter+0xe1/0x600 block/blk-core.c:328 blk_mq_alloc_request+0x26b/0xab0 block/blk-mq.c:652 scsi_alloc_request drivers/scsi/scsi_lib.c:1222 [inline] scsi_execute_cmd+0x177/0x1090 drivers/scsi/scsi_lib.c:304 read_capacity_16+0x2b4/0x1450 drivers/scsi/sd.c:2655 sd_read_capacity drivers/scsi/sd.c:2824 [inline] sd_revalidate_disk+0x1019/0xbcf0 drivers/scsi/sd.c:3734 sd_probe+0x9fa/0x1100 drivers/scsi/sd.c:4010 really_probe+0x2b8/0xad0 drivers/base/dd.c:658 __driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800 driver_probe_device+0x50/0x430 drivers/base/dd.c:830 __device_attach_driver+0x2d6/0x530 drivers/base/dd.c:958 bus_for_each_drv+0x24e/0x2e0 drivers/base/bus.c:459 __device_attach_async_helper+0x22d/0x300 drivers/base/dd.c:987 async_run_entry_fn+0xa8/0x420 kernel/async.c:129 process_one_work kernel/workqueue.c:3229 [inline] process_scheduled_works+0xa63/0x1850 kernel/workqueue.c:3310 worker_thread+0x870/0xd30 kernel/workqueue.c:3391 kthread+0x2f0/0x390 kernel/kthread.c:389 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #0 (&q->limits_lock){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 queue_limits_start_update include/linux/blkdev.h:944 [inline] loop_reconfigure_limits+0x287/0x9f0 drivers/block/loop.c:1003 loop_set_block_size drivers/block/loop.c:1473 [inline] lo_simple_ioctl drivers/block/loop.c:1496 [inline] lo_ioctl+0x1351/0x1f50 drivers/block/loop.c:1559 blkdev_ioctl+0x57d/0x6a0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf5/0x170 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &q->limits_lock --> &oi->ip_io_mutex --> &q->q_usage_counter(io)#24 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&q->q_usage_counter(io)#24); lock(&oi->ip_io_mutex); lock(&q->q_usage_counter(io)#24); lock(&q->limits_lock); *** DEADLOCK *** 3 locks held by syz.5.1781/14579: #0: ffff888142fd8360 (&lo->lo_mutex){+.+.}-{4:4}, at: lo_simple_ioctl drivers/block/loop.c:1485 [inline] #0: ffff888142fd8360 (&lo->lo_mutex){+.+.}-{4:4}, at: lo_ioctl+0x606/0x1f50 drivers/block/loop.c:1559 #1: ffff8880253e6228 (&q->q_usage_counter(io)#24){++++}-{0:0}, at: loop_set_block_size drivers/block/loop.c:1472 [inline] #1: ffff8880253e6228 (&q->q_usage_counter(io)#24){++++}-{0:0}, at: lo_simple_ioctl drivers/block/loop.c:1496 [inline] #1: ffff8880253e6228 (&q->q_usage_counter(io)#24){++++}-{0:0}, at: lo_ioctl+0x1344/0x1f50 drivers/block/loop.c:1559 #2: ffff8880253e6260 (&q->q_usage_counter(queue)#8){+.+.}-{0:0}, at: loop_set_block_size drivers/block/loop.c:1472 [inline] #2: ffff8880253e6260 (&q->q_usage_counter(queue)#8){+.+.}-{0:0}, at: lo_simple_ioctl drivers/block/loop.c:1496 [inline] #2: ffff8880253e6260 (&q->q_usage_counter(queue)#8){+.+.}-{0:0}, at: lo_ioctl+0x1344/0x1f50 drivers/block/loop.c:1559 stack backtrace: CPU: 1 UID: 0 PID: 14579 Comm: syz.5.1781 Not tainted 6.12.0-rc6-next-20241108-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 queue_limits_start_update include/linux/blkdev.h:944 [inline] loop_reconfigure_limits+0x287/0x9f0 drivers/block/loop.c:1003 loop_set_block_size drivers/block/loop.c:1473 [inline] lo_simple_ioctl drivers/block/loop.c:1496 [inline] lo_ioctl+0x1351/0x1f50 drivers/block/loop.c:1559 blkdev_ioctl+0x57d/0x6a0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf5/0x170 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f4a9ad7e719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f4a9bade038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f4a9af36058 RCX: 00007f4a9ad7e719 RDX: 0000000000000000 RSI: 0000000000004c09 RDI: 0000000000000008 RBP: 00007f4a9adf1616 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f4a9af36058 R15: 00007ffd6a6b4938