====================================================== WARNING: possible circular locking dependency detected 6.8.0-rc6-syzkaller-00037-g805d849d7c3c #0 Not tainted ------------------------------------------------------ syz-executor.2/12081 is trying to acquire lock: ffff888046054ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline] ffff888046054ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x5ee/0x1240 fs/ntfs3/file.c:501 but task is already holding lock: ffff888046054f00 (mapping.invalidate_lock#12){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:849 [inline] ffff888046054f00 (mapping.invalidate_lock#12){++++}-{3:3}, at: ntfs_fallocate+0x400/0x1240 fs/ntfs3/file.c:486 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (mapping.invalidate_lock#12){++++}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:859 [inline] filemap_fault+0x646/0x1680 mm/filemap.c:3237 __do_fault+0x135/0x460 mm/memory.c:4396 do_read_fault mm/memory.c:4758 [inline] do_fault mm/memory.c:4888 [inline] do_pte_missing mm/memory.c:3745 [inline] handle_pte_fault mm/memory.c:5164 [inline] __handle_mm_fault+0x49e6/0x72d0 mm/memory.c:5305 handle_mm_fault+0x27e/0x770 mm/memory.c:5470 faultin_page mm/gup.c:958 [inline] __get_user_pages+0x6bd/0x1600 mm/gup.c:1241 populate_vma_page_range+0x2aa/0x380 mm/gup.c:1679 __mm_populate+0x279/0x460 mm/gup.c:1788 mm_populate include/linux/mm.h:3391 [inline] vm_mmap_pgoff+0x304/0x420 mm/util.c:561 ksys_mmap_pgoff+0x503/0x6e0 mm/mmap.c:1425 do_syscall_64+0xf9/0x240 entry_SYSCALL_64_after_hwframe+0x6f/0x77 -> #1 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __might_fault+0xc5/0x120 mm/memory.c:6080 _copy_to_user+0x2a/0xb0 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:191 [inline] fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145 ni_fiemap+0x100b/0x1230 fs/ntfs3/frecord.c:1948 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1206 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x1a02/0x2b60 fs/ioctl.c:811 __do_sys_ioctl fs/ioctl.c:869 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:857 do_syscall_64+0xf9/0x240 entry_SYSCALL_64_after_hwframe+0x6f/0x77 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18ca/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline] ntfs_fallocate+0x5ee/0x1240 fs/ntfs3/file.c:501 vfs_fallocate+0x564/0x6c0 fs/open.c:328 ksys_fallocate fs/open.c:351 [inline] __do_sys_fallocate fs/open.c:359 [inline] __se_sys_fallocate fs/open.c:357 [inline] __x64_sys_fallocate+0xbd/0x110 fs/open.c:357 do_syscall_64+0xf9/0x240 entry_SYSCALL_64_after_hwframe+0x6f/0x77 other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#12 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#12); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#12); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.2/12081: #0: ffff888052a54420 (sb_writers#23){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2794 [inline] #0: ffff888052a54420 (sb_writers#23){.+.+}-{0:0}, at: vfs_fallocate+0x4d3/0x6c0 fs/open.c:327 #1: ffff888046054d60 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:804 [inline] #1: ffff888046054d60 (&sb->s_type->i_mutex_key#32){+.+.}-{3:3}, at: ntfs_fallocate+0x32f/0x1240 fs/ntfs3/file.c:472 #2: ffff888046054f00 (mapping.invalidate_lock#12){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:849 [inline] #2: ffff888046054f00 (mapping.invalidate_lock#12){++++}-{3:3}, at: ntfs_fallocate+0x400/0x1240 fs/ntfs3/file.c:486 stack backtrace: CPU: 0 PID: 12081 Comm: syz-executor.2 Not tainted 6.8.0-rc6-syzkaller-00037-g805d849d7c3c #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2e0 lib/dump_stack.c:106 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18ca/0x58e0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1121 [inline] ntfs_fallocate+0x5ee/0x1240 fs/ntfs3/file.c:501 vfs_fallocate+0x564/0x6c0 fs/open.c:328 ksys_fallocate fs/open.c:351 [inline] __do_sys_fallocate fs/open.c:359 [inline] __se_sys_fallocate fs/open.c:357 [inline] __x64_sys_fallocate+0xbd/0x110 fs/open.c:357 do_syscall_64+0xf9/0x240 entry_SYSCALL_64_after_hwframe+0x6f/0x77 RIP: 0033:0x7fe27b87dda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe27c53c0c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007fe27b9ac050 RCX: 00007fe27b87dda9 RDX: 0000000000000000 RSI: 0000000100000003 RDI: 0000000000000004 RBP: 00007fe27b8ca47a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000028120001 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007fe27b9ac050 R15: 00007ffdc29ea4e8