====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc1-syzkaller-g3eddb108abe3 #0 Not tainted ------------------------------------------------------ syz.0.220/7398 is trying to acquire lock: ffff0000dd66c428 (&dquot->dq_lock){+.+.}-{3:3}, at: wait_on_dquot fs/quota/dquot.c:355 [inline] ffff0000dd66c428 (&dquot->dq_lock){+.+.}-{3:3}, at: dqget+0x5f0/0xcec fs/quota/dquot.c:971 but task is already holding lock: ffff0000ee154620 (&ei->xattr_sem){++++}-{3:3}, at: ext4_setattr+0x8ac/0x1624 fs/ext4/inode.c:5367 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&ei->xattr_sem){++++}-{3:3}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline] ext4_xattr_set_handle+0x1dc/0x12d0 fs/ext4/xattr.c:2373 ext4_initxattrs+0xa4/0x11c fs/ext4/xattr_security.c:44 security_inode_init_security+0x73c/0x908 security/security.c:1846 ext4_init_security+0x44/0x58 fs/ext4/xattr_security.c:58 __ext4_new_inode+0x2be8/0x3830 fs/ext4/ialloc.c:1323 ext4_create+0x234/0x480 fs/ext4/namei.c:2834 lookup_open fs/namei.c:3595 [inline] open_last_lookups fs/namei.c:3694 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3930 do_filp_open+0x1bc/0x3cc fs/namei.c:3960 do_sys_openat2+0x124/0x1b8 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1441 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #4 (jbd2_handle){++++}-{0:0}: start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:771 dquot_load_quota_sb+0x6e4/0xb24 fs/quota/dquot.c:2458 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2495 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3f04/0x49d0 fs/ocfs2/super.c:1141 mount_bdev+0x1d4/0x2a0 fs/super.c:1679 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1188 legacy_get_tree+0xd4/0x16c fs/fs_context.c:662 vfs_get_tree+0x90/0x28c fs/super.c:1800 do_new_mount+0x278/0x900 fs/namespace.c:3507 path_mount+0x590/0xe04 fs/namespace.c:3834 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4055 [inline] __se_sys_mount fs/namespace.c:4032 [inline] __arm64_sys_mount+0x45c/0x5a8 fs/namespace.c:4032 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #3 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350 ocfs2_modify_bh+0xe4/0x484 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1220/0x15bc fs/ocfs2/quota_local.c:771 dquot_load_quota_sb+0x6e4/0xb24 fs/quota/dquot.c:2458 dquot_load_quota_inode+0x280/0x4f4 fs/quota/dquot.c:2495 ocfs2_enable_quotas+0x17c/0x3cc fs/ocfs2/super.c:926 ocfs2_fill_super+0x3f04/0x49d0 fs/ocfs2/super.c:1141 mount_bdev+0x1d4/0x2a0 fs/super.c:1679 ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1188 legacy_get_tree+0xd4/0x16c fs/fs_context.c:662 vfs_get_tree+0x90/0x28c fs/super.c:1800 do_new_mount+0x278/0x900 fs/namespace.c:3507 path_mount+0x590/0xe04 fs/namespace.c:3834 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4055 [inline] __se_sys_mount fs/namespace.c:4032 [inline] __arm64_sys_mount+0x45c/0x5a8 fs/namespace.c:4032 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #2 (sb_internal#5){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1716 [inline] sb_start_intwrite include/linux/fs.h:1899 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x3c4/0xa8c fs/ocfs2/quota_global.c:855 dqget+0x660/0xcec fs/quota/dquot.c:976 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1504 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1566 ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202 ocfs2_mknod+0x878/0x243c fs/ocfs2/namei.c:308 ocfs2_create+0x194/0x4e0 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3595 [inline] open_last_lookups fs/namei.c:3694 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3930 do_filp_open+0x1bc/0x3cc fs/namei.c:3960 do_sys_openat2+0x124/0x1b8 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1441 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #1 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x1a0/0x1778 fs/ocfs2/quota_local.c:1231 ocfs2_acquire_dquot+0x6fc/0xa8c fs/ocfs2/quota_global.c:878 dqget+0x660/0xcec fs/quota/dquot.c:976 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1504 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1566 ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202 ocfs2_mknod+0x878/0x243c fs/ocfs2/namei.c:308 ocfs2_create+0x194/0x4e0 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3595 [inline] open_last_lookups fs/namei.c:3694 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3930 do_filp_open+0x1bc/0x3cc fs/namei.c:3960 do_sys_openat2+0x124/0x1b8 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1441 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #0 (&dquot->dq_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x33f8/0x77c8 kernel/locking/lockdep.c:5202 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5825 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x5f0/0xcec fs/quota/dquot.c:971 dquot_transfer+0x248/0x5c0 fs/quota/dquot.c:2139 ext4_setattr+0x8bc/0x1624 fs/ext4/inode.c:5368 notify_change+0x9f0/0xca0 fs/attr.c:503 chown_common+0x438/0x700 fs/open.c:793 vfs_fchown fs/open.c:861 [inline] ksys_fchown+0xe0/0x158 fs/open.c:872 __do_sys_fchown fs/open.c:880 [inline] __se_sys_fchown fs/open.c:878 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:878 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 other info that might help us debug this: Chain exists of: &dquot->dq_lock --> jbd2_handle --> &ei->xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(&ei->xattr_sem); lock(jbd2_handle); lock(&ei->xattr_sem); lock(&dquot->dq_lock); *** DEADLOCK *** 3 locks held by syz.0.220/7398: #0: ffff0000eef4a420 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:559 #1: ffff0000ee154950 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline] #1: ffff0000ee154950 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: chown_common+0x348/0x700 fs/open.c:783 #2: ffff0000ee154620 (&ei->xattr_sem){++++}-{3:3}, at: ext4_setattr+0x8ac/0x1624 fs/ext4/inode.c:5367 stack backtrace: CPU: 0 UID: 0 PID: 7398 Comm: syz.0.220 Not tainted 6.12.0-rc1-syzkaller-g3eddb108abe3 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:319 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:326 __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x33f8/0x77c8 kernel/locking/lockdep.c:5202 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5825 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x5f0/0xcec fs/quota/dquot.c:971 dquot_transfer+0x248/0x5c0 fs/quota/dquot.c:2139 ext4_setattr+0x8bc/0x1624 fs/ext4/inode.c:5368 notify_change+0x9f0/0xca0 fs/attr.c:503 chown_common+0x438/0x700 fs/open.c:793 vfs_fchown fs/open.c:861 [inline] ksys_fchown+0xe0/0x158 fs/open.c:872 __do_sys_fchown fs/open.c:880 [inline] __se_sys_fchown fs/open.c:878 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:878 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598