====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc2-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/32086 is trying to acquire lock: ffff88802abaa0e0 (&type->s_umount_key#32){++++}-{3:3}, at: __super_lock fs/super.c:58 [inline] ffff88802abaa0e0 (&type->s_umount_key#32){++++}-{3:3}, at: super_lock+0x23c/0x380 fs/super.c:117 but task is already holding lock: ffff888148848108 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] ffff888148848108 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x14e9/0x1ce0 block/ioctl.c:502 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&bdev->bd_holder_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 bd_finish_claiming block/bdev.c:566 [inline] blkdev_get_by_dev.part.0+0x374/0xb20 block/bdev.c:799 blkdev_get_by_dev+0x75/0x80 block/bdev.c:829 setup_bdev_super+0x78/0x6f0 fs/super.c:1484 mount_bdev+0x1c0/0x2e0 fs/super.c:1626 legacy_get_tree+0x109/0x220 fs/fs_context.c:638 vfs_get_tree+0x8c/0x370 fs/super.c:1750 do_new_mount fs/namespace.c:3335 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3662 init_mount+0xbf/0x110 fs/init.c:25 do_mount_root+0xdd/0x2c0 init/do_mounts.c:166 mount_root_generic+0x19a/0x460 init/do_mounts.c:205 mount_block_root init/do_mounts.c:378 [inline] mount_root+0x241/0x480 init/do_mounts.c:405 prepare_namespace+0xe3/0x3f0 init/do_mounts.c:489 kernel_init_freeable+0x703/0x8f0 init/main.c:1560 kernel_init+0x1c/0x2a0 init/main.c:1437 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #4 (bdev_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 bd_prepare_to_claim+0x1a4/0x280 block/bdev.c:508 truncate_bdev_range+0x48/0x270 block/bdev.c:105 blk_ioctl_zeroout block/ioctl.c:185 [inline] blkdev_common_ioctl+0x10ff/0x1ce0 block/ioctl.c:510 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #3 (mapping.invalidate_lock#2){++++}-{3:3}: down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] filemap_fault+0x28c/0x3550 mm/filemap.c:3283 __do_fault+0x107/0x600 mm/memory.c:4204 do_read_fault mm/memory.c:4568 [inline] do_fault mm/memory.c:4705 [inline] do_pte_missing mm/memory.c:3669 [inline] handle_pte_fault mm/memory.c:4978 [inline] __handle_mm_fault+0x299e/0x3e10 mm/memory.c:5119 handle_mm_fault+0x478/0xa00 mm/memory.c:5284 faultin_page mm/gup.c:956 [inline] __get_user_pages+0x4b2/0x1480 mm/gup.c:1239 populate_vma_page_range+0x2d4/0x410 mm/gup.c:1666 __mm_populate+0x1d7/0x380 mm/gup.c:1775 mm_populate include/linux/mm.h:3305 [inline] vm_mmap_pgoff+0x2cd/0x3b0 mm/util.c:551 ksys_mmap_pgoff+0x422/0x5b0 mm/mmap.c:1400 __do_sys_mmap arch/x86/kernel/sys_x86_64.c:93 [inline] __se_sys_mmap arch/x86/kernel/sys_x86_64.c:86 [inline] __x64_sys_mmap+0x125/0x190 arch/x86/kernel/sys_x86_64.c:86 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&mm->mmap_lock){++++}-{3:3}: internal_get_user_pages_fast+0x1630/0x2a10 mm/gup.c:3185 pin_user_pages_fast+0xa8/0xf0 mm/gup.c:3309 iov_iter_extract_user_pages lib/iov_iter.c:1782 [inline] iov_iter_extract_pages+0x29f/0x19b0 lib/iov_iter.c:1845 __bio_iov_iter_get_pages block/bio.c:1255 [inline] bio_iov_iter_get_pages+0x37b/0xe80 block/bio.c:1333 iomap_dio_bio_iter+0xc45/0x1720 fs/iomap/direct-io.c:387 iomap_dio_iter fs/iomap/direct-io.c:500 [inline] __iomap_dio_rw+0xd62/0x1d70 fs/iomap/direct-io.c:659 iomap_dio_rw+0x40/0xa0 fs/iomap/direct-io.c:748 ext4_dio_write_iter fs/ext4/file.c:605 [inline] ext4_file_write_iter+0x1081/0x1860 fs/ext4/file.c:715 call_write_iter include/linux/fs.h:1985 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x650/0xe40 fs/read_write.c:584 ksys_write+0x12f/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:812 [inline] ext4_bmap+0x4f/0x280 fs/ext4/inode.c:3089 bmap+0xae/0x120 fs/inode.c:1826 jbd2_journal_init_inode+0x80/0x3d0 fs/jbd2/journal.c:1669 ext4_open_inode_journal fs/ext4/super.c:5833 [inline] ext4_load_journal fs/ext4/super.c:5992 [inline] ext4_load_and_init_journal+0x266/0x28f0 fs/ext4/super.c:4906 __ext4_fill_super fs/ext4/super.c:5374 [inline] ext4_fill_super+0x8c4b/0xad30 fs/ext4/super.c:5703 get_tree_bdev+0x3b5/0x650 fs/super.c:1577 vfs_get_tree+0x8c/0x370 fs/super.c:1750 do_new_mount fs/namespace.c:3335 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3662 init_mount+0xbf/0x110 fs/init.c:25 do_mount_root+0xdd/0x2c0 init/do_mounts.c:166 mount_root_generic+0x19a/0x460 init/do_mounts.c:205 mount_block_root init/do_mounts.c:378 [inline] mount_root+0x241/0x480 init/do_mounts.c:405 prepare_namespace+0xe3/0x3f0 init/do_mounts.c:489 kernel_init_freeable+0x703/0x8f0 init/main.c:1560 kernel_init+0x1c/0x2a0 init/main.c:1437 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #0 (&type->s_umount_key#32){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x23c/0x380 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0x94/0x1b0 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x1550/0x1ce0 block/ioctl.c:502 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &type->s_umount_key#32 --> bdev_lock --> &bdev->bd_holder_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&bdev->bd_holder_lock); lock(bdev_lock); lock(&bdev->bd_holder_lock); rlock(&type->s_umount_key#32); *** DEADLOCK *** 1 lock held by syz-executor.1/32086: #0: ffff888148848108 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] #0: ffff888148848108 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x14e9/0x1ce0 block/ioctl.c:502 stack backtrace: CPU: 1 PID: 32086 Comm: syz-executor.1 Not tainted 6.6.0-rc2-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/04/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x23c/0x380 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0x94/0x1b0 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x1550/0x1ce0 block/ioctl.c:502 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f858707cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f8587e900c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f858719bf80 RCX: 00007f858707cae9 RDX: ffffffffffffffff RSI: 0000000000001261 RDI: 0000000000000003 RBP: 00007f85870c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f858719bf80 R15: 00007ffe8b4b18b8