====================================================== WARNING: possible circular locking dependency detected 6.1.73-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/9765 is trying to acquire lock: ffff0000ce69e0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc but task is already holding lock: ffff0000dcd33048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x1e8/0x4ac fs/hfsplus/extents.c:104 hfsplus_ext_write_extent_locked fs/hfsplus/extents.c:139 [inline] hfsplus_ext_write_extent+0x158/0x1d8 fs/hfsplus/extents.c:150 hfsplus_write_inode+0x34/0x4dc fs/hfsplus/super.c:154 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1733 sync_inode_metadata+0xd4/0x144 fs/fs-writeback.c:2789 hfsplus_file_fsync+0xe4/0x4c8 fs/hfsplus/inode.c:321 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2941 [inline] generic_file_write_iter+0x228/0x2b4 mm/filemap.c:3981 call_write_iter include/linux/fs.h:2249 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x914 fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&tree->tree_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_find_init+0x144/0x1bc hfsplus_file_truncate+0x348/0x9b8 fs/hfsplus/extents.c:582 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 hfsplus_rename+0xd0/0x1b0 fs/hfsplus/dir.c:547 vfs_rename+0x8b8/0xd04 fs/namei.c:4863 do_renameat2+0x9c4/0xe34 fs/namei.c:5015 __do_sys_renameat2 fs/namei.c:5048 [inline] __se_sys_renameat2 fs/namei.c:5045 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5045 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFSPLUS_I(inode)->extents_lock); lock( &tree->tree_lock/1); *** DEADLOCK *** 6 locks held by syz-executor.1/9765: #0: ffff0000d772c460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff0000dcd31e00 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #1: ffff0000dcd31e00 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3042 [inline] #1: ffff0000dcd31e00 (&type->i_mutex_dir_key#10/1){+.+.}-{3:3}, at: do_renameat2+0x4e0/0xe34 fs/namei.c:4954 #2: ffff0000dcd32b80 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #2: ffff0000dcd32b80 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: lock_two_inodes+0xdc/0x158 fs/inode.c:1145 #3: ffff0000dcd33240 (&sb->s_type->i_mutex_key#23/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #3: ffff0000dcd33240 (&sb->s_type->i_mutex_key#23/4){+.+.}-{3:3}, at: lock_two_inodes+0xf8/0x158 fs/inode.c:1147 #4: ffff0000cf00c998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x144/0x6a0 fs/hfsplus/dir.c:370 #5: ffff0000dcd33048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 9765 Comm: syz-executor.1 Not tainted 6.1.73-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_find_init+0x144/0x1bc hfsplus_file_truncate+0x348/0x9b8 fs/hfsplus/extents.c:582 hfsplus_delete_inode+0x154/0x200 hfsplus_unlink+0x414/0x6a0 fs/hfsplus/dir.c:405 hfsplus_rename+0xd0/0x1b0 fs/hfsplus/dir.c:547 vfs_rename+0x8b8/0xd04 fs/namei.c:4863 do_renameat2+0x9c4/0xe34 fs/namei.c:5015 __do_sys_renameat2 fs/namei.c:5048 [inline] __se_sys_renameat2 fs/namei.c:5045 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5045 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585