ocfs2: Finishing quota recovery on device (7,0) for slot 0 ====================================================== WARNING: possible circular locking dependency detected 6.14.0-syzkaller-09352-g0c86b42439b6 #0 Not tainted ------------------------------------------------------ kworker/u4:2/26 is trying to acquire lock: ffff88801bf280e0 (&type->s_umount_key#48){++++}-{4:4}, at: ocfs2_finish_quota_recovery+0x15e/0x2310 fs/ocfs2/quota_local.c:603 but task is already holding lock: ffffc900004dfc60 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3214 [inline] ffffc900004dfc60 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_scheduled_works+0x9cb/0x18e0 kernel/workqueue.c:3319 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 process_one_work kernel/workqueue.c:3214 [inline] process_scheduled_works+0x9e9/0x18e0 kernel/workqueue.c:3319 worker_thread+0x870/0xd50 kernel/workqueue.c:3400 kthread+0x7b7/0x940 kernel/kthread.c:464 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 -> #1 ((wq_completion)ocfs2_wq){+.+.}-{0:0}: lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 touch_wq_lockdep_map+0xc7/0x170 kernel/workqueue.c:3907 __flush_workqueue+0x14c/0x1280 kernel/workqueue.c:3949 ocfs2_shutdown_local_alloc+0x10b/0xab0 fs/ocfs2/localalloc.c:380 ocfs2_dismount_volume+0x204/0x910 fs/ocfs2/super.c:1822 generic_shutdown_super+0x139/0x2d0 fs/super.c:642 kill_block_super+0x44/0x90 fs/super.c:1710 deactivate_locked_super+0xc4/0x130 fs/super.c:473 cleanup_mnt+0x422/0x4c0 fs/namespace.c:1435 task_work_run+0x251/0x310 kernel/task_work.c:227 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline] exit_to_user_mode_loop kernel/entry/common.c:114 [inline] exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline] __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline] syscall_exit_to_user_mode+0x13f/0x340 kernel/entry/common.c:218 do_syscall_64+0x100/0x230 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&type->s_umount_key#48){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524 ocfs2_finish_quota_recovery+0x15e/0x2310 fs/ocfs2/quota_local.c:603 ocfs2_complete_recovery+0x1977/0x2580 fs/ocfs2/journal.c:1357 process_one_work kernel/workqueue.c:3238 [inline] process_scheduled_works+0xac3/0x18e0 kernel/workqueue.c:3319 worker_thread+0x870/0xd50 kernel/workqueue.c:3400 kthread+0x7b7/0x940 kernel/kthread.c:464 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245 other info that might help us debug this: Chain exists of: &type->s_umount_key#48 --> (wq_completion)ocfs2_wq --> (work_completion)(&journal->j_recovery_work) Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock((work_completion)(&journal->j_recovery_work)); lock((wq_completion)ocfs2_wq); lock((work_completion)(&journal->j_recovery_work)); rlock(&type->s_umount_key#48); *** DEADLOCK *** 2 locks held by kworker/u4:2/26: #0: ffff88804083b148 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3213 [inline] #0: ffff88804083b148 ((wq_completion)ocfs2_wq){+.+.}-{0:0}, at: process_scheduled_works+0x990/0x18e0 kernel/workqueue.c:3319 #1: ffffc900004dfc60 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3214 [inline] #1: ffffc900004dfc60 ((work_completion)(&journal->j_recovery_work)){+.+.}-{0:0}, at: process_scheduled_works+0x9cb/0x18e0 kernel/workqueue.c:3319 stack backtrace: CPU: 0 UID: 0 PID: 26 Comm: kworker/u4:2 Not tainted 6.14.0-syzkaller-09352-g0c86b42439b6 #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Workqueue: ocfs2_wq ocfs2_complete_recovery Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211 check_prev_add kernel/locking/lockdep.c:3166 [inline] check_prevs_add kernel/locking/lockdep.c:3285 [inline] validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866 down_read+0xb3/0xa50 kernel/locking/rwsem.c:1524 ocfs2_finish_quota_recovery+0x15e/0x2310 fs/ocfs2/quota_local.c:603 ocfs2_complete_recovery+0x1977/0x2580 fs/ocfs2/journal.c:1357 process_one_work kernel/workqueue.c:3238 [inline] process_scheduled_works+0xac3/0x18e0 kernel/workqueue.c:3319 worker_thread+0x870/0xd50 kernel/workqueue.c:3400 kthread+0x7b7/0x940 kernel/kthread.c:464 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245