====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.0.0/5365 is trying to acquire lock: ffff8880530dc108 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1fc/0x1990 fs/hfsplus/extents.c:455 but task is already holding lock: ffff888038e120b0 (&tree->tree_lock/1){+.+.}-{4:4}, at: hfsplus_find_init+0x15a/0x1d0 fs/hfsplus/bfind.c:28 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock/1){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:760 hfsplus_find_init+0x15a/0x1d0 fs/hfsplus/bfind.c:28 hfsplus_file_truncate+0x383/0xb40 fs/hfsplus/extents.c:580 hfsplus_setattr+0x1c4/0x270 fs/hfsplus/inode.c:266 notify_change+0xb36/0xe40 fs/attr.c:552 do_truncate+0x1a4/0x220 fs/open.c:68 handle_truncate fs/namei.c:3508 [inline] do_open fs/namei.c:3891 [inline] path_openat+0x306c/0x3830 fs/namei.c:4046 do_filp_open+0x1fa/0x410 fs/namei.c:4073 do_sys_openat2+0x121/0x1c0 fs/open.c:1435 do_sys_open fs/open.c:1450 [inline] __do_sys_creat fs/open.c:1528 [inline] __se_sys_creat fs/open.c:1522 [inline] __x64_sys_creat+0x8f/0xc0 fs/open.c:1522 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:760 hfsplus_file_extend+0x1fc/0x1990 fs/hfsplus/extents.c:455 hfsplus_bmap_reserve+0x122/0x500 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x89/0xe30 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x444/0x1990 fs/hfsplus/extents.c:459 hfsplus_get_block+0x411/0x1530 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2145 block_write_begin fs/buffer.c:2256 [inline] cont_write_begin+0x789/0xb50 fs/buffer.c:2594 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 cont_expand_zero fs/buffer.c:2522 [inline] cont_write_begin+0x2fd/0xb50 fs/buffer.c:2584 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 generic_perform_write+0x2c2/0x900 mm/filemap.c:4175 generic_file_write_iter+0x117/0x550 mm/filemap.c:4318 __kernel_write_iter+0x428/0x910 fs/read_write.c:619 dump_emit_page fs/coredump.c:1296 [inline] dump_user_range+0x8a0/0xc90 fs/coredump.c:1370 elf_core_dump+0x337b/0x3990 fs/binfmt_elf.c:2085 coredump_write+0x1169/0x1900 fs/coredump.c:1049 vfs_coredump+0x1daa/0x2a50 fs/coredump.c:1168 get_signal+0x1109/0x1340 kernel/signal.c:3019 arch_do_signal_or_restart+0x9a/0x750 arch/x86/kernel/signal.c:337 exit_to_user_mode_loop kernel/entry/common.c:40 [inline] exit_to_user_mode_prepare include/linux/irq-entry-common.h:225 [inline] irqentry_exit_to_user_mode+0x81/0x120 kernel/entry/common.c:73 exc_page_fault+0x9f/0xf0 arch/x86/mm/fault.c:1535 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/1); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 4 locks held by syz.0.0/5365: #0: ffff88803e4de428 (sb_writers#12){.+.+}-{0:0}, at: vfs_coredump+0x1daa/0x2a50 fs/coredump.c:1168 #1: ffff8880530df238 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:870 [inline] #1: ffff8880530df238 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: generic_file_write_iter+0xeb/0x550 mm/filemap.c:4315 #2: ffff8880530df048 (&hip->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x1fc/0x1990 fs/hfsplus/extents.c:455 #3: ffff888038e120b0 (&tree->tree_lock/1){+.+.}-{4:4}, at: hfsplus_find_init+0x15a/0x1d0 fs/hfsplus/bfind.c:28 stack backtrace: CPU: 0 UID: 0 PID: 5365 Comm: syz.0.0 Not tainted syzkaller #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x187/0x1350 kernel/locking/mutex.c:760 hfsplus_file_extend+0x1fc/0x1990 fs/hfsplus/extents.c:455 hfsplus_bmap_reserve+0x122/0x500 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x89/0xe30 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x444/0x1990 fs/hfsplus/extents.c:459 hfsplus_get_block+0x411/0x1530 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2145 block_write_begin fs/buffer.c:2256 [inline] cont_write_begin+0x789/0xb50 fs/buffer.c:2594 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 cont_expand_zero fs/buffer.c:2522 [inline] cont_write_begin+0x2fd/0xb50 fs/buffer.c:2584 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 generic_perform_write+0x2c2/0x900 mm/filemap.c:4175 generic_file_write_iter+0x117/0x550 mm/filemap.c:4318 __kernel_write_iter+0x428/0x910 fs/read_write.c:619 dump_emit_page fs/coredump.c:1296 [inline] dump_user_range+0x8a0/0xc90 fs/coredump.c:1370 elf_core_dump+0x337b/0x3990 fs/binfmt_elf.c:2085 coredump_write+0x1169/0x1900 fs/coredump.c:1049 vfs_coredump+0x1daa/0x2a50 fs/coredump.c:1168 get_signal+0x1109/0x1340 kernel/signal.c:3019 arch_do_signal_or_restart+0x9a/0x750 arch/x86/kernel/signal.c:337 exit_to_user_mode_loop kernel/entry/common.c:40 [inline] exit_to_user_mode_prepare include/linux/irq-entry-common.h:225 [inline] irqentry_exit_to_user_mode+0x81/0x120 kernel/entry/common.c:73 exc_page_fault+0x9f/0xf0 arch/x86/mm/fault.c:1535 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 RIP: 0033:0x7f0c4bb8ebb1 Code: 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 48 3d 01 f0 ff ff 73 01 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f RSP: 002b:00000000fffffe10 EFLAGS: 00010217 RAX: 0000000000000000 RBX: 00007f0c4bdd5fa0 RCX: 00007f0c4bb8eba9 RDX: 0000000000000000 RSI: 00000000fffffe10 RDI: 0000000000000000 RBP: 00007f0c4bc11e19 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007f0c4bdd6038 R14: 00007f0c4bdd5fa0 R15: 00007fffe8e4e338 syz.0.0 (5365) used greatest stack depth: 18504 bytes left