====================================================== WARNING: possible circular locking dependency detected 6.1.139-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.663/6981 is trying to acquire lock: ffff0000cd84a650 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_setattr+0xafc/0x18d4 fs/ocfs2/file.c:1263 but task is already holding lock: ffff0000f5a6bf60 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xaf0/0x18d4 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}: down_read+0x64/0x304 kernel/locking/rwsem.c:1520 ocfs2_read_virt_blocks+0x244/0x8e0 fs/ocfs2/extent_map.c:976 ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline] ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline] ocfs2_find_entry+0x318/0x1c5c fs/ocfs2/dir.c:1091 ocfs2_rename+0x1818/0x2edc fs/ocfs2/namei.c:1568 vfs_rename+0x954/0xdcc fs/namei.c:4874 do_renameat2+0x738/0xa54 fs/namei.c:5027 __do_sys_renameat2 fs/namei.c:5060 [inline] __se_sys_renameat2 fs/namei.c:5057 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5057 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xfe0/0x122c fs/jbd2/transaction.c:463 jbd2__journal_start+0x288/0x51c fs/jbd2/transaction.c:520 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559 ocfs2_start_trans+0x380/0x6c4 fs/ocfs2/journal.c:376 ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1f0/0x93c fs/ocfs2/super.c:1882 ocfs2_put_super+0x108/0x390 fs/ocfs2/super.c:1609 generic_shutdown_super+0x130/0x324 fs/super.c:501 kill_block_super+0x70/0xdc fs/super.c:1470 deactivate_locked_super+0xac/0x124 fs/super.c:332 deactivate_super+0xe8/0x108 fs/super.c:363 cleanup_mnt+0x37c/0x404 fs/namespace.c:1186 __cleanup_mnt+0x20/0x30 fs/namespace.c:1193 task_work_run+0x1ec/0x270 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] do_notify_resume+0x1f70/0x2b0c arch/arm64/kernel/signal.c:1137 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x98/0x138 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x64/0x304 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x374/0x6c4 fs/ocfs2/journal.c:374 ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1f0/0x93c fs/ocfs2/super.c:1882 ocfs2_put_super+0x108/0x390 fs/ocfs2/super.c:1609 generic_shutdown_super+0x130/0x324 fs/super.c:501 kill_block_super+0x70/0xdc fs/super.c:1470 deactivate_locked_super+0xac/0x124 fs/super.c:332 deactivate_super+0xe8/0x108 fs/super.c:363 cleanup_mnt+0x37c/0x404 fs/namespace.c:1186 __cleanup_mnt+0x20/0x30 fs/namespace.c:1193 task_work_run+0x1ec/0x270 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] do_notify_resume+0x1f70/0x2b0c arch/arm64/kernel/signal.c:1137 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x98/0x138 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:372 ocfs2_setattr+0xafc/0x18d4 fs/ocfs2/file.c:1263 notify_change+0xb0c/0xdcc fs/attr.c:499 ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline] ovl_workdir_create+0x4a8/0x634 fs/overlayfs/super.c:833 ovl_make_workdir fs/overlayfs/super.c:1389 [inline] ovl_get_workdir+0x2fc/0x1068 fs/overlayfs/super.c:1539 ovl_fill_super+0x139c/0x2294 fs/overlayfs/super.c:2095 mount_nodev+0x68/0x104 fs/super.c:1489 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x228/0x810 fs/namespace.c:3058 path_mount+0x5b4/0xe78 fs/namespace.c:3388 do_mount fs/namespace.c:3401 [inline] __do_sys_mount fs/namespace.c:3609 [inline] __se_sys_mount fs/namespace.c:3586 [inline] __arm64_sys_mount+0x49c/0x584 fs/namespace.c:3586 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: sb_internal#4 --> jbd2_handle --> &ocfs2_file_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(jbd2_handle); lock(&ocfs2_file_ip_alloc_sem_key); lock(sb_internal#4); *** DEADLOCK *** 5 locks held by syz.3.663/6981: #0: ffff0000e5e540e0 (&type->s_umount_key#77/1){+.+.}-{3:3}, at: alloc_super+0x1a4/0x804 fs/super.c:228 #1: ffff0000cd84a460 (sb_writers#21){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #2: ffff0000f5a6df48 (&sb->s_type->i_mutex_key#33/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #2: ffff0000f5a6df48 (&sb->s_type->i_mutex_key#33/1){+.+.}-{3:3}, at: ovl_workdir_create+0x128/0x634 fs/overlayfs/super.c:771 #3: ffff0000f5a6c2c8 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff0000f5a6c2c8 (&sb->s_type->i_mutex_key#35){+.+.}-{3:3}, at: ovl_workdir_create+0x44c/0x634 fs/overlayfs/super.c:832 #4: ffff0000f5a6bf60 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_setattr+0xaf0/0x18d4 fs/ocfs2/file.c:1262 stack backtrace: CPU: 0 PID: 6981 Comm: syz.3.663 Not tainted 6.1.139-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack+0x30/0x40 lib/dump_stack.c:88 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2048 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x293c/0x6544 kernel/locking/lockdep.c:5049 lock_acquire+0x20c/0x644 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x20c/0x6c4 fs/ocfs2/journal.c:372 ocfs2_setattr+0xafc/0x18d4 fs/ocfs2/file.c:1263 notify_change+0xb0c/0xdcc fs/attr.c:499 ovl_do_notify_change fs/overlayfs/overlayfs.h:142 [inline] ovl_workdir_create+0x4a8/0x634 fs/overlayfs/super.c:833 ovl_make_workdir fs/overlayfs/super.c:1389 [inline] ovl_get_workdir+0x2fc/0x1068 fs/overlayfs/super.c:1539 ovl_fill_super+0x139c/0x2294 fs/overlayfs/super.c:2095 mount_nodev+0x68/0x104 fs/super.c:1489 ovl_mount+0x3c/0x50 fs/overlayfs/super.c:2186 legacy_get_tree+0xd4/0x16c fs/fs_context.c:632 vfs_get_tree+0x90/0x274 fs/super.c:1573 do_new_mount+0x228/0x810 fs/namespace.c:3058 path_mount+0x5b4/0xe78 fs/namespace.c:3388 do_mount fs/namespace.c:3401 [inline] __do_sys_mount fs/namespace.c:3609 [inline] __se_sys_mount fs/namespace.c:3586 [inline] __arm64_sys_mount+0x49c/0x584 fs/namespace.c:3586 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x138 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: failed to set xattr on upper overlayfs: ...falling back to index=off,metacopy=off. overlayfs: upper fs missing required features.