gfs2: fsid=syz:syz.0: found 1 quota changes ====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.81/4481 is trying to acquire lock: ffff0000e52ecae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xbc/0x694 fs/gfs2/quota.c:678 but task is already holding lock: ffff0000dd9b5748 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x210/0x17a0 fs/gfs2/bmap.c:681 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 __gfs2_iomap_get+0x138/0x1058 fs/gfs2/bmap.c:858 gfs2_iomap_get fs/gfs2/bmap.c:1398 [inline] gfs2_block_map+0x2e0/0xd14 fs/gfs2/bmap.c:1213 bh_get+0x204/0x5a8 fs/gfs2/quota.c:385 qdsb_get+0x1e4/0x3b0 fs/gfs2/quota.c:518 gfs2_quota_hold+0x16c/0x558 fs/gfs2/quota.c:604 gfs2_quota_lock+0xbc/0x414 fs/gfs2/quota.c:1076 gfs2_quota_lock_check fs/gfs2/quota.h:50 [inline] alloc_dinode+0x180/0x478 fs/gfs2/inode.c:402 gfs2_create_inode+0xbe0/0x14c4 fs/gfs2/inode.c:720 gfs2_mkdir+0xb0/0xd4 fs/gfs2/inode.c:1237 vfs_mkdir+0x334/0x4e4 fs/namei.c:4065 do_mkdirat+0x20c/0x610 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4103 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 do_qc+0xbc/0x694 fs/gfs2/quota.c:678 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x172c/0x24c0 fs/gfs2/rgrp.c:2504 __gfs2_iomap_alloc+0x3b8/0x17a0 fs/gfs2/bmap.c:707 gfs2_iomap_begin_write fs/gfs2/bmap.c:1049 [inline] gfs2_iomap_begin+0xad4/0x12fc fs/gfs2/bmap.c:1114 iomap_iter+0x5f0/0xffc fs/iomap/iter.c:74 iomap_file_buffered_write+0x1c0/0x764 fs/iomap/buffered-io.c:814 gfs2_file_buffered_write+0x3c8/0x874 fs/gfs2/file.c:1057 gfs2_file_write_iter+0x3b8/0xc80 fs/gfs2/file.c:1165 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 6 locks held by syz.2.81/4481: #0: ffff0000d51ef4f0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x128/0x170 fs/file.c:1084 #1: ffff0000e8fd0460 (sb_writers#24){.+.+}-{0:0}, at: vfs_write+0x228/0xb44 fs/read_write.c:590 #2: ffff0000dd9b52b0 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff0000dd9b52b0 (&sb->s_type->i_mutex_key#27){+.+.}-{3:3}, at: gfs2_file_write_iter+0x2a8/0xc80 fs/gfs2/file.c:1122 #3: ffff0000e8fd0650 (sb_internal#4){.+.+}-{0:0}, at: gfs2_trans_begin+0x128/0x1cc fs/gfs2/trans.c:118 #4: ffff0000e52ed0a8 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x5a4/0x9d0 fs/gfs2/trans.c:87 #5: ffff0000dd9b5748 (&ip->i_rw_mutex){++++}-{3:3}, at: __gfs2_iomap_alloc+0x210/0x17a0 fs/gfs2/bmap.c:681 stack backtrace: CPU: 0 PID: 4481 Comm: syz.2.81 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 do_qc+0xbc/0x694 fs/gfs2/quota.c:678 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 gfs2_alloc_blocks+0x172c/0x24c0 fs/gfs2/rgrp.c:2504 __gfs2_iomap_alloc+0x3b8/0x17a0 fs/gfs2/bmap.c:707 gfs2_iomap_begin_write fs/gfs2/bmap.c:1049 [inline] gfs2_iomap_begin+0xad4/0x12fc fs/gfs2/bmap.c:1114 iomap_iter+0x5f0/0xffc fs/iomap/iter.c:74 iomap_file_buffered_write+0x1c0/0x764 fs/iomap/buffered-io.c:814 gfs2_file_buffered_write+0x3c8/0x874 fs/gfs2/file.c:1057 gfs2_file_write_iter+0x3b8/0xc80 fs/gfs2/file.c:1165 call_write_iter include/linux/fs.h:2172 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584