====================================================== WARNING: possible circular locking dependency detected 6.16.0-syzkaller-10499-g89748acdf226 #0 Not tainted ------------------------------------------------------ syz.0.0/5338 is trying to acquire lock: ffff888032ff20b0 (&tree->tree_lock/1){+.+.}-{4:4}, at: hfsplus_find_init+0x15a/0x1d0 fs/hfsplus/bfind.c:28 but task is already holding lock: ffff888052ef3048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_get_block+0x39e/0x1530 fs/hfsplus/extents.c:260 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x187/0x1340 kernel/locking/mutex.c:760 hfsplus_file_extend+0x1fc/0x1990 fs/hfsplus/extents.c:455 hfsplus_bmap_reserve+0x122/0x500 fs/hfsplus/btree.c:358 __hfsplus_ext_write_extent+0x28d/0x5b0 fs/hfsplus/extents.c:104 __hfsplus_ext_cache_extent+0x89/0xe30 fs/hfsplus/extents.c:186 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline] hfsplus_file_extend+0x444/0x1990 fs/hfsplus/extents.c:459 hfsplus_get_block+0x411/0x1530 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2145 block_write_begin fs/buffer.c:2256 [inline] cont_write_begin+0x789/0xb50 fs/buffer.c:2594 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:48 generic_perform_write+0x2c5/0x900 mm/filemap.c:4175 generic_file_write_iter+0x117/0x550 mm/filemap.c:4318 aio_write+0x532/0x7a0 fs/aio.c:1634 __io_submit_one fs/aio.c:-1 [inline] io_submit_one+0x78b/0x1310 fs/aio.c:2053 __do_sys_io_submit fs/aio.c:2112 [inline] __se_sys_io_submit+0x185/0x2f0 fs/aio.c:2082 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&tree->tree_lock/1){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x187/0x1340 kernel/locking/mutex.c:760 hfsplus_find_init+0x15a/0x1d0 fs/hfsplus/bfind.c:28 hfsplus_ext_read_extent fs/hfsplus/extents.c:216 [inline] hfsplus_get_block+0x8dd/0x1530 fs/hfsplus/extents.c:268 block_read_full_folio+0x29c/0x830 fs/buffer.c:2420 read_pages+0x35d/0x580 mm/readahead.c:170 page_cache_ra_unbounded+0x6b0/0x7b0 mm/readahead.c:297 do_sync_mmap_readahead+0x25e/0x7a0 mm/filemap.c:-1 filemap_fault+0x62c/0x1200 mm/filemap.c:3445 __do_fault+0x138/0x390 mm/memory.c:5152 do_shared_fault mm/memory.c:5637 [inline] do_fault mm/memory.c:5711 [inline] do_pte_missing mm/memory.c:4234 [inline] handle_pte_fault mm/memory.c:6052 [inline] __handle_mm_fault+0x1847/0x5440 mm/memory.c:6195 handle_mm_fault+0x40a/0x8e0 mm/memory.c:6364 do_user_addr_fault+0xa81/0x1390 arch/x86/mm/fault.c:1336 handle_page_fault arch/x86/mm/fault.c:1476 [inline] exc_page_fault+0x76/0xf0 arch/x86/mm/fault.c:1532 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock/1); *** DEADLOCK *** 2 locks held by syz.0.0/5338: #0: ffff888052ef33d8 (mapping.invalidate_lock#3){.+.+}-{4:4}, at: filemap_invalidate_lock_shared include/linux/fs.h:934 [inline] #0: ffff888052ef33d8 (mapping.invalidate_lock#3){.+.+}-{4:4}, at: page_cache_ra_unbounded+0x129/0x7b0 mm/readahead.c:228 #1: ffff888052ef3048 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_get_block+0x39e/0x1530 fs/hfsplus/extents.c:260 stack backtrace: CPU: 0 UID: 0 PID: 5338 Comm: syz.0.0 Not tainted 6.16.0-syzkaller-10499-g89748acdf226 #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2043 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3908 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5237 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5868 __mutex_lock_common kernel/locking/mutex.c:598 [inline] __mutex_lock+0x187/0x1340 kernel/locking/mutex.c:760 hfsplus_find_init+0x15a/0x1d0 fs/hfsplus/bfind.c:28 hfsplus_ext_read_extent fs/hfsplus/extents.c:216 [inline] hfsplus_get_block+0x8dd/0x1530 fs/hfsplus/extents.c:268 block_read_full_folio+0x29c/0x830 fs/buffer.c:2420 read_pages+0x35d/0x580 mm/readahead.c:170 page_cache_ra_unbounded+0x6b0/0x7b0 mm/readahead.c:297 do_sync_mmap_readahead+0x25e/0x7a0 mm/filemap.c:-1 filemap_fault+0x62c/0x1200 mm/filemap.c:3445 __do_fault+0x138/0x390 mm/memory.c:5152 do_shared_fault mm/memory.c:5637 [inline] do_fault mm/memory.c:5711 [inline] do_pte_missing mm/memory.c:4234 [inline] handle_pte_fault mm/memory.c:6052 [inline] __handle_mm_fault+0x1847/0x5440 mm/memory.c:6195 handle_mm_fault+0x40a/0x8e0 mm/memory.c:6364 do_user_addr_fault+0xa81/0x1390 arch/x86/mm/fault.c:1336 handle_page_fault arch/x86/mm/fault.c:1476 [inline] exc_page_fault+0x76/0xf0 arch/x86/mm/fault.c:1532 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 RIP: 0033:0x7fc78f158048 Code: 66 89 74 17 02 88 0f c3 c5 fa 6f 06 c5 fa 6f 4c 16 f0 c5 fa 7f 07 c5 fa 7f 4c 17 f0 c3 0f 1f 44 00 00 48 8b 4c 16 f8 48 8b 36 <48> 89 37 48 89 4c 17 f8 c3 62 e1 fe 28 6f 54 16 ff 62 e1 fe 28 6f RSP: 002b:00007ffc07cdb938 EFLAGS: 00010202 RAX: 0000200000000040 RBX: 0000000000000004 RCX: 00786d74702f7665 RDX: 000000000000000a RSI: 6d74702f7665642f RDI: 0000200000000040 RBP: 00007fc78f3b7ba0 R08: 00007fc78efff02c R09: 0000000000000001 R10: 0000000000000001 R11: 0000000000000009 R12: 00007fc78f3b5fac R13: 00007fc78f3b5fa0 R14: fffffffffffffffe R15: 00007ffc07cdba50