====================================================== WARNING: possible circular locking dependency detected 5.15.156-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/5201 is trying to acquire lock: ffff8880662720b0 (&tree->tree_lock#2/2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 but task is already holding lock: ffff8880662760b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&tree->tree_lock#2){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_file_truncate+0x864/0xb80 fs/hfsplus/extents.c:595 hfsplus_setattr+0x1b9/0x280 fs/hfsplus/inode.c:267 notify_change+0xc6d/0xf50 fs/attr.c:505 do_truncate+0x21c/0x300 fs/open.c:65 vfs_truncate+0x2dd/0x3a0 fs/open.c:111 do_sys_truncate+0xda/0x190 fs/open.c:134 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 do_read_cache_page+0x752/0x1040 read_mapping_page include/linux/pagemap.h:515 [inline] __hfs_bnode_create+0x4f2/0xbb0 fs/hfsplus/bnode.c:447 hfsplus_bnode_find+0x22e/0xe80 fs/hfsplus/bnode.c:497 hfsplus_brec_find+0x17f/0x570 fs/hfsplus/bfind.c:183 __hfsplus_getxattr+0x360/0xb10 fs/hfsplus/xattr.c:522 hfsplus_getxattr+0x98/0xd0 fs/hfsplus/xattr.c:590 vfs_getxattr_alloc+0x449/0x590 fs/xattr.c:374 ima_read_xattr+0x35/0x60 security/integrity/ima/ima_appraise.c:221 process_measurement+0x117d/0x21c0 security/integrity/ima/ima_main.c:333 ima_file_check+0xf3/0x180 security/integrity/ima/ima_main.c:533 do_open fs/namei.c:3610 [inline] path_openat+0x2748/0x2f20 fs/namei.c:3742 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x500 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1280 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&tree->tree_lock#2/2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_find_init+0x146/0x1c0 hfsplus_delete_all_attrs+0x107/0x3c0 fs/hfsplus/attributes.c:366 hfsplus_delete_cat+0xb83/0xfb0 fs/hfsplus/catalog.c:425 hfsplus_unlink+0x35f/0x7f0 fs/hfsplus/dir.c:385 vfs_unlink+0x359/0x5f0 fs/namei.c:4280 do_unlinkat+0x4a3/0x950 fs/namei.c:4348 __do_sys_unlink fs/namei.c:4396 [inline] __se_sys_unlink fs/namei.c:4394 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4394 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &tree->tree_lock#2/2 --> &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock#2); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); lock(&tree->tree_lock#2/2); *** DEADLOCK *** 5 locks held by syz-executor.4/5201: #0: ffff88806720e460 (sb_writers#26){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff88807776e840 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #1: ffff88807776e840 (&type->i_mutex_dir_key#19/1){+.+.}-{3:3}, at: do_unlinkat+0x266/0x950 fs/namei.c:4331 #2: ffff888078566840 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #2: ffff888078566840 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: vfs_unlink+0xe0/0x5f0 fs/namei.c:4269 #3: ffff8880620a6998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x15d/0x7f0 fs/hfsplus/dir.c:370 #4: ffff8880662760b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0 stack backtrace: CPU: 0 PID: 5201 Comm: syz-executor.4 Not tainted 5.15.156-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_find_init+0x146/0x1c0 hfsplus_delete_all_attrs+0x107/0x3c0 fs/hfsplus/attributes.c:366 hfsplus_delete_cat+0xb83/0xfb0 fs/hfsplus/catalog.c:425 hfsplus_unlink+0x35f/0x7f0 fs/hfsplus/dir.c:385 vfs_unlink+0x359/0x5f0 fs/namei.c:4280 do_unlinkat+0x4a3/0x950 fs/namei.c:4348 __do_sys_unlink fs/namei.c:4396 [inline] __se_sys_unlink fs/namei.c:4394 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4394 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fab7a746657 Code: 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffdbb7eec88 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fab7a746657 RDX: 00007ffdbb7eecb0 RSI: 00007ffdbb7eed40 RDI: 00007ffdbb7eed40 RBP: 00007ffdbb7eed40 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffdbb7efe30 R13: 00007fab7a7923b9 R14: 0000000000046e86 R15: 000000000000001e