F2FS-fs (loop2): invalid crc value F2FS-fs (loop2): Found nat_bits in checkpoint F2FS-fs (loop2): Try to recover 1th superblock, ret: 0 F2FS-fs (loop2): Mounted with checkpoint version = 753bd00b ====================================================== WARNING: possible circular locking dependency detected 6.2.0-rc3-next-20230109-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/2294 is trying to acquire lock: ffff88801dddc098 (&mm->mmap_lock){++++}-{3:3}, at: __might_fault+0xa9/0x180 mm/memory.c:5626 but task is already holding lock: ffff88807aa54088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2213 [inline] ffff88807aa54088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2350 [inline] ffff88807aa54088 (&sbi->sb_lock){++++}-{3:3}, at: __f2fs_ioctl+0x3a78/0xa910 fs/f2fs/file.c:4169 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (&sbi->sb_lock){++++}-{3:3}: down_write+0x94/0x220 kernel/locking/rwsem.c:1562 f2fs_down_write fs/f2fs/f2fs.h:2213 [inline] f2fs_handle_error+0x8e/0x200 fs/f2fs/super.c:3926 f2fs_check_nid_range.part.0+0x4d/0x60 fs/f2fs/node.c:39 f2fs_check_nid_range fs/f2fs/node.c:2278 [inline] add_free_nid.isra.0+0x781/0x940 fs/f2fs/node.c:2285 scan_nat_page fs/f2fs/node.c:2387 [inline] __f2fs_build_free_nids+0x5b5/0xe00 fs/f2fs/node.c:2493 f2fs_build_free_nids fs/f2fs/node.c:2531 [inline] f2fs_build_node_manager+0x2007/0x2fb0 fs/f2fs/node.c:3316 f2fs_fill_super+0x3ade/0x7680 fs/f2fs/super.c:4334 mount_bdev+0x351/0x410 fs/super.c:1359 legacy_get_tree+0x109/0x220 fs/fs_context.c:610 vfs_get_tree+0x8d/0x2f0 fs/super.c:1489 do_new_mount fs/namespace.c:3145 [inline] path_mount+0x132a/0x1e20 fs/namespace.c:3475 do_mount fs/namespace.c:3488 [inline] __do_sys_mount fs/namespace.c:3697 [inline] __se_sys_mount fs/namespace.c:3674 [inline] __x64_sys_mount+0x283/0x300 fs/namespace.c:3674 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #4 (&nm_i->nat_tree_lock){++++}-{3:3}: down_read+0x9c/0x450 kernel/locking/rwsem.c:1509 f2fs_down_read fs/f2fs/f2fs.h:2188 [inline] f2fs_get_node_info+0x1ac/0x1070 fs/f2fs/node.c:564 f2fs_new_node_page+0x249/0xac0 fs/f2fs/node.c:1295 f2fs_get_dnode_of_data+0x530/0x2480 fs/f2fs/node.c:810 f2fs_reserve_block+0x4d/0x570 fs/f2fs/data.c:1199 f2fs_get_new_data_page+0xfb/0x800 fs/f2fs/data.c:1387 fill_zero+0xba/0x150 fs/f2fs/file.c:1070 punch_hole fs/f2fs/file.c:1144 [inline] f2fs_fallocate+0x1d6a/0x37a0 fs/f2fs/file.c:1835 vfs_fallocate+0x48b/0xe40 fs/open.c:323 ioctl_preallocate+0x18e/0x200 fs/ioctl.c:290 file_ioctl fs/ioctl.c:333 [inline] do_vfs_ioctl+0x12d0/0x15b0 fs/ioctl.c:849 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #3 (&sbi->cp_rwsem){++++}-{3:3}: down_read+0x9c/0x450 kernel/locking/rwsem.c:1509 f2fs_down_read fs/f2fs/f2fs.h:2188 [inline] f2fs_lock_op fs/f2fs/f2fs.h:2231 [inline] punch_hole fs/f2fs/file.c:1163 [inline] f2fs_fallocate+0x65c/0x37a0 fs/f2fs/file.c:1835 vfs_fallocate+0x48b/0xe40 fs/open.c:323 ioctl_preallocate+0x18e/0x200 fs/ioctl.c:290 file_ioctl fs/ioctl.c:333 [inline] do_vfs_ioctl+0x12d0/0x15b0 fs/ioctl.c:849 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (mapping.invalidate_lock#4){++++}-{3:3}: down_read+0x9c/0x450 kernel/locking/rwsem.c:1509 filemap_invalidate_lock_shared include/linux/fs.h:813 [inline] f2fs_vm_page_mkwrite+0x630/0x1cf0 fs/f2fs/file.c:104 do_page_mkwrite+0x19b/0x680 mm/memory.c:2922 do_shared_fault mm/memory.c:4559 [inline] do_fault mm/memory.c:4627 [inline] handle_pte_fault mm/memory.c:4911 [inline] __handle_mm_fault+0x23ee/0x3c90 mm/memory.c:5053 handle_mm_fault+0x1b6/0x850 mm/memory.c:5199 do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 copy_user_enhanced_fast_string+0xe/0x40 arch/x86/lib/copy_user_64.S:165 copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline] raw_copy_to_user arch/x86/include/asm/uaccess_64.h:58 [inline] copyout lib/iov_iter.c:170 [inline] copyout+0xf6/0x120 lib/iov_iter.c:164 _copy_to_iter+0x21c/0x11c0 lib/iov_iter.c:529 copy_page_to_iter lib/iov_iter.c:727 [inline] copy_page_to_iter+0x126/0xa70 lib/iov_iter.c:712 copy_folio_to_iter include/linux/uio.h:172 [inline] filemap_read+0x639/0xc00 mm/filemap.c:2745 f2fs_file_read_iter+0x364/0x1110 fs/f2fs/file.c:4374 call_read_iter include/linux/fs.h:2185 [inline] new_sync_read fs/read_write.c:389 [inline] vfs_read+0x681/0x930 fs/read_write.c:470 ksys_read+0x12b/0x250 fs/read_write.c:613 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (sb_pagefaults#2){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1816 [inline] sb_start_pagefault include/linux/fs.h:1920 [inline] f2fs_vm_page_mkwrite+0x48a/0x1cf0 fs/f2fs/file.c:99 do_page_mkwrite+0x19b/0x680 mm/memory.c:2922 do_shared_fault mm/memory.c:4559 [inline] do_fault mm/memory.c:4627 [inline] handle_pte_fault mm/memory.c:4911 [inline] __handle_mm_fault+0x23ee/0x3c90 mm/memory.c:5053 handle_mm_fault+0x1b6/0x850 mm/memory.c:5199 do_user_addr_fault+0x475/0x1210 arch/x86/mm/fault.c:1428 handle_page_fault arch/x86/mm/fault.c:1519 [inline] exc_page_fault+0x98/0x170 arch/x86/mm/fault.c:1575 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 copy_user_enhanced_fast_string+0xe/0x40 arch/x86/lib/copy_user_64.S:165 copy_user_generic arch/x86/include/asm/uaccess_64.h:37 [inline] raw_copy_to_user arch/x86/include/asm/uaccess_64.h:58 [inline] copyout lib/iov_iter.c:170 [inline] copyout+0xf6/0x120 lib/iov_iter.c:164 _copy_to_iter+0x21c/0x11c0 lib/iov_iter.c:529 copy_page_to_iter lib/iov_iter.c:727 [inline] copy_page_to_iter+0x126/0xa70 lib/iov_iter.c:712 copy_folio_to_iter include/linux/uio.h:172 [inline] filemap_read+0x639/0xc00 mm/filemap.c:2745 f2fs_file_read_iter+0x364/0x1110 fs/f2fs/file.c:4374 call_read_iter include/linux/fs.h:2185 [inline] new_sync_read fs/read_write.c:389 [inline] vfs_read+0x681/0x930 fs/read_write.c:470 ksys_read+0x12b/0x250 fs/read_write.c:613 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&mm->mmap_lock){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x29db/0x5660 kernel/locking/lockdep.c:5056 lock_acquire.part.0+0x11a/0x350 kernel/locking/lockdep.c:5669 __might_fault mm/memory.c:5627 [inline] __might_fault+0x10c/0x180 mm/memory.c:5620 _copy_to_user+0x29/0x150 lib/usercopy.c:29 copy_to_user include/linux/uaccess.h:169 [inline] f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2365 [inline] __f2fs_ioctl+0x3ba8/0xa910 fs/f2fs/file.c:4169 f2fs_ioctl+0x18e/0x220 fs/f2fs/file.c:4242 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &mm->mmap_lock --> &nm_i->nat_tree_lock --> &sbi->sb_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->sb_lock); lock(&nm_i->nat_tree_lock); lock(&sbi->sb_lock); lock(&mm->mmap_lock); *** DEADLOCK *** 2 locks held by syz-executor.2/2294: #0: ffff88801f568460 (sb_writers#16){.+.+}-{0:0}, at: f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2346 [inline] #0: ffff88801f568460 (sb_writers#16){.+.+}-{0:0}, at: __f2fs_ioctl+0x30de/0xa910 fs/f2fs/file.c:4169 #1: ffff88807aa54088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_down_write fs/f2fs/f2fs.h:2213 [inline] #1: ffff88807aa54088 (&sbi->sb_lock){++++}-{3:3}, at: f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2350 [inline] #1: ffff88807aa54088 (&sbi->sb_lock){++++}-{3:3}, at: __f2fs_ioctl+0x3a78/0xa910 fs/f2fs/file.c:4169 stack backtrace: CPU: 0 PID: 2294 Comm: syz-executor.2 Not tainted 6.2.0-rc3-next-20230109-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x29db/0x5660 kernel/locking/lockdep.c:5056 lock_acquire.part.0+0x11a/0x350 kernel/locking/lockdep.c:5669 __might_fault mm/memory.c:5627 [inline] __might_fault+0x10c/0x180 mm/memory.c:5620 _copy_to_user+0x29/0x150 lib/usercopy.c:29 copy_to_user include/linux/uaccess.h:169 [inline] f2fs_ioc_get_encryption_pwsalt fs/f2fs/file.c:2365 [inline] __f2fs_ioctl+0x3ba8/0xa910 fs/f2fs/file.c:4169 f2fs_ioctl+0x18e/0x220 fs/f2fs/file.c:4242 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f86fc88c0c9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f86fd5a8168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f86fc9abf80 RCX: 00007f86fc88c0c9 RDX: 0000000020000040 RSI: 0000000040106614 RDI: 0000000000000004 RBP: 00007f86fc8e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcf5b9975f R14: 00007f86fd5a8300 R15: 0000000000022000