====================================================== WARNING: possible circular locking dependency detected 5.15.170-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.1634/10093 is trying to acquire lock: ffff0000e6a4e628 ( &ei->i_data_sem /1 ){+.+.}-{3:3} , at: ext4_double_down_write_data_sem+0x3c/0x4c but task is already holding lock: ffff0000e6a4d238 (&ei->i_data_sem /2 ){++++}-{3:3} , at: ext4_double_down_write_data_sem+0x30/0x4c which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ei->i_data_sem/2){++++}-{3:3}: down_write+0xbc/0x12c kernel/locking/rwsem.c:1551 ext4_map_blocks+0x830/0x1a44 fs/ext4/inode.c:665 ext4_getblk+0x160/0x688 fs/ext4/inode.c:869 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:922 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6567 write_blk fs/quota/quota_tree.c:64 [inline] find_free_dqentry fs/quota/quota_tree.c:307 [inline] do_insert_tree+0xad0/0x14cc fs/quota/quota_tree.c:364 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:472 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6193 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x2c8/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_setattr+0x228/0x1440 fs/ext4/inode.c:5399 notify_change+0xa34/0xcf8 fs/attr.c:505 chown_common+0x4ac/0x74c fs/open.c:680 do_fchownat+0x15c/0x234 fs/open.c:711 __do_sys_fchownat fs/open.c:726 [inline] __se_sys_fchownat fs/open.c:723 [inline] __arm64_sys_fchownat+0xb8/0xd4 fs/open.c:723 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x1fc/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1498 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5e4 fs/quota/dquot.c:463 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6193 dqget+0x664/0xd0c fs/quota/dquot.c:986 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1515 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1577 ext4_create+0xb4/0x480 fs/ext4/namei.c:2876 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0xf18/0x26cc fs/namei.c:3739 do_filp_open+0x1a8/0x3b4 fs/namei.c:3769 do_sys_openat2+0x128/0x3e0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_openat fs/open.c:1285 [inline] __se_sys_openat fs/open.c:1280 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1280 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:507 ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6173 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6233 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412 __dquot_alloc_space+0xb54/0xf7c fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xe78/0x4278 fs/ext4/mballoc.c:5739 ext4_new_meta_blocks+0x1ac/0x430 fs/ext4/balloc.c:738 ext4_ext_grow_indepth fs/ext4/extents.c:1325 [inline] ext4_ext_create_new_leaf fs/ext4/extents.c:1431 [inline] ext4_ext_insert_extent+0xb30/0x48ec fs/ext4/extents.c:2102 ext4_split_extent_at+0x6a4/0xef0 fs/ext4/extents.c:3234 ext4_force_split_extent_at fs/ext4/extents.c:319 [inline] ext4_swap_extents+0xfac/0x1af4 fs/ext4/extents.c:5783 move_extent_per_page+0x13e8/0x21cc fs/ext4/move_extent.c:359 ext4_move_extents+0x778/0xb4c fs/ext4/move_extent.c:673 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x32f8/0x61bc fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl fs/ioctl.c:860 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:860 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ei->i_data_sem/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667 ext4_double_down_write_data_sem+0x3c/0x4c ext4_move_extents+0x2b4/0xb4c fs/ext4/move_extent.c:609 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x32f8/0x61bc fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl fs/ioctl.c:860 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:860 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&ei->i_data_sem/1); *** DEADLOCK *** 4 locks held by syz.4.1634/10093: #0: ffff0000d7e04460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:421 #1: ffff0000e6a4d3b0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff0000e6a4d3b0 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xd4/0x120 fs/inode.c:1122 #2: ffff0000e6a4e7a0 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #2: ffff0000e6a4e7a0 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: lock_two_nondirectories+0xc4/0x120 fs/inode.c:1124 #3: ffff0000e6a4d238 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x30/0x4c stack backtrace: CPU: 1 PID: 10093 Comm: syz.4.1634 Not tainted 5.15.170-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 down_write_nested+0xc0/0x130 kernel/locking/rwsem.c:1667 ext4_double_down_write_data_sem+0x3c/0x4c ext4_move_extents+0x2b4/0xb4c fs/ext4/move_extent.c:609 __ext4_ioctl fs/ext4/ioctl.c:990 [inline] ext4_ioctl+0x32f8/0x61bc fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl fs/ioctl.c:860 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:860 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584