====================================================== WARNING: possible circular locking dependency detected 6.1.87-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/8283 is trying to acquire lock: ffff888058bdd5a8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x57/0x510 fs/quota/dquot.c:507 but task is already holding lock: ffff888058b00288 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x963/0x1ca0 fs/ext4/inode.c:644 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ei->i_data_sem/2){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x37a/0x1ca0 fs/ext4/inode.c:574 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7147 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:130 do_insert_tree+0x299/0x1ae0 fs/quota/quota_tree.c:340 do_insert_tree+0x72a/0x1ae0 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x3b9/0x530 fs/quota/quota_tree.c:420 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:358 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6773 dqget+0x74e/0xe30 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1516 ext4_setattr+0x53f/0x1a00 fs/ext4/inode.c:5432 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 do_fchownat+0x169/0x240 fs/open.c:767 __do_sys_fchownat fs/open.c:782 [inline] __se_sys_fchownat fs/open.c:779 [inline] __x64_sys_fchownat+0xb1/0xc0 fs/open.c:779 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:332 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6773 dqget+0x74e/0xe30 fs/quota/dquot.c:986 dquot_set_dqblk+0x27/0xf20 fs/quota/dquot.c:2832 quota_setquota+0x6d3/0x840 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:960 [inline] __se_sys_quotactl+0x2b1/0x770 fs/quota/quota.c:916 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&dquot->dq_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1751 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1160/0x4820 fs/ext4/mballoc.c:5666 ext4_ext_map_blocks+0x1c3a/0x7b60 fs/ext4/extents.c:4316 ext4_map_blocks+0xa3c/0x1ca0 fs/ext4/inode.c:651 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_add_entry+0x98d/0x1010 fs/ext4/namei.c:2439 ext4_add_nondir+0x8d/0x290 fs/ext4/namei.c:2796 ext4_symlink+0x91b/0xb40 fs/ext4/namei.c:3436 vfs_symlink+0x247/0x3d0 fs/namei.c:4473 do_symlinkat+0x21e/0x390 fs/namei.c:4502 __do_sys_symlinkat fs/namei.c:4519 [inline] __se_sys_symlinkat fs/namei.c:4516 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4516 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&dquot->dq_lock); *** DEADLOCK *** 4 locks held by syz-executor.3/8283: #0: ffff8880784a0460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff888058b00400 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #1: ffff888058b00400 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: filename_create+0x25c/0x530 fs/namei.c:3878 #2: ffff888058b00288 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x963/0x1ca0 fs/ext4/inode.c:644 #3: ffffffff8d2716a8 (dquot_srcu){....}-{0:0}, at: rcu_lock_acquire include/linux/rcupdate.h:350 [inline] #3: ffffffff8d2716a8 (dquot_srcu){....}-{0:0}, at: srcu_read_lock include/linux/srcu.h:165 [inline] #3: ffffffff8d2716a8 (dquot_srcu){....}-{0:0}, at: __dquot_alloc_space+0x1d6/0x10e0 fs/quota/dquot.c:1715 stack backtrace: CPU: 0 PID: 8283 Comm: syz-executor.3 Not tainted 6.1.87-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6753 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1751 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1160/0x4820 fs/ext4/mballoc.c:5666 ext4_ext_map_blocks+0x1c3a/0x7b60 fs/ext4/extents.c:4316 ext4_map_blocks+0xa3c/0x1ca0 fs/ext4/inode.c:651 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:866 ext4_bread+0x2a/0x170 fs/ext4/inode.c:922 ext4_add_entry+0x98d/0x1010 fs/ext4/namei.c:2439 ext4_add_nondir+0x8d/0x290 fs/ext4/namei.c:2796 ext4_symlink+0x91b/0xb40 fs/ext4/namei.c:3436 vfs_symlink+0x247/0x3d0 fs/namei.c:4473 do_symlinkat+0x21e/0x390 fs/namei.c:4502 __do_sys_symlinkat fs/namei.c:4519 [inline] __se_sys_symlinkat fs/namei.c:4516 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4516 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f49c767dea9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f49c83590c8 EFLAGS: 00000246 ORIG_RAX: 000000000000010a RAX: ffffffffffffffda RBX: 00007f49c77ac120 RCX: 00007f49c767dea9 RDX: 00000000200000c0 RSI: 0000000000000007 RDI: 0000000020000040 RBP: 00007f49c76ca4a4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f49c77ac120 R15: 00007ffc99ac3f08