====================================================== WARNING: possible circular locking dependency detected 5.15.133-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/22702 is trying to acquire lock: ffff000120425c30 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x2b4/0x19ac fs/ext4/inode.c:568 but task is already holding lock: ffff0000c226c208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0xc0/0x398 kernel/locking/rwsem.c:1488 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5e4 fs/quota/dquot.c:459 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6180 dqget+0x664/0xcac fs/quota/dquot.c:972 dquot_set_dqblk+0x40/0xfec fs/quota/dquot.c:2823 quota_setquota+0x5f4/0x728 fs/quota/quota.c:309 do_quotactl+0x508/0x698 fs/quota/quota.c:801 __do_sys_quotactl fs/quota/quota.c:959 [inline] __se_sys_quotactl fs/quota/quota.c:915 [inline] __arm64_sys_quotactl+0x2d8/0x7a4 fs/quota/quota.c:915 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 dquot_commit+0x54/0x240 fs/quota/dquot.c:503 ext4_write_dquot+0x1b0/0x284 fs/ext4/super.c:6164 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6212 mark_dquot_dirty fs/quota/dquot.c:370 [inline] mark_all_dquot_dirty fs/quota/dquot.c:408 [inline] __dquot_alloc_space+0x47c/0xd34 fs/quota/dquot.c:1780 dquot_alloc_space_nodirty include/linux/quotaops.h:297 [inline] dquot_alloc_space include/linux/quotaops.h:310 [inline] dquot_alloc_block include/linux/quotaops.h:334 [inline] ext4_mb_new_blocks+0xf34/0x4318 fs/ext4/mballoc.c:5646 ext4_ext_map_blocks+0x1368/0x5ff4 fs/ext4/extents.c:4287 ext4_map_blocks+0x8c4/0x19ac fs/ext4/inode.c:645 _ext4_get_block+0x1c0/0x5c0 fs/ext4/inode.c:792 ext4_get_block+0x4c/0x60 fs/ext4/inode.c:809 ext4_block_write_begin+0x520/0x1130 fs/ext4/inode.c:1077 ext4_write_begin+0x5e4/0xe84 generic_perform_write+0x24c/0x520 mm/filemap.c:3776 ext4_buffered_write_iter+0x3fc/0x528 fs/ext4/file.c:268 ext4_file_write_iter+0x688/0x162c do_iter_readv_writev+0x420/0x5f8 do_iter_write+0x1b8/0x664 fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_pwritev+0x1ec/0x334 fs/read_write.c:1025 __do_sys_pwritev2 fs/read_write.c:1084 [inline] __se_sys_pwritev2 fs/read_write.c:1075 [inline] __arm64_sys_pwritev2+0xd4/0x108 fs/read_write.c:1075 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3787 [inline] __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622 down_read+0xc0/0x398 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x2b4/0x19ac fs/ext4/inode.c:568 ext4_getblk+0x160/0x688 fs/ext4/inode.c:846 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:899 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6546 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:468 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6180 dqget+0x664/0xcac fs/quota/dquot.c:972 dquot_transfer+0x24c/0x438 fs/quota/dquot.c:2168 ext4_setattr+0x72c/0x1440 fs/ext4/inode.c:5405 notify_change+0xa34/0xcf8 fs/attr.c:505 chown_common+0x4ac/0x74c fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xe0/0x158 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:765 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz-executor.2/22702: #0: ffff0000c226c460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:421 #1: ffff0001205a5da8 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #1: ffff0001205a5da8 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: chown_common+0x3f8/0x74c fs/open.c:674 #2: ffff0001205a5a80 (&ei->xattr_sem){++++}-{3:3}, at: ext4_setattr+0x720/0x1440 fs/ext4/inode.c:5404 #3: ffff0001205b9e68 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x5e4 fs/quota/dquot.c:456 #4: ffff0000c226c208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354 stack backtrace: CPU: 0 PID: 22702 Comm: syz-executor.2 Not tainted 5.15.133-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/04/2023 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3787 [inline] __lock_acquire+0x32cc/0x7620 kernel/locking/lockdep.c:5011 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5622 down_read+0xc0/0x398 kernel/locking/rwsem.c:1488 ext4_map_blocks+0x2b4/0x19ac fs/ext4/inode.c:568 ext4_getblk+0x160/0x688 fs/ext4/inode.c:846 ext4_bread+0x3c/0x1d4 fs/ext4/inode.c:899 ext4_quota_write+0x238/0x564 fs/ext4/super.c:6546 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x2dc/0x6a0 fs/quota/quota_tree.c:125 do_insert_tree+0x238/0x14cc fs/quota/quota_tree.c:335 do_insert_tree+0x4b8/0x14cc fs/quota/quota_tree.c:366 dq_insert_tree fs/quota/quota_tree.c:392 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:411 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2cc/0x5e4 fs/quota/dquot.c:468 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6180 dqget+0x664/0xcac fs/quota/dquot.c:972 dquot_transfer+0x24c/0x438 fs/quota/dquot.c:2168 ext4_setattr+0x72c/0x1440 fs/ext4/inode.c:5405 notify_change+0xa34/0xcf8 fs/attr.c:505 chown_common+0x4ac/0x74c fs/open.c:680 vfs_fchown fs/open.c:748 [inline] ksys_fchown+0xe0/0x158 fs/open.c:759 __do_sys_fchown fs/open.c:767 [inline] __se_sys_fchown fs/open.c:765 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:765 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:596 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:614 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584