nci: __nci_request: wait_for_completion_interruptible_timeout failed 0 ====================================================== WARNING: possible circular locking dependency detected 6.1.15-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor773/4324 is trying to acquire lock: ffff800016d8c588 (nci_mutex){+.+.}-{3:3}, at: virtual_nci_close+0x28/0x58 drivers/nfc/virtual_ncidev.c:44 but task is already holding lock: ffff0000d8131350 (&ndev->req_lock){+.+.}-{3:3}, at: nci_close_device+0xf0/0x5ac net/nfc/nci/core.c:560 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ndev->req_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 nci_request net/nfc/nci/core.c:148 [inline] nci_set_local_general_bytes net/nfc/nci/core.c:774 [inline] nci_start_poll+0x498/0x1204 net/nfc/nci/core.c:838 nfc_start_poll+0x164/0x2a4 net/nfc/core.c:225 nfc_genl_start_poll+0x1b8/0x308 net/nfc/netlink.c:828 genl_family_rcv_msg_doit net/netlink/genetlink.c:756 [inline] genl_family_rcv_msg net/netlink/genetlink.c:833 [inline] genl_rcv_msg+0x948/0xc2c net/netlink/genetlink.c:850 netlink_rcv_skb+0x20c/0x3b8 net/netlink/af_netlink.c:2550 genl_rcv+0x38/0x50 net/netlink/genetlink.c:861 netlink_unicast_kernel net/netlink/af_netlink.c:1328 [inline] netlink_unicast+0x660/0x8d4 net/netlink/af_netlink.c:1354 netlink_sendmsg+0x800/0xae0 net/netlink/af_netlink.c:1931 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg net/socket.c:734 [inline] ____sys_sendmsg+0x558/0x844 net/socket.c:2485 ___sys_sendmsg net/socket.c:2539 [inline] __sys_sendmsg+0x26c/0x33c net/socket.c:2568 __do_sys_sendmsg net/socket.c:2577 [inline] __se_sys_sendmsg net/socket.c:2575 [inline] __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2575 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #2 (&genl_data->genl_data_mutex){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 nfc_urelease_event_work+0xfc/0x2a8 net/nfc/netlink.c:1835 process_one_work+0x848/0x16b4 kernel/workqueue.c:2289 worker_thread+0x8e4/0xfec kernel/workqueue.c:2436 kthread+0x24c/0x2d4 kernel/kthread.c:376 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:860 -> #1 (nfc_devlist_mutex){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 nfc_register_device+0x4c/0x310 net/nfc/core.c:1116 nci_register_device+0x6ac/0x7c4 net/nfc/nci/core.c:1256 virtual_ncidev_open+0x6c/0xd8 drivers/nfc/virtual_ncidev.c:146 misc_open+0x2f0/0x368 drivers/char/misc.c:143 chrdev_open+0x3e8/0x4fc fs/char_dev.c:414 do_dentry_open+0x734/0xfa0 fs/open.c:882 vfs_open+0x7c/0x90 fs/open.c:1013 do_open fs/namei.c:3557 [inline] path_openat+0x1e10/0x2540 fs/namei.c:3714 do_filp_open+0x1bc/0x3cc fs/namei.c:3741 do_sys_openat2+0x128/0x3d8 fs/open.c:1310 do_sys_open fs/open.c:1326 [inline] __do_sys_openat fs/open.c:1342 [inline] __se_sys_openat fs/open.c:1337 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1337 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #0 (nci_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5055 lock_acquire+0x2f8/0x8dc kernel/locking/lockdep.c:5668 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 virtual_nci_close+0x28/0x58 drivers/nfc/virtual_ncidev.c:44 nci_close_device+0x2fc/0x5ac net/nfc/nci/core.c:592 nci_unregister_device+0x58/0x21c net/nfc/nci/core.c:1291 virtual_ncidev_close+0x70/0xb0 drivers/nfc/virtual_ncidev.c:166 __fput+0x30c/0x7bc fs/file_table.c:320 ____fput+0x20/0x30 fs/file_table.c:348 task_work_run+0x240/0x2f0 kernel/task_work.c:179 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0x538/0x1af8 kernel/exit.c:867 do_group_exit+0x194/0x22c kernel/exit.c:1012 get_signal+0x14a0/0x158c kernel/signal.c:2858 do_signal arch/arm64/kernel/signal.c:1076 [inline] do_notify_resume+0x3ac/0x3470 arch/arm64/kernel/signal.c:1129 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 other info that might help us debug this: Chain exists of: nci_mutex --> &genl_data->genl_data_mutex --> &ndev->req_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ndev->req_lock); lock(&genl_data->genl_data_mutex); lock(&ndev->req_lock); lock(nci_mutex); *** DEADLOCK *** 1 lock held by syz-executor773/4324: #0: ffff0000d8131350 (&ndev->req_lock){+.+.}-{3:3}, at: nci_close_device+0xf0/0x5ac net/nfc/nci/core.c:560 stack backtrace: CPU: 1 PID: 4324 Comm: syz-executor773 Not tainted 6.1.15-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2055 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5055 lock_acquire+0x2f8/0x8dc kernel/locking/lockdep.c:5668 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 virtual_nci_close+0x28/0x58 drivers/nfc/virtual_ncidev.c:44 nci_close_device+0x2fc/0x5ac net/nfc/nci/core.c:592 nci_unregister_device+0x58/0x21c net/nfc/nci/core.c:1291 virtual_ncidev_close+0x70/0xb0 drivers/nfc/virtual_ncidev.c:166 __fput+0x30c/0x7bc fs/file_table.c:320 ____fput+0x20/0x30 fs/file_table.c:348 task_work_run+0x240/0x2f0 kernel/task_work.c:179 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0x538/0x1af8 kernel/exit.c:867 do_group_exit+0x194/0x22c kernel/exit.c:1012 get_signal+0x14a0/0x158c kernel/signal.c:2858 do_signal arch/arm64/kernel/signal.c:1076 [inline] do_notify_resume+0x3ac/0x3470 arch/arm64/kernel/signal.c:1129 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x9c/0x168 arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581