====================================================== WARNING: possible circular locking dependency detected 6.1.116-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.1224/8268 is trying to acquire lock: ffff88805975d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff88805975d108 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0x127/0x29d0 fs/ocfs2/localalloc.c:635 but task is already holding lock: ffff88805964dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xf12/0x1f80 fs/ocfs2/file.c:1230 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 do_fchownat+0x169/0x240 fs/open.c:767 __do_sys_lchown fs/open.c:792 [inline] __se_sys_lchown fs/open.c:790 [inline] __x64_sys_lchown+0x81/0x90 fs/open.c:790 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x2ad/0xb60 fs/ocfs2/quota_global.c:811 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xf12/0x1f80 fs/ocfs2/file.c:1230 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 do_fchownat+0x169/0x240 fs/open.c:767 __do_sys_lchown fs/open.c:792 [inline] __se_sys_lchown fs/open.c:790 [inline] __x64_sys_lchown+0x81/0x90 fs/open.c:790 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #5 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6777 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_free_space+0x956/0xe70 fs/quota/dquot.c:1940 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline] dquot_free_space include/linux/quotaops.h:384 [inline] dquot_free_block include/linux/quotaops.h:395 [inline] ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline] ext4_free_blocks+0x1fb4/0x3020 fs/ext4/mballoc.c:6273 ext4_remove_blocks fs/ext4/extents.c:2525 [inline] ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline] ext4_ext_remove_space+0x22bb/0x4f30 fs/ext4/extents.c:2939 ext4_ext_truncate+0x201/0x360 fs/ext4/extents.c:4469 ext4_truncate+0xa1d/0x1290 fs/ext4/inode.c:4288 ext4_evict_inode+0xb68/0x1150 fs/ext4/inode.c:286 evict+0x529/0x930 fs/inode.c:701 __dentry_kill+0x436/0x650 fs/dcache.c:611 dentry_kill+0xbb/0x290 dput+0xfb/0x1d0 fs/dcache.c:918 do_renameat2+0xded/0x1440 fs/namei.c:5029 __do_sys_renameat fs/namei.c:5067 [inline] __se_sys_renameat fs/namei.c:5064 [inline] __x64_sys_renameat+0xb8/0xd0 fs/namei.c:5064 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #4 (&ei->i_data_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 ext4_truncate+0x999/0x1290 fs/ext4/inode.c:4283 ext4_setattr+0x10f5/0x1a00 fs/ext4/inode.c:5601 notify_change+0xce3/0xfc0 fs/attr.c:499 do_truncate+0x21c/0x300 fs/open.c:65 do_sys_ftruncate+0x2e2/0x380 fs/open.c:193 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 start_this_handle+0x1f71/0x21b0 fs/jbd2/transaction.c:463 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:520 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:559 ocfs2_start_trans+0x3c0/0x6f0 fs/ocfs2/journal.c:354 ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1fb/0x960 fs/ocfs2/super.c:1879 generic_shutdown_super+0x130/0x340 fs/super.c:501 kill_block_super+0x7a/0xe0 fs/super.c:1470 deactivate_locked_super+0xa0/0x110 fs/super.c:332 cleanup_mnt+0x490/0x520 fs/namespace.c:1186 task_work_run+0x246/0x300 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ocfs2_start_trans+0x3b5/0x6f0 fs/ocfs2/journal.c:352 ocfs2_shutdown_local_alloc+0x214/0xa90 fs/ocfs2/localalloc.c:416 ocfs2_dismount_volume+0x1fb/0x960 fs/ocfs2/super.c:1879 generic_shutdown_super+0x130/0x340 fs/super.c:501 kill_block_super+0x7a/0xe0 fs/super.c:1470 deactivate_locked_super+0xa0/0x110 fs/super.c:332 cleanup_mnt+0x490/0x520 fs/namespace.c:1186 task_work_run+0x246/0x300 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (sb_internal#4){.+.+}-{0:0}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1891 [inline] sb_start_intwrite include/linux/fs.h:2013 [inline] ocfs2_start_trans+0x2b0/0x6f0 fs/ocfs2/journal.c:350 ocfs2_mknod+0x1638/0x2e20 fs/ocfs2/namei.c:359 ocfs2_create+0x1c0/0x4e0 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3482 [inline] open_last_lookups fs/namei.c:3550 [inline] path_openat+0x12f1/0x2e60 fs/namei.c:3780 do_filp_open+0x230/0x480 fs/namei.c:3810 do_sys_openat2+0x13b/0x4f0 fs/open.c:1318 do_sys_open fs/open.c:1334 [inline] __do_sys_openat fs/open.c:1350 [inline] __se_sys_openat fs/open.c:1345 [inline] __x64_sys_openat+0x243/0x290 fs/open.c:1345 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_local_alloc_bits+0x127/0x29d0 fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x4e5/0x1d00 fs/ocfs2/file.c:585 ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1027 ocfs2_acquire_dquot+0x60a/0xb60 fs/ocfs2/quota_global.c:836 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xf12/0x1f80 fs/ocfs2/file.c:1230 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 do_fchownat+0x169/0x240 fs/open.c:767 __do_sys_lchown fs/open.c:792 [inline] __se_sys_lchown fs/open.c:790 [inline] __x64_sys_lchown+0x81/0x90 fs/open.c:790 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6); *** DEADLOCK *** 5 locks held by syz.5.1224/8268: #0: ffff88805c00c460 (sb_writers#28){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff888059649808 (&type->i_mutex_dir_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff888059649808 (&type->i_mutex_dir_key#22){+.+.}-{3:3}, at: chown_common+0x3e5/0x900 fs/open.c:726 #2: ffff8880596fa0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x2a0/0xb60 fs/ocfs2/quota_global.c:806 #3: ffff88805964df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #3: ffff88805964df48 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x202/0x2a0 fs/ocfs2/quota_global.c:313 #4: ffff88805964dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x221/0x2a0 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 PID: 8268 Comm: syz.5.1224 Not tainted 6.1.116-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] ocfs2_reserve_local_alloc_bits+0x127/0x29d0 fs/ocfs2/localalloc.c:635 ocfs2_reserve_clusters_with_limit+0x1b4/0xb50 fs/ocfs2/suballoc.c:1162 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x306/0x620 fs/ocfs2/suballoc.c:2669 ocfs2_extend_allocation+0x4e5/0x1d00 fs/ocfs2/file.c:585 ocfs2_extend_no_holes+0x1f2/0x490 fs/ocfs2/file.c:1027 ocfs2_acquire_dquot+0x60a/0xb60 fs/ocfs2/quota_global.c:836 dqget+0x762/0xe90 fs/quota/dquot.c:986 ocfs2_setattr+0xf12/0x1f80 fs/ocfs2/file.c:1230 notify_change+0xce3/0xfc0 fs/attr.c:499 chown_common+0x5aa/0x900 fs/open.c:736 do_fchownat+0x169/0x240 fs/open.c:767 __do_sys_lchown fs/open.c:792 [inline] __se_sys_lchown fs/open.c:790 [inline] __x64_sys_lchown+0x81/0x90 fs/open.c:790 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f0eeed7e719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f0eefad0038 EFLAGS: 00000246 ORIG_RAX: 000000000000005e RAX: ffffffffffffffda RBX: 00007f0eeef35f80 RCX: 00007f0eeed7e719 RDX: 0000000039323420 RSI: 00000000706d6174 RDI: 0000000020000200 RBP: 00007f0eeedf1616 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f0eeef35f80 R15: 00007fffe17a7a78