overlayfs: upper fs does not support RENAME_WHITEOUT. ====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-00136-g8faabc041a00 #0 Not tainted ------------------------------------------------------ syz.2.32/6195 is trying to acquire lock: ffff88807a805f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] ffff88807a805f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 but task is already holding lock: ffff88805cb8eab8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x633/0x1930 fs/ocfs2/xattr.c:3583 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_xattr_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_xattr_set_handle+0x539/0xa10 fs/ocfs2/xattr.c:3501 ocfs2_init_security_set+0xbd/0xd0 fs/ocfs2/xattr.c:7307 ocfs2_mknod+0x1ccf/0x2b30 fs/ocfs2/namei.c:419 ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:657 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x9f6/0x4e70 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x41c/0x9c0 fs/ocfs2/suballoc.c:982 ocfs2_mknod+0x143a/0x2b30 fs/ocfs2/namei.c:347 ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:657 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x9f6/0x4e70 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x41c/0x9c0 fs/ocfs2/suballoc.c:982 ocfs2_mknod+0x143a/0x2b30 fs/ocfs2/namei.c:347 ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:657 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (sb_internal#4){.+.+}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_mknod+0x150c/0x2b30 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x1ab/0x470 fs/ocfs2/namei.c:657 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x1b8/0xb60 fs/ocfs2/suballoc.c:1166 ocfs2_init_xattr_set_ctxt+0x420/0x8e0 fs/ocfs2/xattr.c:3286 ocfs2_xattr_set+0xf4e/0x1930 fs/ocfs2/xattr.c:3634 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234 vfs_setxattr+0x221/0x430 fs/xattr.c:321 ovl_do_setxattr fs/overlayfs/overlayfs.h:314 [inline] ovl_setxattr fs/overlayfs/overlayfs.h:326 [inline] ovl_make_workdir fs/overlayfs/super.c:696 [inline] ovl_get_workdir+0xd90/0x1920 fs/overlayfs/super.c:808 ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb7/0x140 fs/super.c:1299 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6 --> jbd2_handle --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(jbd2_handle); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6); *** DEADLOCK *** 4 locks held by syz.2.32/6195: #0: ffff88802e8aa0e0 (&type->s_umount_key#73/1){+.+.}-{4:4}, at: alloc_super+0x221/0x9d0 fs/super.c:344 #1: ffff88807acd0420 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515 #2: ffff88805cb8ed80 (&sb->s_type->i_mutex_key#29){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #2: ffff88805cb8ed80 (&sb->s_type->i_mutex_key#29){++++}-{4:4}, at: vfs_setxattr+0x1e1/0x430 fs/xattr.c:320 #3: ffff88805cb8eab8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x633/0x1930 fs/ocfs2/xattr.c:3583 stack backtrace: CPU: 0 UID: 0 PID: 6195 Comm: syz.2.32 Not tainted 6.13.0-rc3-syzkaller-00136-g8faabc041a00 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_reserve_local_alloc_bits+0x132/0x2840 fs/ocfs2/localalloc.c:636 ocfs2_reserve_clusters_with_limit+0x1b8/0xb60 fs/ocfs2/suballoc.c:1166 ocfs2_init_xattr_set_ctxt+0x420/0x8e0 fs/ocfs2/xattr.c:3286 ocfs2_xattr_set+0xf4e/0x1930 fs/ocfs2/xattr.c:3634 __vfs_setxattr+0x468/0x4a0 fs/xattr.c:200 __vfs_setxattr_noperm+0x12e/0x660 fs/xattr.c:234 vfs_setxattr+0x221/0x430 fs/xattr.c:321 ovl_do_setxattr fs/overlayfs/overlayfs.h:314 [inline] ovl_setxattr fs/overlayfs/overlayfs.h:326 [inline] ovl_make_workdir fs/overlayfs/super.c:696 [inline] ovl_get_workdir+0xd90/0x1920 fs/overlayfs/super.c:808 ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb7/0x140 fs/super.c:1299 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f4110385d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f41111df038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f4110575fa0 RCX: 00007f4110385d29 RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000 RBP: 00007f4110401aa8 R08: 0000000020000400 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f4110575fa0 R15: 00007ffde686bd98 overlayfs: upper fs missing required features. ocfs2: Unmounting device (7,2) on (node local)