====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc6-next-20241108-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.1887/17923 is trying to acquire lock: ffff88805d062640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:817 [inline] ffff88805d062640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}, at: ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2726 but task is already holding lock: ffff88804970dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2321 [inline] ffff88804970dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io+0x44a/0x1250 fs/ocfs2/aops.c:2427 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_create_local_dquot+0x1de/0x1d70 fs/ocfs2/quota_local.c:1231 ocfs2_acquire_dquot+0x833/0xb80 fs/ocfs2/quota_global.c:878 dqget+0x770/0xeb0 fs/quota/dquot.c:976 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1504 ocfs2_get_init_inode+0x158/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b40 fs/ocfs2/namei.c:308 ocfs2_create+0x1ab/0x480 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x1c03/0x3590 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1428 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&dquot->dq_lock){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x6e6/0xeb0 fs/quota/dquot.c:971 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1504 ocfs2_get_init_inode+0x158/0x1c0 fs/ocfs2/namei.c:202 ocfs2_mknod+0xcfa/0x2b40 fs/ocfs2/namei.c:308 ocfs2_create+0x1ab/0x480 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x1c03/0x3590 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __x64_sys_openat+0x247/0x2a0 fs/open.c:1428 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:817 [inline] ocfs2_remove_inode fs/ocfs2/inode.c:655 [inline] ocfs2_wipe_inode fs/ocfs2/inode.c:818 [inline] ocfs2_delete_inode fs/ocfs2/inode.c:1079 [inline] ocfs2_evict_inode+0x209f/0x4680 fs/ocfs2/inode.c:1216 evict+0x4e8/0x9b0 fs/inode.c:794 d_delete_notify include/linux/fsnotify.h:332 [inline] vfs_rmdir+0x3d7/0x510 fs/namei.c:4407 do_rmdir+0x3b5/0x580 fs/namei.c:4453 __do_sys_unlinkat fs/namei.c:4629 [inline] __se_sys_unlinkat fs/namei.c:4623 [inline] __x64_sys_unlinkat+0xde/0xf0 fs/namei.c:4623 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:817 [inline] ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2726 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2329 [inline] ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2427 dio_complete+0x251/0x6b0 fs/direct-io.c:281 __blockdev_direct_IO+0x3ebd/0x4890 fs/direct-io.c:1303 ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464 generic_file_direct_write+0x17a/0x390 mm/filemap.c:3978 __generic_file_write_iter+0x126/0x230 mm/filemap.c:4142 ocfs2_file_write_iter+0x19c8/0x21b0 fs/ocfs2/file.c:2469 do_iter_readv_writev+0x600/0x880 vfs_writev+0x376/0xba0 fs/read_write.c:1050 do_pwritev fs/read_write.c:1146 [inline] __do_sys_pwritev2 fs/read_write.c:1204 [inline] __se_sys_pwritev2+0x196/0x2b0 fs/read_write.c:1195 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type] --> &dquot->dq_lock --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&dquot->dq_lock); lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]); *** DEADLOCK *** 3 locks held by syz.2.1887/17923: #0: ffff888063444420 (sb_writers#29){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2963 [inline] #0: ffff888063444420 (sb_writers#29){.+.+}-{0:0}, at: vfs_writev+0x2d1/0xba0 fs/read_write.c:1048 #1: ffff88804970df40 (&sb->s_type->i_mutex_key#36){++++}-{4:4}, at: inode_lock include/linux/fs.h:817 [inline] #1: ffff88804970df40 (&sb->s_type->i_mutex_key#36){++++}-{4:4}, at: ocfs2_file_write_iter+0x442/0x21b0 fs/ocfs2/file.c:2399 #2: ffff88804970dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io_write fs/ocfs2/aops.c:2321 [inline] #2: ffff88804970dbe0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_dio_end_io+0x44a/0x1250 fs/ocfs2/aops.c:2427 stack backtrace: CPU: 0 UID: 0 PID: 17923 Comm: syz.2.1887 Not tainted 6.12.0-rc6-next-20241108-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:817 [inline] ocfs2_del_inode_from_orphan+0x159/0x800 fs/ocfs2/namei.c:2726 ocfs2_dio_end_io_write fs/ocfs2/aops.c:2329 [inline] ocfs2_dio_end_io+0x55b/0x1250 fs/ocfs2/aops.c:2427 dio_complete+0x251/0x6b0 fs/direct-io.c:281 __blockdev_direct_IO+0x3ebd/0x4890 fs/direct-io.c:1303 ocfs2_direct_IO+0x255/0x2c0 fs/ocfs2/aops.c:2464 generic_file_direct_write+0x17a/0x390 mm/filemap.c:3978 __generic_file_write_iter+0x126/0x230 mm/filemap.c:4142 ocfs2_file_write_iter+0x19c8/0x21b0 fs/ocfs2/file.c:2469 do_iter_readv_writev+0x600/0x880 vfs_writev+0x376/0xba0 fs/read_write.c:1050 do_pwritev fs/read_write.c:1146 [inline] __do_sys_pwritev2 fs/read_write.c:1204 [inline] __se_sys_pwritev2+0x196/0x2b0 fs/read_write.c:1195 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe103d7e719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe104baa038 EFLAGS: 00000246 ORIG_RAX: 0000000000000148 RAX: ffffffffffffffda RBX: 00007fe103f35f80 RCX: 00007fe103d7e719 RDX: 0000000000000001 RSI: 0000000020000240 RDI: 0000000000000007 RBP: 00007fe103df139e R08: 0000000000000000 R09: 0000000000000003 R10: 0000000000007800 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fe103f35f80 R15: 00007ffeb98f7688