====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc5-syzkaller-00047-g5bd7ef53ffe5 #0 Not tainted ------------------------------------------------------ syz-executor182/10740 is trying to acquire lock: ffff8880258c1670 (&rs->rs_recv_lock){...-}-{2:2}, at: rds_wake_sk_sleep+0x23/0xe0 net/rds/af_rds.c:109 but task is already holding lock: ffff888071bc2900 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x155/0xa50 net/rds/send.c:628 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&rm->m_rs_lock){..-.}-{2:2}: __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x3a/0x50 kernel/locking/spinlock.c:162 rds_message_purge net/rds/message.c:138 [inline] rds_message_put+0x1dd/0xc50 net/rds/message.c:180 rds_inc_put+0x13c/0x1a0 net/rds/recv.c:83 rds_clear_recv_queue+0x14c/0x350 net/rds/recv.c:768 rds_release+0xdb/0x3c0 net/rds/af_rds.c:73 __sock_release+0xae/0x260 net/socket.c:659 sock_close+0x1c/0x20 net/socket.c:1419 __fput+0x270/0xbb0 fs/file_table.c:394 task_work_run+0x14d/0x240 kernel/task_work.c:180 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0xa92/0x2ae0 kernel/exit.c:871 do_group_exit+0xd4/0x2a0 kernel/exit.c:1021 get_signal+0x23be/0x2790 kernel/signal.c:2904 arch_do_signal_or_restart+0x90/0x7f0 arch/x86/kernel/signal.c:309 exit_to_user_mode_loop kernel/entry/common.c:168 [inline] exit_to_user_mode_prepare+0x121/0x240 kernel/entry/common.c:204 __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline] syscall_exit_to_user_mode+0x1e/0x60 kernel/entry/common.c:296 do_syscall_64+0x4d/0x110 arch/x86/entry/common.c:89 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&rs->rs_recv_lock){...-}-{2:2}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2433/0x3b20 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x46/0x90 kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x23/0xe0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x1e9/0xa50 net/rds/send.c:634 rds_send_path_drop_acked+0x2f4/0x3c0 net/rds/send.c:710 rds_tcp_write_space+0x1b5/0x6d0 net/rds/tcp_send.c:199 tcp_new_space net/ipv4/tcp_input.c:5615 [inline] tcp_check_space+0x178/0x8c0 net/ipv4/tcp_input.c:5634 tcp_data_snd_check net/ipv4/tcp_input.c:5643 [inline] tcp_rcv_established+0x953/0x20e0 net/ipv4/tcp_input.c:6161 tcp_v4_do_rcv+0x68c/0xa10 net/ipv4/tcp_ipv4.c:1906 sk_backlog_rcv include/net/sock.h:1121 [inline] __release_sock+0x132/0x3b0 net/core/sock.c:2968 release_sock+0x5a/0x1f0 net/core/sock.c:3534 rds_send_xmit+0x164f/0x2490 net/rds/send.c:422 rds_sendmsg+0x2af0/0x31e0 net/rds/send.c:1381 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0xd5/0x180 net/socket.c:745 ____sys_sendmsg+0x6ac/0x940 net/socket.c:2584 ___sys_sendmsg+0x135/0x1d0 net/socket.c:2638 __sys_sendmsg+0x117/0x1e0 net/socket.c:2667 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); lock(&rm->m_rs_lock); rlock(&rs->rs_recv_lock); *** DEADLOCK *** 3 locks held by syz-executor182/10740: #0: ffff88802ac6d3f0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1720 [inline] #0: ffff88802ac6d3f0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_sock_set_cork+0x1c/0x90 net/ipv4/tcp.c:3229 #1: ffff88802ac6d678 (k-clock-AF_INET){++.-}-{2:2}, at: rds_tcp_write_space+0x29/0x6d0 net/rds/tcp_send.c:185 #2: ffff888071bc2900 (&rm->m_rs_lock){..-.}-{2:2}, at: rds_send_remove_from_sock+0x155/0xa50 net/rds/send.c:628 stack backtrace: CPU: 0 PID: 10740 Comm: syz-executor182 Not tainted 6.7.0-rc5-syzkaller-00047-g5bd7ef53ffe5 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x317/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2433/0x3b20 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x46/0x90 kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x23/0xe0 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x1e9/0xa50 net/rds/send.c:634 rds_send_path_drop_acked+0x2f4/0x3c0 net/rds/send.c:710 rds_tcp_write_space+0x1b5/0x6d0 net/rds/tcp_send.c:199 tcp_new_space net/ipv4/tcp_input.c:5615 [inline] tcp_check_space+0x178/0x8c0 net/ipv4/tcp_input.c:5634 tcp_data_snd_check net/ipv4/tcp_input.c:5643 [inline] tcp_rcv_established+0x953/0x20e0 net/ipv4/tcp_input.c:6161 tcp_v4_do_rcv+0x68c/0xa10 net/ipv4/tcp_ipv4.c:1906 sk_backlog_rcv include/net/sock.h:1121 [inline] __release_sock+0x132/0x3b0 net/core/sock.c:2968 release_sock+0x5a/0x1f0 net/core/sock.c:3534 rds_send_xmit+0x164f/0x2490 net/rds/send.c:422 rds_sendmsg+0x2af0/0x31e0 net/rds/send.c:1381 sock_sendmsg_nosec net/socket.c:730 [inline] __sock_sendmsg+0xd5/0x180 net/socket.c:745 ____sys_sendmsg+0x6ac/0x940 net/socket.c:2584 ___sys_sendmsg+0x135/0x1d0 net/socket.c:2638 __sys_sendmsg+0x117/0x1e0 net/socket.c:2667 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7fa066fa2729 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 18 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa066f42228 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007fa06702c358 RCX: 00007fa066fa2729 RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000004 RBP: 00007fa06702c350 R08: 00007fff7fc26027 R09: 00007fa066f426c0 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fa06702c35c R13: 00007fa066ff9074 R14: 0000040000000015 R15: 00007fff7fc26028