======================================================
WARNING: possible circular locking dependency detected
6.1.102-syzkaller #0 Not tainted
------------------------------------------------------
syz.0.991/7434 is trying to acquire lock:
ffff0000e13370e0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574

but task is already holding lock:
ffff0000f4fbc208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332
       dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:463
       ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6773
       dqget+0x660/0xcb4 fs/quota/dquot.c:986
       dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2832
       quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310
       do_quotactl+0x508/0x698 fs/quota/quota.c:802
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl fs/quota/quota.c:916 [inline]
       __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       dquot_commit+0x54/0x240 fs/quota/dquot.c:507
       ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6753
       ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6813
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
       __dquot_alloc_space+0xb28/0xf50 fs/quota/dquot.c:1751
       dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline]
       dquot_alloc_space include/linux/quotaops.h:313 [inline]
       dquot_alloc_block include/linux/quotaops.h:337 [inline]
       ext4_mb_new_blocks+0xe8c/0x4680 fs/ext4/mballoc.c:5731
       ext4_ext_map_blocks+0x15a8/0x6644 fs/ext4/extents.c:4316
       ext4_map_blocks+0x828/0x1850 fs/ext4/inode.c:651
       ext4_getblk+0x198/0x6ec fs/ext4/inode.c:866
       ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:922
       ext4_append+0x260/0x4cc fs/ext4/namei.c:83
       ext4_init_new_dir+0x294/0x8e4 fs/ext4/namei.c:2981
       ext4_mkdir+0x3d4/0xa64 fs/ext4/namei.c:3027
       vfs_mkdir+0x334/0x4e4 fs/namei.c:4108
       do_mkdirat+0x220/0x510 fs/namei.c:4133
       __do_sys_mkdirat fs/namei.c:4148 [inline]
       __se_sys_mkdirat fs/namei.c:4146 [inline]
       __arm64_sys_mkdirat+0x90/0xa8 fs/namei.c:4146
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&ei->i_data_sem/2){++++}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574
       ext4_getblk+0x198/0x6ec fs/ext4/inode.c:866
       ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:922
       ext4_quota_write+0x230/0x54c fs/ext4/super.c:7147
       write_blk fs/quota/quota_tree.c:64 [inline]
       get_free_dqblk+0x28c/0x598 fs/quota/quota_tree.c:130
       do_insert_tree+0x1fc/0x1474 fs/quota/quota_tree.c:340
       do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375
       do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375
       do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375
       dq_insert_tree fs/quota/quota_tree.c:401 [inline]
       qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:420
       v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358
       dquot_acquire+0x2c4/0x5c4 fs/quota/dquot.c:472
       ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6773
       dqget+0x660/0xcb4 fs/quota/dquot.c:986
       __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1516
       dquot_initialize+0x24/0x34 fs/quota/dquot.c:1578
       ext4_xattr_set+0xe8/0x350 fs/ext4/xattr.c:2492
       ext4_xattr_security_set+0x4c/0x64 fs/ext4/xattr_security.c:31
       __vfs_removexattr+0x370/0x38c fs/xattr.c:479
       __vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:514
       vfs_removexattr+0xe0/0x23c fs/xattr.c:536
       removexattr fs/xattr.c:878 [inline]
       path_removexattr+0x1ec/0x2ec fs/xattr.c:892
       __do_sys_removexattr fs/xattr.c:906 [inline]
       __se_sys_removexattr fs/xattr.c:903 [inline]
       __arm64_sys_removexattr+0x60/0x78 fs/xattr.c:903
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&s->s_dquot.dqio_sem);
                               lock(&dquot->dq_lock);
                               lock(&s->s_dquot.dqio_sem);
  lock(&ei->i_data_sem/2);

 *** DEADLOCK ***

4 locks held by syz.0.991/7434:
 #0: ffff0000f4fbc460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393
 #1: ffff0000e13fde48 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff0000e13fde48 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: vfs_removexattr+0xcc/0x23c fs/xattr.c:535
 #2: ffff0000f1c2aea8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x5c4 fs/quota/dquot.c:460
 #3: ffff0000f4fbc208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x11c/0x188 fs/quota/quota_v2.c:354

stack backtrace:
CPU: 0 PID: 7434 Comm: syz.0.991 Not tainted 6.1.102-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 down_read+0x64/0x308 kernel/locking/rwsem.c:1520
 ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574
 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:866
 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:922
 ext4_quota_write+0x230/0x54c fs/ext4/super.c:7147
 write_blk fs/quota/quota_tree.c:64 [inline]
 get_free_dqblk+0x28c/0x598 fs/quota/quota_tree.c:130
 do_insert_tree+0x1fc/0x1474 fs/quota/quota_tree.c:340
 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375
 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375
 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375
 dq_insert_tree fs/quota/quota_tree.c:401 [inline]
 qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:420
 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358
 dquot_acquire+0x2c4/0x5c4 fs/quota/dquot.c:472
 ext4_acquire_dquot+0x270/0x420 fs/ext4/super.c:6773
 dqget+0x660/0xcb4 fs/quota/dquot.c:986
 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1516
 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1578
 ext4_xattr_set+0xe8/0x350 fs/ext4/xattr.c:2492
 ext4_xattr_security_set+0x4c/0x64 fs/ext4/xattr_security.c:31
 __vfs_removexattr+0x370/0x38c fs/xattr.c:479
 __vfs_removexattr_locked+0x1d8/0x380 fs/xattr.c:514
 vfs_removexattr+0xe0/0x23c fs/xattr.c:536
 removexattr fs/xattr.c:878 [inline]
 path_removexattr+0x1ec/0x2ec fs/xattr.c:892
 __do_sys_removexattr fs/xattr.c:906 [inline]
 __se_sys_removexattr fs/xattr.c:903 [inline]
 __arm64_sys_removexattr+0x60/0x78 fs/xattr.c:903
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585
EXT4-fs error (device loop0): ext4_validate_block_bitmap:438: comm syz.0.991: bg 0: block 65: padding at end of block bitmap is not set
Quota error (device loop0): write_blk: dquota write failed
Quota error (device loop0): qtree_write_dquot: Error -117 occurred while creating quota
EXT4-fs error (device loop0): ext4_acquire_dquot:6777: comm syz.0.991: Failed to acquire dquot type 0