bcachefs (loop1): shutdown complete, journal seq 20 bcachefs (loop1): marking filesystem clean ====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc3-next-20240611-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/6828 is trying to acquire lock: ffff888050e01a60 (&c->btree_root_lock){+.+.}-{3:3}, at: bch2_btree_roots_to_journal_entries+0xbb/0x980 fs/bcachefs/btree_update_interior.c:2615 but task is already holding lock: ffff888050e00918 (&c->sb_lock){+.+.}-{3:3}, at: bch2_fs_mark_clean+0x35/0x9f0 fs/bcachefs/sb-clean.c:287 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&c->sb_lock){+.+.}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5817 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 bch2_gc_mark_key+0xb61/0x10c0 fs/bcachefs/btree_gc.c:604 bch2_gc_btree fs/bcachefs/btree_gc.c:666 [inline] bch2_gc_btrees fs/bcachefs/btree_gc.c:698 [inline] bch2_check_allocations+0x1ff3/0x6ff0 fs/bcachefs/btree_gc.c:1103 bch2_run_recovery_pass+0xf0/0x1e0 fs/bcachefs/recovery_passes.c:183 bch2_run_recovery_passes+0x19e/0x820 fs/bcachefs/recovery_passes.c:230 bch2_fs_recovery+0x25d4/0x38c0 fs/bcachefs/recovery.c:846 bch2_fs_start+0x356/0x5b0 fs/bcachefs/super.c:1029 bch2_fs_get_tree+0xce4/0x1620 fs/bcachefs/fs.c:1922 vfs_get_tree+0x90/0x2a0 fs/super.c:1780 do_new_mount+0x2be/0xb40 fs/namespace.c:3379 do_mount fs/namespace.c:3719 [inline] __do_sys_mount fs/namespace.c:3925 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3902 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&c->btree_root_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3159 [inline] check_prevs_add kernel/locking/lockdep.c:3278 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3902 __lock_acquire+0x1359/0x2000 kernel/locking/lockdep.c:5194 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5817 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 bch2_btree_roots_to_journal_entries+0xbb/0x980 fs/bcachefs/btree_update_interior.c:2615 bch2_fs_mark_clean+0x4a9/0x9f0 fs/bcachefs/sb-clean.c:314 bch2_fs_read_only+0x1115/0x1220 fs/bcachefs/super.c:380 __bch2_fs_stop+0x105/0x540 fs/bcachefs/super.c:614 bch2_fs_stop+0x15/0x20 fs/bcachefs/super.c:673 bch2_fs_get_tree+0xf04/0x1620 fs/bcachefs/fs.c:2014 vfs_get_tree+0x90/0x2a0 fs/super.c:1780 do_new_mount+0x2be/0xb40 fs/namespace.c:3379 do_mount fs/namespace.c:3719 [inline] __do_sys_mount fs/namespace.c:3925 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3902 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&c->sb_lock); lock(&c->btree_root_lock); lock(&c->sb_lock); lock(&c->btree_root_lock); *** DEADLOCK *** 2 locks held by syz-executor.1/6828: #0: ffff888050e00278 (&c->state_lock){+.+.}-{3:3}, at: __bch2_fs_stop+0xfd/0x540 fs/bcachefs/super.c:613 #1: ffff888050e00918 (&c->sb_lock){+.+.}-{3:3}, at: bch2_fs_mark_clean+0x35/0x9f0 fs/bcachefs/sb-clean.c:287 stack backtrace: CPU: 1 PID: 6828 Comm: syz-executor.1 Not tainted 6.10.0-rc3-next-20240611-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:91 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:117 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2075 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2204 check_prev_add kernel/locking/lockdep.c:3159 [inline] check_prevs_add kernel/locking/lockdep.c:3278 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3902 __lock_acquire+0x1359/0x2000 kernel/locking/lockdep.c:5194 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5817 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 bch2_btree_roots_to_journal_entries+0xbb/0x980 fs/bcachefs/btree_update_interior.c:2615 bch2_fs_mark_clean+0x4a9/0x9f0 fs/bcachefs/sb-clean.c:314 bch2_fs_read_only+0x1115/0x1220 fs/bcachefs/super.c:380 __bch2_fs_stop+0x105/0x540 fs/bcachefs/super.c:614 bch2_fs_stop+0x15/0x20 fs/bcachefs/super.c:673 bch2_fs_get_tree+0xf04/0x1620 fs/bcachefs/fs.c:2014 vfs_get_tree+0x90/0x2a0 fs/super.c:1780 do_new_mount+0x2be/0xb40 fs/namespace.c:3379 do_mount fs/namespace.c:3719 [inline] __do_sys_mount fs/namespace.c:3925 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:3902 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f521367e5aa Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f52131feef8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f52131fef80 RCX: 00007f521367e5aa RDX: 0000000020000040 RSI: 0000000020000fc0 RDI: 00007f52131fef40 RBP: 0000000020000040 R08: 00007f52131fef80 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000202 R12: 0000000020000fc0 R13: 00007f52131fef40 R14: 00000000000119fc R15: 00000000200001c0 bcachefs (loop1): shutdown complete