hfsplus: invalid extended attribute record ====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc6-syzkaller-00002-g155a3c003e55 #0 Not tainted ------------------------------------------------------ syz.4.157/7047 is trying to acquire lock: ffff88805a0138f8 (&sbi->alloc_mutex){+.+.}-{4:4}, at: hfsplus_block_free+0xbe/0x550 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff88807db9d8c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x294/0xb40 fs/hfsplus/extents.c:577 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}: lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 hfsplus_get_block+0x39e/0x1530 fs/hfsplus/extents.c:260 block_read_full_folio+0x29c/0x830 fs/buffer.c:2427 filemap_read_folio+0x117/0x380 mm/filemap.c:2412 do_read_cache_folio+0x350/0x590 mm/filemap.c:3894 do_read_cache_page mm/filemap.c:3960 [inline] read_cache_page+0x5d/0x170 mm/filemap.c:3969 read_mapping_page include/linux/pagemap.h:966 [inline] hfsplus_block_allocate+0xe4/0x9b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xae3/0x1990 fs/hfsplus/extents.c:469 hfsplus_get_block+0x411/0x1530 fs/hfsplus/extents.c:245 __block_write_begin_int+0x6b5/0x1900 fs/buffer.c:2151 block_write_begin fs/buffer.c:2262 [inline] cont_write_begin+0x789/0xb50 fs/buffer.c:2601 hfsplus_write_begin+0x66/0xb0 fs/hfsplus/inode.c:46 page_symlink+0x26f/0x430 fs/namei.c:5520 hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x143/0x2f0 fs/namei.c:4739 do_symlinkat+0x1b1/0x3f0 fs/namei.c:4765 __do_sys_symlink fs/namei.c:4786 [inline] __se_sys_symlink fs/namei.c:4784 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4784 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 hfsplus_block_free+0xbe/0x550 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x176/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x736/0xb40 fs/hfsplus/extents.c:592 hfsplus_delete_inode fs/hfsplus/inode.c:-1 [inline] hfsplus_file_release+0x303/0x3e0 fs/hfsplus/inode.c:237 __fput+0x449/0xa70 fs/file_table.c:465 task_work_run+0x1d4/0x260 kernel/task_work.c:227 exit_task_work include/linux/task_work.h:40 [inline] do_exit+0x6b5/0x22e0 kernel/exit.c:964 do_group_exit+0x21c/0x2d0 kernel/exit.c:1105 get_signal+0x125e/0x1310 kernel/signal.c:3034 arch_do_signal_or_restart+0x9a/0x750 arch/x86/kernel/signal.c:337 exit_to_user_mode_loop+0x75/0x110 kernel/entry/common.c:111 exit_to_user_mode_prepare include/linux/entry-common.h:330 [inline] syscall_exit_to_user_mode_work include/linux/entry-common.h:414 [inline] syscall_exit_to_user_mode include/linux/entry-common.h:449 [inline] do_syscall_64+0x2bd/0x3b0 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 2 locks held by syz.4.157/7047: #0: ffff88807db9dab8 (&sb->s_type->i_mutex_key#29){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #0: ffff88807db9dab8 (&sb->s_type->i_mutex_key#29){+.+.}-{4:4}, at: hfsplus_file_release+0xe2/0x3e0 fs/hfsplus/inode.c:232 #1: ffff88807db9d8c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_truncate+0x294/0xb40 fs/hfsplus/extents.c:577 stack backtrace: CPU: 0 UID: 0 PID: 7047 Comm: syz.4.157 Not tainted 6.16.0-rc6-syzkaller-00002-g155a3c003e55 #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 print_circular_bug+0x2ee/0x310 kernel/locking/lockdep.c:2046 check_noncircular+0x134/0x160 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain+0xb9b/0x2140 kernel/locking/lockdep.c:3911 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871 __mutex_lock_common kernel/locking/mutex.c:602 [inline] __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747 hfsplus_block_free+0xbe/0x550 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x176/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x736/0xb40 fs/hfsplus/extents.c:592 hfsplus_delete_inode fs/hfsplus/inode.c:-1 [inline] hfsplus_file_release+0x303/0x3e0 fs/hfsplus/inode.c:237 __fput+0x449/0xa70 fs/file_table.c:465 task_work_run+0x1d4/0x260 kernel/task_work.c:227 exit_task_work include/linux/task_work.h:40 [inline] do_exit+0x6b5/0x22e0 kernel/exit.c:964 do_group_exit+0x21c/0x2d0 kernel/exit.c:1105 get_signal+0x125e/0x1310 kernel/signal.c:3034 arch_do_signal_or_restart+0x9a/0x750 arch/x86/kernel/signal.c:337 exit_to_user_mode_loop+0x75/0x110 kernel/entry/common.c:111 exit_to_user_mode_prepare include/linux/entry-common.h:330 [inline] syscall_exit_to_user_mode_work include/linux/entry-common.h:414 [inline] syscall_exit_to_user_mode include/linux/entry-common.h:449 [inline] do_syscall_64+0x2bd/0x3b0 arch/x86/entry/syscall_64.c:100 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f2bcbd8d58a Code: Unable to access opcode bytes at 0x7f2bcbd8d560. RSP: 002b:00007f2bc9bd4e00 EFLAGS: 00000293 ORIG_RAX: 0000000000000003 RAX: 0000000000000000 RBX: 00000000ffffffff RCX: 00007f2bcbd8d58a RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000008 RBP: 0000000000000010 R08: 0000000000000000 R09: 000000000000559d R10: 0000000000000000 R11: 0000000000000293 R12: 0000000000000008 R13: 00007f2bc9bd4ef0 R14: 00007f2bc9bd4eb0 R15: 00007f2bc1600000