vxcan1: j1939_tp_rxtimer: 0xffff888020672c00: rx timeout, send abort
======================================================
WARNING: possible circular locking dependency detected
6.0.0-syzkaller-06475-g4c86114194e6 #0 Not tainted
------------------------------------------------------
swapper/0/0 is trying to acquire lock:
ffff88804690d0d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
ffff88804690d0d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1081
but task is already holding lock:
ffff88804690d088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
ffff88804690d088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff88804690d088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe5/0x220 net/can/j1939/transport.c:1246
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #2 (&priv->active_session_list_lock){+.-.}-{2:2}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:354 [inline]
j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
j1939_session_activate+0x43/0x4b0 net/can/j1939/transport.c:1559
j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
j1939_sk_queue_activate_next+0x1b2/0x450 net/can/j1939/socket.c:208
j1939_session_deactivate_activate_next+0xc8/0xd3 net/can/j1939/transport.c:1107
j1939_xtp_rx_abort_one.cold+0x20b/0x33c net/can/j1939/transport.c:1346
j1939_xtp_rx_abort net/can/j1939/transport.c:1357 [inline]
j1939_tp_cmd_recv net/can/j1939/transport.c:2106 [inline]
j1939_tp_recv+0xb28/0xcb0 net/can/j1939/transport.c:2139
j1939_can_recv net/can/j1939/main.c:112 [inline]
j1939_can_recv+0x78a/0xa30 net/can/j1939/main.c:38
deliver net/can/af_can.c:573 [inline]
can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:607
can_receive+0x31d/0x580 net/can/af_can.c:664
can_rcv+0x162/0x1a0 net/can/af_can.c:688
__netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5485
__netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5599
process_backlog+0x3a0/0x7c0 net/core/dev.c:5927
__napi_poll+0xb3/0x6d0 net/core/dev.c:6494
napi_poll net/core/dev.c:6561 [inline]
net_rx_action+0x9c1/0xd90 net/core/dev.c:6672
__do_softirq+0x1d0/0x9c8 kernel/softirq.c:571
run_ksoftirqd kernel/softirq.c:934 [inline]
run_ksoftirqd+0x2d/0x60 kernel/softirq.c:926
smpboot_thread_fn+0x645/0x9c0 kernel/smpboot.c:164
kthread+0x2e4/0x3a0 kernel/kthread.c:376
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
-> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:354 [inline]
j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139
j1939_sk_netdev_event_netdown+0x7b/0x160 net/can/j1939/socket.c:1275
j1939_netdev_notify+0x199/0x1d0 net/can/j1939/main.c:376
notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1945
call_netdevice_notifiers_extack net/core/dev.c:1983 [inline]
call_netdevice_notifiers net/core/dev.c:1997 [inline]
__dev_notify_flags+0x1da/0x2b0 net/core/dev.c:8579
dev_change_flags+0x112/0x170 net/core/dev.c:8615
do_setlink+0x9f1/0x3bb0 net/core/rtnetlink.c:2788
__rtnl_newlink+0xd6a/0x17e0 net/core/rtnetlink.c:3547
rtnl_newlink+0x64/0xa0 net/core/rtnetlink.c:3594
rtnetlink_rcv_msg+0x43a/0xca0 net/core/rtnetlink.c:6091
netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2540
netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
sock_sendmsg_nosec net/socket.c:714 [inline]
sock_sendmsg+0xcf/0x120 net/socket.c:734
____sys_sendmsg+0x712/0x8c0 net/socket.c:2482
___sys_sendmsg+0x110/0x1b0 net/socket.c:2536
__sys_sendmsg+0xf3/0x1c0 net/socket.c:2565
do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline]
__do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178
do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203
entry_SYSENTER_compat_after_hwframe+0x70/0x82
-> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}:
check_prev_add kernel/locking/lockdep.c:3095 [inline]
check_prevs_add kernel/locking/lockdep.c:3214 [inline]
validate_chain kernel/locking/lockdep.c:3829 [inline]
__lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053
lock_acquire kernel/locking/lockdep.c:5666 [inline]
lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:354 [inline]
j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1081
__j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1130
j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1255
__run_hrtimer kernel/time/hrtimer.c:1685 [inline]
__hrtimer_run_queues+0x5fa/0xe40 kernel/time/hrtimer.c:1749
hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1766
__do_softirq+0x1d0/0x9c8 kernel/softirq.c:571
invoke_softirq kernel/softirq.c:445 [inline]
__irq_exit_rcu+0x123/0x180 kernel/softirq.c:650
irq_exit_rcu+0x5/0x20 kernel/softirq.c:662
sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1107
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649
native_safe_halt arch/x86/include/asm/irqflags.h:51 [inline]
arch_safe_halt arch/x86/include/asm/irqflags.h:89 [inline]
acpi_safe_halt drivers/acpi/processor_idle.c:112 [inline]
acpi_idle_do_entry+0x1fd/0x2a0 drivers/acpi/processor_idle.c:572
acpi_idle_enter+0x364/0x500 drivers/acpi/processor_idle.c:709
cpuidle_enter_state+0x1ab/0xd30 drivers/cpuidle/cpuidle.c:239
cpuidle_enter+0x4a/0xa0 drivers/cpuidle/cpuidle.c:356
call_cpuidle kernel/sched/idle.c:155 [inline]
cpuidle_idle_call kernel/sched/idle.c:236 [inline]
do_idle+0x3e8/0x590 kernel/sched/idle.c:303
cpu_startup_entry+0x14/0x20 kernel/sched/idle.c:400
rest_init+0x169/0x270 init/main.c:727
arch_call_rest_init+0xf/0x14 init/main.c:883
start_kernel+0x46e/0x48f init/main.c:1138
secondary_startup_64_no_verify+0xce/0xdb
other info that might help us debug this:
Chain exists of:
&priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock
Possible unsafe locking scenario:
CPU0 CPU1
---- ----
lock(&priv->active_session_list_lock);
lock(&jsk->sk_session_queue_lock);
lock(&priv->active_session_list_lock);
lock(&priv->j1939_socks_lock);
*** DEADLOCK ***
1 lock held by swapper/0/0:
#0: ffff88804690d088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
#0: ffff88804690d088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
#0: ffff88804690d088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_tp_rxtimer+0xe5/0x220 net/can/j1939/transport.c:1246
stack backtrace:
CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.0.0-syzkaller-06475-g4c86114194e6 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022
Call Trace:
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2175
check_prev_add kernel/locking/lockdep.c:3095 [inline]
check_prevs_add kernel/locking/lockdep.c:3214 [inline]
validate_chain kernel/locking/lockdep.c:3829 [inline]
__lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5053
lock_acquire kernel/locking/lockdep.c:5666 [inline]
lock_acquire+0x1ab/0x570 kernel/locking/lockdep.c:5631
__raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
_raw_spin_lock_bh+0x2f/0x40 kernel/locking/spinlock.c:178
spin_lock_bh include/linux/spinlock.h:354 [inline]
j1939_sk_errqueue+0x9f/0x1a0 net/can/j1939/socket.c:1081
__j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1130
j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1255
__run_hrtimer kernel/time/hrtimer.c:1685 [inline]
__hrtimer_run_queues+0x5fa/0xe40 kernel/time/hrtimer.c:1749
hrtimer_run_softirq+0x17b/0x360 kernel/time/hrtimer.c:1766
__do_softirq+0x1d0/0x9c8 kernel/softirq.c:571
invoke_softirq kernel/softirq.c:445 [inline]
__irq_exit_rcu+0x123/0x180 kernel/softirq.c:650
irq_exit_rcu+0x5/0x20 kernel/softirq.c:662
sysvec_apic_timer_interrupt+0x93/0xc0 arch/x86/kernel/apic/apic.c:1107
asm_sysvec_apic_timer_interrupt+0x16/0x20 arch/x86/include/asm/idtentry.h:649
RIP: 0010:native_save_fl arch/x86/include/asm/irqflags.h:29 [inline]
RIP: 0010:arch_local_save_flags arch/x86/include/asm/irqflags.h:70 [inline]
RIP: 0010:arch_irqs_disabled arch/x86/include/asm/irqflags.h:130 [inline]
RIP: 0010:acpi_safe_halt drivers/acpi/processor_idle.c:113 [inline]
RIP: 0010:acpi_idle_do_entry+0x1fd/0x2a0 drivers/acpi/processor_idle.c:572
Code: 89 de e8 36 46 f3 f7 84 db 75 ac e8 ad 49 f3 f7 e8 e8 c0 f9 f7 66 90 e8 a1 49 f3 f7 0f 00 2d 2a 77 cd 00 e8 95 49 f3 f7 fb f4 <9c> 5b 81 e3 00 02 00 00 fa 31 ff 48 89 de e8 60 46 f3 f7 48 85 db
RSP: 0018:ffffffff8bc07d30 EFLAGS: 00000293
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffffffff8bcbc980 RSI: ffffffff8987cc1b RDI: 0000000000000000
RBP: ffff888017bd9864 R08: 0000000000000001 R09: 0000000000000001
R10: 0000000000000000 R11: 0000000000000001 R12: 0000000000000001
R13: ffff888017bd9800 R14: ffff888017bd9864 R15: ffff88801ada9804
acpi_idle_enter+0x364/0x500 drivers/acpi/processor_idle.c:709
cpuidle_enter_state+0x1ab/0xd30 drivers/cpuidle/cpuidle.c:239
cpuidle_enter+0x4a/0xa0 drivers/cpuidle/cpuidle.c:356
call_cpuidle kernel/sched/idle.c:155 [inline]
cpuidle_idle_call kernel/sched/idle.c:236 [inline]
do_idle+0x3e8/0x590 kernel/sched/idle.c:303
cpu_startup_entry+0x14/0x20 kernel/sched/idle.c:400
rest_init+0x169/0x270 init/main.c:727
arch_call_rest_init+0xf/0x14 init/main.c:883
start_kernel+0x46e/0x48f init/main.c:1138
secondary_startup_64_no_verify+0xce/0xdb
vxcan1: j1939_xtp_rx_abort_one: 0xffff888020672c00: 0x00000: (3) A timeout occurred and this is the connection abort to close the session.
vxcan1: j1939_tp_rxtimer: 0xffff888020670800: rx timeout, send abort
vxcan1: j1939_xtp_rx_abort_one: 0xffff888020670800: 0x00000: (3) A timeout occurred and this is the connection abort to close the session.
vxcan1: j1939_tp_rxtimer: 0xffff88807a51a400: rx timeout, send abort
vxcan1: j1939_xtp_rx_abort_one: 0xffff88807a51a400: 0x00000: (3) A timeout occurred and this is the connection abort to close the session.
vxcan1: j1939_tp_rxtimer: 0xffff8880454dbc00: rx timeout, send abort
vxcan1: j1939_xtp_rx_abort_one: 0xffff8880454dbc00: 0x00000: (3) A timeout occurred and this is the connection abort to close the session.
vxcan1: j1939_tp_rxtimer: 0xffff88807a3c2c00: rx timeout, send abort
vxcan1: j1939_xtp_rx_abort_one: 0xffff88807a3c2c00: 0x00000: (3) A timeout occurred and this is the connection abort to close the session.
----------------
Code disassembly (best guess):
0: 89 de mov %ebx,%esi
2: e8 36 46 f3 f7 callq 0xf7f3463d
7: 84 db test %bl,%bl
9: 75 ac jne 0xffffffb7
b: e8 ad 49 f3 f7 callq 0xf7f349bd
10: e8 e8 c0 f9 f7 callq 0xf7f9c0fd
15: 66 90 xchg %ax,%ax
17: e8 a1 49 f3 f7 callq 0xf7f349bd
1c: 0f 00 2d 2a 77 cd 00 verw 0xcd772a(%rip) # 0xcd774d
23: e8 95 49 f3 f7 callq 0xf7f349bd
28: fb sti
29: f4 hlt
* 2a: 9c pushfq <-- trapping instruction
2b: 5b pop %rbx
2c: 81 e3 00 02 00 00 and $0x200,%ebx
32: fa cli
33: 31 ff xor %edi,%edi
35: 48 89 de mov %rbx,%rsi
38: e8 60 46 f3 f7 callq 0xf7f3469d
3d: 48 85 db test %rbx,%rbx