======================================================
WARNING: possible circular locking dependency detected
6.8.0-rc7-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor946/5059 is trying to acquire lock:
ffff88807e2d87c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457

but task is already holding lock:
ffff8880295640b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a7/0x200 fs/hfsplus/bfind.c:30

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752
       hfsplus_file_truncate+0x886/0x9e0 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x1eb/0x310 fs/hfsplus/inode.c:265
       notify_change+0x742/0x11c0 fs/attr.c:499
       do_truncate+0x15c/0x220 fs/open.c:66
       handle_truncate fs/namei.c:3303 [inline]
       do_open fs/namei.c:3649 [inline]
       path_openat+0x24c0/0x29a0 fs/namei.c:3802
       do_filp_open+0x1de/0x440 fs/namei.c:3829
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1404
       __do_sys_openat2+0x1a4/0x2a0 fs/open.c:1460
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xd5/0x270 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x6f/0x77

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain kernel/locking/lockdep.c:3869 [inline]
       __lock_acquire+0x244f/0x3b40 kernel/locking/lockdep.c:5137
       lock_acquire kernel/locking/lockdep.c:5754 [inline]
       lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752
       hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358
       hfsplus_rename_cat+0x2b1/0x1240 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x118/0x200 fs/hfsplus/dir.c:552
       vfs_rename+0xf87/0x20b0 fs/namei.c:4883
       do_renameat2+0xc54/0xdc0 fs/namei.c:5040
       __do_sys_renameat2 fs/namei.c:5074 [inline]
       __se_sys_renameat2 fs/namei.c:5071 [inline]
       __x64_sys_renameat2+0xeb/0x130 fs/namei.c:5071
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xd5/0x270 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x6f/0x77

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

3 locks held by syz-executor946/5059:
 #0: ffff8880285a8420 (sb_writers#10){.+.+}-{0:0}, at: do_renameat2+0x3d6/0xdc0 fs/namei.c:4970
 #1: ffff88807e2d9e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:839 [inline]
 #1: ffff88807e2d9e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3069 [inline]
 #1: ffff88807e2d9e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3066 [inline]
 #1: ffff88807e2d9e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: do_renameat2+0xad9/0xdc0 fs/namei.c:4975
 #2: ffff8880295640b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x1a7/0x200 fs/hfsplus/bfind.c:30

stack backtrace:
CPU: 1 PID: 5059 Comm: syz-executor946 Not tainted 6.8.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106
 check_noncircular+0x31b/0x400 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain kernel/locking/lockdep.c:3869 [inline]
 __lock_acquire+0x244f/0x3b40 kernel/locking/lockdep.c:5137
 lock_acquire kernel/locking/lockdep.c:5754 [inline]
 lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:752
 hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358
 hfsplus_rename_cat+0x2b1/0x1240 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x118/0x200 fs/hfsplus/dir.c:552
 vfs_rename+0xf87/0x20b0 fs/namei.c:4883
 do_renameat2+0xc54/0xdc0 fs/namei.c:5040
 __do_sys_renameat2 fs/namei.c:5074 [inline]
 __se_sys_renameat2 fs/namei.c:5071 [inline]
 __x64_sys_renameat2+0xeb/0x130 fs/namei.c:5071
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xd5/0x270 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x6f/0x77
RIP: 0033:0x7f74ac9b17b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 61 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc2bdb2cd8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 0030656c69662f2e RCX: 00007f74ac9b17b9
RDX: 0000000000000007 RSI: 00000000200001c0 RDI: 000000000