====================================================== WARNING: possible circular locking dependency detected 5.15.171-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.4/4259 is trying to acquire lock: ffff888025fe4650 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_setattr+0xb98/0x1c70 fs/ocfs2/file.c:1263 but task is already holding lock: ffff8880616022e0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xb89/0x1c70 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 ocfs2_try_remove_refcount_tree+0xb2/0x330 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0xa4b/0x1930 fs/ocfs2/xattr.c:3674 ocfs2_set_acl+0x4cb/0x570 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x252/0x3c0 fs/ocfs2/acl.c:285 set_posix_acl fs/posix_acl.c:947 [inline] posix_acl_xattr_set+0x33b/0x3a0 fs/posix_acl.c:966 __vfs_removexattr+0x3ce/0x410 fs/xattr.c:470 __vfs_removexattr_locked+0x1fe/0x410 fs/xattr.c:505 vfs_removexattr+0xff/0x2a0 fs/xattr.c:527 ovl_workdir_create+0x3e3/0x7d0 fs/overlayfs/super.c:818 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #3 (&oi->ip_xattr_sem){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_init_acl+0x398/0x930 fs/ocfs2/acl.c:365 ocfs2_mknod+0x1e8f/0x2cd0 fs/ocfs2/namei.c:408 ocfs2_mkdir+0x194/0x430 fs/ocfs2/namei.c:655 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 start_this_handle+0x12e1/0x1570 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2d1/0x5c0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x25/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x3c2/0x6f0 fs/ocfs2/journal.c:354 ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:359 ocfs2_mkdir+0x194/0x430 fs/ocfs2/namei.c:655 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x3b7/0x6f0 fs/ocfs2/journal.c:352 ocfs2_mknod+0x15bb/0x2cd0 fs/ocfs2/namei.c:359 ocfs2_mkdir+0x194/0x430 fs/ocfs2/namei.c:655 vfs_mkdir+0x3b6/0x590 fs/namei.c:4065 do_mkdirat+0x260/0x520 fs/namei.c:4090 __do_sys_mkdirat fs/namei.c:4105 [inline] __se_sys_mkdirat fs/namei.c:4103 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4103 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xb98/0x1c70 fs/ocfs2/file.c:1263 notify_change+0xc6d/0xf50 fs/attr.c:505 ovl_workdir_create+0x5a3/0x7d0 fs/overlayfs/super.c:830 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: sb_internal#3 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(&oi->ip_xattr_sem); lock(&oi->ip_alloc_sem); lock(sb_internal#3); *** DEADLOCK *** 5 locks held by syz.3.4/4259: #0: ffff88801adb00e0 (&type->s_umount_key#53/1){+.+.}-{3:3}, at: alloc_super+0x210/0x940 fs/super.c:229 #1: ffff888025fe4460 (sb_writers#16){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #2: ffff888061601808 (&sb->s_type->i_mutex_key#22/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:824 [inline] #2: ffff888061601808 (&sb->s_type->i_mutex_key#22/1){+.+.}-{3:3}, at: ovl_workdir_create+0x12e/0x7d0 fs/overlayfs/super.c:768 #3: ffff888061602648 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #3: ffff888061602648 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: ovl_workdir_create+0x575/0x7d0 fs/overlayfs/super.c:829 #4: ffff8880616022e0 (&oi->ip_alloc_sem){+.+.}-{3:3}, at: ocfs2_setattr+0xb89/0x1c70 fs/ocfs2/file.c:1262 stack backtrace: CPU: 1 PID: 4259 Comm: syz.3.4 Not tainted 5.15.171-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1813 [inline] sb_start_intwrite include/linux/fs.h:1930 [inline] ocfs2_start_trans+0x2b2/0x6f0 fs/ocfs2/journal.c:350 ocfs2_setattr+0xb98/0x1c70 fs/ocfs2/file.c:1263 notify_change+0xc6d/0xf50 fs/attr.c:505 ovl_workdir_create+0x5a3/0x7d0 fs/overlayfs/super.c:830 ovl_make_workdir fs/overlayfs/super.c:1374 [inline] ovl_get_workdir+0x3ab/0x1350 fs/overlayfs/super.c:1524 ovl_fill_super+0x1b85/0x2a20 fs/overlayfs/super.c:2080 mount_nodev+0x52/0xe0 fs/super.c:1446 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1530 do_new_mount+0x2ba/0xb40 fs/namespace.c:3012 do_mount fs/namespace.c:3355 [inline] __do_sys_mount fs/namespace.c:3563 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3540 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f8e6ad3c719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f8e691b4038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f8e6aef3f80 RCX: 00007f8e6ad3c719 RDX: 0000000020000080 RSI: 00000000200000c0 RDI: 0000000000000000 RBP: 00007f8e6adaf39e R08: 0000000020000900 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f8e6aef3f80 R15: 00007ffeaa7d2998 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: failed to set xattr on upper overlayfs: ...falling back to index=off,metacopy=off. overlayfs: upper fs missing required features.