8021q: adding VLAN 0 to HW filter on device team0 ============================================ WARNING: possible recursive locking detected 4.19.211-syzkaller #0 Not tainted -------------------------------------------- syz-executor.0/4919 is trying to acquire lock: 000000002d6446df (&team->lock){+.+.}, at: team_vlan_rx_add_vid+0x38/0x1e0 drivers/net/team/team.c:1896 but task is already holding lock: 000000007fc781bc (&team->lock){+.+.}, at: team_add_slave+0x98/0x1fa0 drivers/net/team/team.c:1975 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&team->lock); lock(&team->lock); *** DEADLOCK *** May be due to missing lock nesting notation 2 locks held by syz-executor.0/4919: #0: 0000000001ba82ab (rtnl_mutex){+.+.}, at: rtnl_lock net/core/rtnetlink.c:77 [inline] #0: 0000000001ba82ab (rtnl_mutex){+.+.}, at: rtnetlink_rcv_msg+0x3fe/0xb80 net/core/rtnetlink.c:4779 #1: 000000007fc781bc (&team->lock){+.+.}, at: team_add_slave+0x98/0x1fa0 drivers/net/team/team.c:1975 stack backtrace: CPU: 1 PID: 4919 Comm: syz-executor.0 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_deadlock_bug kernel/locking/lockdep.c:1764 [inline] check_deadlock kernel/locking/lockdep.c:1808 [inline] validate_chain kernel/locking/lockdep.c:2404 [inline] __lock_acquire.cold+0x121/0x57e kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 team_vlan_rx_add_vid+0x38/0x1e0 drivers/net/team/team.c:1896 vlan_add_rx_filter_info+0x13c/0x1c0 net/8021q/vlan_core.c:210 __vlan_vid_add net/8021q/vlan_core.c:278 [inline] vlan_vid_add+0x3ee/0x7e0 net/8021q/vlan_core.c:308 vlan_device_event.cold+0x28/0x2d net/8021q/vlan.c:382 notifier_call_chain+0xc0/0x230 kernel/notifier.c:93 call_netdevice_notifiers net/core/dev.c:1762 [inline] dev_open net/core/dev.c:1442 [inline] dev_open+0x128/0x140 net/core/dev.c:1430 team_port_add drivers/net/team/team.c:1220 [inline] team_add_slave+0xb02/0x1fa0 drivers/net/team/team.c:1976 do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2321 do_setlink+0x7ec/0x3540 net/core/rtnetlink.c:2455 rtnl_newlink+0xda9/0x15c0 net/core/rtnetlink.c:3077 rtnetlink_rcv_msg+0x453/0xb80 net/core/rtnetlink.c:4782 netlink_rcv_skb+0x160/0x440 net/netlink/af_netlink.c:2463 netlink_unicast_kernel net/netlink/af_netlink.c:1325 [inline] netlink_unicast+0x4d5/0x690 net/netlink/af_netlink.c:1351 netlink_sendmsg+0x6c3/0xc50 net/netlink/af_netlink.c:1917 sock_sendmsg_nosec net/socket.c:651 [inline] sock_sendmsg+0xc3/0x120 net/socket.c:661 ___sys_sendmsg+0x7bb/0x8e0 net/socket.c:2227 __sys_sendmsg net/socket.c:2265 [inline] __do_sys_sendmsg net/socket.c:2274 [inline] __se_sys_sendmsg net/socket.c:2272 [inline] __x64_sys_sendmsg+0x132/0x220 net/socket.c:2272 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7fa7311920f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa72f6e3168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e RAX: ffffffffffffffda RBX: 00007fa7312b2050 RCX: 00007fa7311920f9 RDX: 0000000000000000 RSI: 0000000020000000 RDI: 000000000000000c RBP: 00007fa7311edae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffe97c9c80f R14: 00007fa72f6e3300 R15: 0000000000022000 team1: Port device team0 added IPVS: ftp: loaded support on port[0] = 21 kauditd_printk_skb: 6 callbacks suppressed audit: type=1804 audit(1678177239.469:994): pid=5074 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/142/bus" dev="sda1" ino=14479 res=1 netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.4'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. audit: type=1804 audit(1678177240.459:995): pid=5145 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/143/bus" dev="sda1" ino=14305 res=1 audit: type=1804 audit(1678177241.269:996): pid=5167 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.1" name="/root/syzkaller-testdir2264364156/syzkaller.jq0wov/771/bus" dev="sda1" ino=14417 res=1 audit: type=1804 audit(1678177241.279:997): pid=5167 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.1" name="/root/syzkaller-testdir2264364156/syzkaller.jq0wov/771/bus" dev="sda1" ino=14417 res=1 netlink: 'syz-executor.2': attribute type 4 has an invalid length. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. audit: type=1804 audit(1678177241.559:998): pid=5238 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.1" name="/root/syzkaller-testdir2264364156/syzkaller.jq0wov/772/bus" dev="sda1" ino=14552 res=1 audit: type=1804 audit(1678177241.599:999): pid=5243 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/145/file0" dev="sda1" ino=14541 res=1 netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. audit: type=1804 audit(1678177241.609:1000): pid=5243 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/145/file0" dev="sda1" ino=14541 res=1 audit: type=1804 audit(1678177241.629:1001): pid=5248 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.1" name="/root/syzkaller-testdir2264364156/syzkaller.jq0wov/772/bus" dev="sda1" ino=14552 res=1 audit: type=1804 audit(1678177242.049:1002): pid=5280 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/147/file0" dev="sda1" ino=14553 res=1 audit: type=1804 audit(1678177242.079:1003): pid=5275 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/147/file0" dev="sda1" ino=14553 res=1 netlink: 'syz-executor.2': attribute type 4 has an invalid length. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. nla_parse: 5 callbacks suppressed netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'. kauditd_printk_skb: 8 callbacks suppressed audit: type=1804 audit(1678177245.509:1012): pid=5401 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.5" name="/root/syzkaller-testdir3194243642/syzkaller.62Vt7z/742/bus" dev="sda1" ino=13956 res=1 audit: type=1804 audit(1678177245.519:1013): pid=5401 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.5" name="/root/syzkaller-testdir3194243642/syzkaller.62Vt7z/742/bus" dev="sda1" ino=13956 res=1 audit: type=1804 audit(1678177245.769:1014): pid=5412 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=open_writers comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/149/bus" dev="sda1" ino=14003 res=1 audit: type=1804 audit(1678177245.819:1015): pid=5412 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=invalid_pcr cause=ToMToU comm="syz-executor.0" name="/root/syzkaller-testdir754850255/syzkaller.4O0Twc/149/bus" dev="sda1" ino=14003 res=1