====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc7-syzkaller-g14f8db1c0f9a #0 Not tainted ------------------------------------------------------ syz-executor135/5975 is trying to acquire lock: ffff0000de027a70 (&rs->rs_recv_lock){....}-{2:2}, at: rds_wake_sk_sleep+0x34/0xc8 net/rds/af_rds.c:109 but task is already holding lock: ffff0000c93bc900 (&rm->m_rs_lock){....}-{2:2}, at: rds_send_remove_from_sock+0x134/0x78c net/rds/send.c:628 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&rm->m_rs_lock){....}-{2:2}: __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x5c/0x7c kernel/locking/spinlock.c:162 rds_message_purge net/rds/message.c:138 [inline] rds_message_put+0x130/0xb30 net/rds/message.c:180 rds_loop_inc_free+0x20/0x30 net/rds/loop.c:115 rds_inc_put net/rds/recv.c:83 [inline] rds_clear_recv_queue+0x288/0x384 net/rds/recv.c:768 rds_release+0xbc/0x2d0 net/rds/af_rds.c:73 __sock_release net/socket.c:653 [inline] sock_close+0xb8/0x1fc net/socket.c:1395 __fput+0x30c/0x7bc fs/file_table.c:321 ____fput+0x20/0x30 fs/file_table.c:349 task_work_run+0x230/0x2e0 kernel/task_work.c:179 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0x63c/0x1f58 kernel/exit.c:869 do_group_exit+0x194/0x22c kernel/exit.c:1019 get_signal+0x14b0/0x159c kernel/signal.c:2859 do_signal arch/arm64/kernel/signal.c:1248 [inline] do_notify_resume+0x3cc/0x3c90 arch/arm64/kernel/signal.c:1301 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_svc+0x90/0x15c arch/arm64/kernel/entry-common.c:638 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #0 (&rs->rs_recv_lock){....}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x238/0x718 kernel/locking/lockdep.c:5669 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x6c/0x8c kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x34/0xc8 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x1a4/0x78c net/rds/send.c:634 rds_send_path_drop_acked+0x390/0x3f0 net/rds/send.c:710 rds_tcp_write_space+0x1a8/0x594 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5483 [inline] tcp_check_space+0x150/0x888 net/ipv4/tcp_input.c:5502 tcp_data_snd_check net/ipv4/tcp_input.c:5511 [inline] tcp_rcv_established+0xdc0/0x1ee0 net/ipv4/tcp_input.c:6019 tcp_v4_do_rcv+0x388/0xd8c net/ipv4/tcp_ipv4.c:1721 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x1a8/0x408 net/core/sock.c:2922 release_sock+0x68/0x1b0 net/core/sock.c:3489 tcp_sock_set_cork+0x100/0x188 net/ipv4/tcp.c:3344 rds_tcp_xmit_path_complete+0x7c/0x8c net/rds/tcp_send.c:52 rds_send_xmit+0x1978/0x22a0 net/rds/send.c:422 rds_sendmsg+0x1608/0x1bc8 net/rds/send.c:1381 sock_sendmsg_nosec net/socket.c:724 [inline] sock_sendmsg net/socket.c:747 [inline] ____sys_sendmsg+0x568/0x81c net/socket.c:2501 ___sys_sendmsg net/socket.c:2555 [inline] __sys_sendmsg+0x26c/0x33c net/socket.c:2584 __do_sys_sendmsg net/socket.c:2593 [inline] __se_sys_sendmsg net/socket.c:2591 [inline] __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2591 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x4c/0x15c arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); lock(&rm->m_rs_lock); lock(&rs->rs_recv_lock); *** DEADLOCK *** 3 locks held by syz-executor135/5975: #0: ffff0000d68a56f0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1697 [inline] #0: ffff0000d68a56f0 (k-sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_sock_set_cork+0x38/0x188 net/ipv4/tcp.c:3342 #1: ffff0000d68a5978 (k-clock-AF_INET){++.-}-{2:2}, at: rds_tcp_write_space+0x38/0x594 net/rds/tcp_send.c:184 #2: ffff0000c93bc900 (&rm->m_rs_lock){....}-{2:2}, at: rds_send_remove_from_sock+0x134/0x78c net/rds/send.c:628 stack backtrace: CPU: 1 PID: 5975 Comm: syz-executor135 Not tainted 6.3.0-rc7-syzkaller-g14f8db1c0f9a #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:233 show_stack+0x2c/0x44 arch/arm64/kernel/stacktrace.c:240 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x238/0x718 kernel/locking/lockdep.c:5669 __raw_read_lock_irqsave include/linux/rwlock_api_smp.h:160 [inline] _raw_read_lock_irqsave+0x6c/0x8c kernel/locking/spinlock.c:236 rds_wake_sk_sleep+0x34/0xc8 net/rds/af_rds.c:109 rds_send_remove_from_sock+0x1a4/0x78c net/rds/send.c:634 rds_send_path_drop_acked+0x390/0x3f0 net/rds/send.c:710 rds_tcp_write_space+0x1a8/0x594 net/rds/tcp_send.c:198 tcp_new_space net/ipv4/tcp_input.c:5483 [inline] tcp_check_space+0x150/0x888 net/ipv4/tcp_input.c:5502 tcp_data_snd_check net/ipv4/tcp_input.c:5511 [inline] tcp_rcv_established+0xdc0/0x1ee0 net/ipv4/tcp_input.c:6019 tcp_v4_do_rcv+0x388/0xd8c net/ipv4/tcp_ipv4.c:1721 sk_backlog_rcv include/net/sock.h:1113 [inline] __release_sock+0x1a8/0x408 net/core/sock.c:2922 release_sock+0x68/0x1b0 net/core/sock.c:3489 tcp_sock_set_cork+0x100/0x188 net/ipv4/tcp.c:3344 rds_tcp_xmit_path_complete+0x7c/0x8c net/rds/tcp_send.c:52 rds_send_xmit+0x1978/0x22a0 net/rds/send.c:422 rds_sendmsg+0x1608/0x1bc8 net/rds/send.c:1381 sock_sendmsg_nosec net/socket.c:724 [inline] sock_sendmsg net/socket.c:747 [inline] ____sys_sendmsg+0x568/0x81c net/socket.c:2501 ___sys_sendmsg net/socket.c:2555 [inline] __sys_sendmsg+0x26c/0x33c net/socket.c:2584 __do_sys_sendmsg net/socket.c:2593 [inline] __se_sys_sendmsg net/socket.c:2591 [inline] __arm64_sys_sendmsg+0x80/0x94 net/socket.c:2591 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x4c/0x15c arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591