====================================================== WARNING: possible circular locking dependency detected 6.12.0-rc1-syzkaller-g3eddb108abe3 #0 Not tainted ------------------------------------------------------ syz.4.195/7574 is trying to acquire lock: ffff0000d8b22610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x3c4/0xa8c fs/ocfs2/quota_global.c:855 but task is already holding lock: ffff0000df786a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x268/0xa8c fs/ocfs2/quota_global.c:823 dqget+0x660/0xcec fs/quota/dquot.c:976 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1504 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1566 ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202 ocfs2_symlink+0x7a4/0x24d8 fs/ocfs2/namei.c:1886 vfs_symlink+0x138/0x28c fs/namei.c:4615 do_symlinkat+0x1bc/0x45c fs/namei.c:4641 __do_sys_symlinkat fs/namei.c:4657 [inline] __se_sys_symlinkat fs/namei.c:4654 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4654 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:815 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x268/0xa8c fs/ocfs2/quota_global.c:823 dqget+0x660/0xcec fs/quota/dquot.c:976 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1504 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1566 ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202 ocfs2_symlink+0x7a4/0x24d8 fs/ocfs2/namei.c:1886 vfs_symlink+0x138/0x28c fs/namei.c:4615 do_symlinkat+0x1bc/0x45c fs/namei.c:4641 __do_sys_symlinkat fs/namei.c:4657 [inline] __se_sys_symlinkat fs/namei.c:4654 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4654 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #4 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 wait_on_dquot fs/quota/dquot.c:355 [inline] dqget+0x5f0/0xcec fs/quota/dquot.c:971 dquot_transfer+0x3a8/0x5c0 fs/quota/dquot.c:2153 ext4_setattr+0x8bc/0x1624 fs/ext4/inode.c:5368 notify_change+0x9f0/0xca0 fs/attr.c:503 chown_common+0x438/0x700 fs/open.c:793 vfs_fchown fs/open.c:861 [inline] ksys_fchown+0xe0/0x158 fs/open.c:872 __do_sys_fchown fs/open.c:880 [inline] __se_sys_fchown fs/open.c:878 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:878 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #3 (&ei->xattr_sem){++++}-{3:3}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline] ext4_xattr_set_handle+0x1dc/0x12d0 fs/ext4/xattr.c:2373 ext4_initxattrs+0xa4/0x11c fs/ext4/xattr_security.c:44 security_inode_init_security+0x73c/0x908 security/security.c:1846 ext4_init_security+0x44/0x58 fs/ext4/xattr_security.c:58 __ext4_new_inode+0x2be8/0x3830 fs/ext4/ialloc.c:1323 ext4_create+0x234/0x480 fs/ext4/namei.c:2834 lookup_open fs/namei.c:3595 [inline] open_last_lookups fs/namei.c:3694 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3930 do_filp_open+0x1bc/0x3cc fs/namei.c:3960 do_sys_openat2+0x124/0x1b8 fs/open.c:1415 do_sys_open fs/open.c:1430 [inline] __do_sys_openat fs/open.c:1446 [inline] __se_sys_openat fs/open.c:1441 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1441 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4288 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_mknod+0xdc8/0x243c fs/ocfs2/namei.c:345 ocfs2_mkdir+0x194/0x4e0 fs/ocfs2/namei.c:655 vfs_mkdir+0x27c/0x410 fs/namei.c:4257 do_mkdirat+0x248/0x574 fs/namei.c:4280 __do_sys_mkdirat fs/namei.c:4295 [inline] __se_sys_mkdirat fs/namei.c:4293 [inline] __arm64_sys_mkdirat+0x8c/0xa4 fs/namei.c:4293 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #1 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4288 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_mknod+0xdc8/0x243c fs/ocfs2/namei.c:345 ocfs2_mkdir+0x194/0x4e0 fs/ocfs2/namei.c:655 vfs_mkdir+0x27c/0x410 fs/namei.c:4257 do_mkdirat+0x248/0x574 fs/namei.c:4280 __do_sys_mkdirat fs/namei.c:4295 [inline] __se_sys_mkdirat fs/namei.c:4293 [inline] __arm64_sys_mkdirat+0x8c/0xa4 fs/namei.c:4293 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #0 (sb_internal#2){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x33f8/0x77c8 kernel/locking/lockdep.c:5202 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5825 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1716 [inline] sb_start_intwrite include/linux/fs.h:1899 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x3c4/0xa8c fs/ocfs2/quota_global.c:855 dqget+0x660/0xcec fs/quota/dquot.c:976 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1504 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1566 ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202 ocfs2_symlink+0x7a4/0x24d8 fs/ocfs2/namei.c:1886 vfs_symlink+0x138/0x28c fs/namei.c:4615 do_symlinkat+0x1bc/0x45c fs/namei.c:4641 __do_sys_symlinkat fs/namei.c:4657 [inline] __se_sys_symlinkat fs/namei.c:4654 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4654 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 other info that might help us debug this: Chain exists of: sb_internal#2 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); rlock(sb_internal#2); *** DEADLOCK *** 6 locks held by syz.4.195/7574: #0: ffff0000d8b22420 (sb_writers#14){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:515 #1: ffff0000f18ab480 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:850 [inline] #1: ffff0000f18ab480 (&type->i_mutex_dir_key#8/1){+.+.}-{3:3}, at: filename_create+0x204/0x468 fs/namei.c:4026 #2: ffff0000df7809c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline] #2: ffff0000df7809c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x164/0x4288 fs/ocfs2/suballoc.c:786 #3: ffff0000db31e0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x25c/0xa8c fs/ocfs2/quota_global.c:818 #4: ffff0000df786d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline] #4: ffff0000df786d80 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 #5: ffff0000df786a20 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 1 UID: 0 PID: 7574 Comm: syz.4.195 Not tainted 6.12.0-rc1-syzkaller-g3eddb108abe3 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:319 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:326 __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x33f8/0x77c8 kernel/locking/lockdep.c:5202 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5825 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1716 [inline] sb_start_intwrite include/linux/fs.h:1899 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x3c4/0xa8c fs/ocfs2/quota_global.c:855 dqget+0x660/0xcec fs/quota/dquot.c:976 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1504 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1566 ocfs2_get_init_inode+0x14c/0x1b8 fs/ocfs2/namei.c:202 ocfs2_symlink+0x7a4/0x24d8 fs/ocfs2/namei.c:1886 vfs_symlink+0x138/0x28c fs/namei.c:4615 do_symlinkat+0x1bc/0x45c fs/namei.c:4641 __do_sys_symlinkat fs/namei.c:4657 [inline] __se_sys_symlinkat fs/namei.c:4654 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4654 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 (syz.4.195,7574,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0x4e60244d, computed 0x36fa8088. Applying ECC. (syz.4.195,7574,0):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0x4e60244d, computed 0x26885ba0 (syz.4.195,7574,0):ocfs2_search_chain:1814 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_search_chain:1926 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_claim_suballoc_bits:1995 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_claim_suballoc_bits:2038 ERROR: status = -5 (syz.4.195,7574,0):__ocfs2_claim_clusters:2412 ERROR: status = -5 (syz.4.195,7574,0):__ocfs2_claim_clusters:2420 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_block_group_alloc_contig:437 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_block_group_alloc:709 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_block_group_alloc:762 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_reserve_suballoc_bits:837 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_reserve_suballoc_bits:854 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_reserve_new_metadata_blocks:994 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_reserve_new_metadata_blocks:1017 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_calc_security_init:592 ERROR: status = -5 (syz.4.195,7574,0):ocfs2_symlink:1910 ERROR: status = -5 (syz.4.195,7574,1):ocfs2_symlink:2076 ERROR: status = -5