ntfs3: loop3: ino=0, attr_set_size ====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc5-syzkaller-00072-g401644852d0b #0 Not tainted ------------------------------------------------------ syz-executor.3/10624 is trying to acquire lock: ffff888079a50fc0 (&ni->ni_lock#3){+.+.}-{3:3}, at: ntfs_set_state+0x212/0x730 fs/ntfs3/fsntfs.c:946 but task is already holding lock: ffff888079a51f30 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:511 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->file.run_lock#2){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:511 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ntfs_create_inode+0x519/0x3b00 fs/ntfs3/inode.c:1310 ntfs_atomic_open+0x423/0x570 fs/ntfs3/namei.c:422 atomic_open fs/namei.c:3358 [inline] lookup_open fs/namei.c:3466 [inline] open_last_lookups fs/namei.c:3563 [inline] path_openat+0x1044/0x3180 fs/namei.c:3793 do_filp_open+0x234/0x490 fs/namei.c:3823 do_sys_openat2+0x13e/0x1d0 fs/open.c:1422 do_sys_open fs/open.c:1437 [inline] __do_sys_openat fs/open.c:1453 [inline] __se_sys_openat fs/open.c:1448 [inline] __x64_sys_openat+0x247/0x290 fs/open.c:1448 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&wnd->rw_lock/1){+.+.}-{3:3}: down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x3f/0x2b0 fs/ntfs3/fsntfs.c:742 ni_write_inode+0x54f/0x1070 fs/ntfs3/frecord.c:3353 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0x69b/0xfa0 fs/fs-writeback.c:1673 writeback_sb_inodes+0x8e3/0x1210 fs/fs-writeback.c:1899 wb_writeback+0x44d/0xc60 fs/fs-writeback.c:2075 wb_do_writeback fs/fs-writeback.c:2222 [inline] wb_workfn+0x400/0xff0 fs/fs-writeback.c:2262 process_one_work kernel/workqueue.c:2630 [inline] process_scheduled_works+0x90f/0x1400 kernel/workqueue.c:2703 worker_thread+0xa5f/0xff0 kernel/workqueue.c:2784 kthread+0x2d3/0x370 kernel/kthread.c:388 ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #0 (&ni->ni_lock#3){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ntfs_set_state+0x212/0x730 fs/ntfs3/fsntfs.c:946 attr_set_size+0x3311/0x4290 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x2fa/0x4b0 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x9bd/0x1480 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x365/0xbe0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xabc/0x16c0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x14f/0x500 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x916/0xae0 fs/ntfs3/file.c:708 notify_change+0xb99/0xe60 fs/attr.c:499 chmod_common+0x2ab/0x4c0 fs/open.c:643 do_fchmodat fs/open.c:691 [inline] __do_sys_chmod fs/open.c:715 [inline] __se_sys_chmod fs/open.c:713 [inline] __x64_sys_chmod+0x100/0x1a0 fs/open.c:713 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ni->ni_lock#3 --> &wnd->rw_lock/1 --> &ni->file.run_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->file.run_lock#2); lock(&wnd->rw_lock/1); lock(&ni->file.run_lock#2); lock(&ni->ni_lock#3); *** DEADLOCK *** 5 locks held by syz-executor.3/10624: #0: ffff8880309ec410 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:403 #1: ffff888035018b00 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff888035018b00 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: chmod_common+0x1bb/0x4c0 fs/open.c:637 #2: ffff888035018860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] #2: ffff888035018860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_save_wsl_perm+0x8f/0x500 fs/ntfs3/xattr.c:944 #3: ffff8880309ee120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_look_free_mft+0x1e5/0x10c0 fs/ntfs3/fsntfs.c:571 #4: ffff888079a51f30 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x160/0x4b0 fs/ntfs3/fsntfs.c:511 stack backtrace: CPU: 0 PID: 10624 Comm: syz-executor.3 Not tainted 6.6.0-rc5-syzkaller-00072-g401644852d0b #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ntfs_set_state+0x212/0x730 fs/ntfs3/fsntfs.c:946 attr_set_size+0x3311/0x4290 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x2fa/0x4b0 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x43d/0x10c0 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0x9bd/0x1480 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x365/0xbe0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x358/0x900 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xf8/0x3c0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xabc/0x16c0 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x14f/0x500 fs/ntfs3/xattr.c:946 ntfs3_setattr+0x916/0xae0 fs/ntfs3/file.c:708 notify_change+0xb99/0xe60 fs/attr.c:499 chmod_common+0x2ab/0x4c0 fs/open.c:643 do_fchmodat fs/open.c:691 [inline] __do_sys_chmod fs/open.c:715 [inline] __se_sys_chmod fs/open.c:713 [inline] __x64_sys_chmod+0x100/0x1a0 fs/open.c:713 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f955ac7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f955ba040c8 EFLAGS: 00000246 ORIG_RAX: 000000000000005a RAX: ffffffffffffffda RBX: 00007f955ad9bf80 RCX: 00007f955ac7cae9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000200 RBP: 00007f955acc847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f955ad9bf80 R15: 00007ffdbdab4468 ntfs3: loop3: Mark volume as dirty due to NTFS errors