====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc1-syzkaller-gfe15c26ee26e #0 Not tainted ------------------------------------------------------ syz-executor.0/22303 is trying to acquire lock: ffff0000d8e02170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x260/0x324 fs/jbd2/transaction.c:904 but task is already holding lock: ffff0000d89feb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x154/0x618 fs/ext4/inode.c:6155 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_write+0x78/0x2e0 kernel/locking/percpu-rwsem.c:227 ext4_ind_migrate+0x174/0x6e4 fs/ext4/migrate.c:624 ext4_ioctl_setflags fs/ext4/ioctl.c:693 [inline] ext4_fileattr_set+0xbd0/0x12d0 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x70c/0xad4 fs/ioctl.c:696 do_vfs_ioctl+0x14cc/0x26f8 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x5c/0x78 kernel/locking/rwsem.c:1520 inode_lock_shared include/linux/fs.h:768 [inline] ext4_bmap+0x58/0x35c fs/ext4/inode.c:3242 bmap+0xa8/0xe8 fs/inode.c:1799 jbd2_journal_bmap fs/jbd2/journal.c:976 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1788 [inline] jbd2_journal_flush+0x4c0/0xa60 fs/jbd2/journal.c:2491 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1079 [inline] __ext4_ioctl fs/ext4/ioctl.c:1587 [inline] ext4_ioctl+0x3860/0x6f58 fs/ext4/ioctl.c:1607 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 mutex_lock_io_nested+0x6c/0x88 kernel/locking/mutex.c:833 jbd2_journal_flush+0x210/0xa60 fs/jbd2/journal.c:2463 __ext4_ioctl fs/ext4/ioctl.c:1299 [inline] ext4_ioctl+0x3b28/0x6f58 fs/ext4/ioctl.c:1607 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 -> #0 (&journal->j_barrier){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x2f0/0x8c8 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x260/0x324 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x15c/0x618 fs/ext4/inode.c:6156 ext4_ioctl_setflags fs/ext4/ioctl.c:684 [inline] ext4_fileattr_set+0xb5c/0x12d0 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x70c/0xad4 fs/ioctl.c:696 do_vfs_ioctl+0x14cc/0x26f8 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591 other info that might help us debug this: Chain exists of: &journal->j_barrier --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(&journal->j_barrier); *** DEADLOCK *** 4 locks held by syz-executor.0/22303: #0: ffff0000d89fc460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:438 #1: ffff00013037e850 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff00013037e850 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: vfs_fileattr_set+0x110/0xad4 fs/ioctl.c:681 #2: ffff00013037e9f0 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:803 [inline] #2: ffff00013037e9f0 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0xf0/0x618 fs/ext4/inode.c:6147 #3: ffff0000d89feb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x154/0x618 fs/ext4/inode.c:6155 stack backtrace: CPU: 1 PID: 22303 Comm: syz-executor.0 Not tainted 6.3.0-rc1-syzkaller-gfe15c26ee26e #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd0/0x124 lib/dump_stack.c:106 dump_stack+0x1c/0x28 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x2f0/0x8c8 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x260/0x324 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x15c/0x618 fs/ext4/inode.c:6156 ext4_ioctl_setflags fs/ext4/ioctl.c:684 [inline] ext4_fileattr_set+0xb5c/0x12d0 fs/ext4/ioctl.c:1001 vfs_fileattr_set+0x70c/0xad4 fs/ioctl.c:696 do_vfs_ioctl+0x14cc/0x26f8 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x198 arch/arm64/kernel/syscall.c:193 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:591