====================================================== WARNING: possible circular locking dependency detected 6.1.119-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.369/6623 is trying to acquire lock: ffff0000fc1f4ae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xbc/0x664 fs/gfs2/quota.c:682 but task is already holding lock: ffff0000e1062780 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1512 [inline] ffff0000e1062780 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1fb0/0x2fe8 fs/gfs2/bmap.c:1837 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 __gfs2_iomap_get+0x138/0x1058 fs/gfs2/bmap.c:856 gfs2_iomap_get+0xd8/0x154 fs/gfs2/bmap.c:1396 bh_get+0x208/0x6ac fs/gfs2/quota.c:385 qdsb_get+0x1e0/0x398 fs/gfs2/quota.c:522 gfs2_quota_hold+0x16c/0x558 fs/gfs2/quota.c:608 gfs2_quota_lock+0xbc/0x404 fs/gfs2/quota.c:1076 setattr_chown+0x218/0x564 fs/gfs2/inode.c:1929 gfs2_setattr+0x208/0x3ac fs/gfs2/inode.c:2004 notify_change+0xb58/0xe1c fs/attr.c:499 chown_common+0x4e8/0x7d8 fs/open.c:736 vfs_fchown fs/open.c:804 [inline] ksys_fchown+0xe0/0x158 fs/open.c:815 __do_sys_fchown fs/open.c:823 [inline] __se_sys_fchown fs/open.c:821 [inline] __arm64_sys_fchown+0x7c/0x94 fs/open.c:821 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2bc arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x58/0x13c arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xbc/0x664 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 punch_hole+0x2aa8/0x2fe8 fs/gfs2/bmap.c:1938 gfs2_file_dealloc+0x28/0x38 fs/gfs2/bmap.c:2160 evict_unlinked_inode+0x18c/0x72c fs/gfs2/super.c:1398 gfs2_evict_inode+0x970/0xf44 fs/gfs2/super.c:1497 evict+0x418/0x894 fs/inode.c:701 iput_final fs/inode.c:1830 [inline] iput+0x7c0/0x8a4 fs/inode.c:1856 dentry_unlink_inode+0x37c/0x4bc fs/dcache.c:405 __dentry_kill+0x324/0x5e4 fs/dcache.c:611 dentry_kill+0xc8/0x250 dput+0x218/0x454 fs/dcache.c:918 __fput+0x488/0x7c8 fs/file_table.c:328 ____fput+0x20/0x30 fs/file_table.c:348 task_work_run+0x240/0x2f0 kernel/task_work.c:203 exit_task_work include/linux/task_work.h:39 [inline] do_exit+0x554/0x1a88 kernel/exit.c:871 do_group_exit+0x194/0x22c kernel/exit.c:1021 get_signal+0x14a0/0x158c kernel/signal.c:2871 do_signal arch/arm64/kernel/signal.c:1076 [inline] do_notify_resume+0x2f8/0x2cb8 arch/arm64/kernel/signal.c:1129 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_da+0xb8/0x184 arch/arm64/kernel/entry-common.c:516 el0t_64_sync_handler+0xcc/0xf0 arch/arm64/kernel/entry-common.c:658 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 3 locks held by syz.4.369/6623: #0: ffff0000dcabc650 (sb_internal#4){.+.+}-{0:0}, at: gfs2_trans_begin+0xa8/0x11c fs/gfs2/trans.c:118 #1: ffff0000fc1f5058 (&sdp->sd_log_flush_lock){++++}-{3:3}, at: __gfs2_trans_begin+0x524/0x91c fs/gfs2/trans.c:87 #2: ffff0000e1062780 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1512 [inline] #2: ffff0000e1062780 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1fb0/0x2fe8 fs/gfs2/bmap.c:1837 stack backtrace: CPU: 1 PID: 6623 Comm: syz.4.369 Not tainted 6.1.119-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xbc/0x664 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 punch_hole+0x2aa8/0x2fe8 fs/gfs2/bmap.c:1938 gfs2_file_dealloc+0x28/0x38 fs/gfs2/bmap.c:2160 evict_unlinked_inode+0x18c/0x72c fs/gfs2/super.c:1398 gfs2_evict_inode+0x970/0xf44 fs/gfs2/super.c:1497 evict+0x418/0x894 fs/inode.c:701 iput_final fs/inode.c:1830 [inline] iput+0x7c0/0x8a4 fs/inode.c:1856 dentry_unlink_inode+0x37c/0x4bc fs/dcache.c:405 __dentry_kill+0x324/0x5e4 fs/dcache.c:611 dentry_kill+0xc8/0x250 dput+0x218/0x454 fs/dcache.c:918 __fput+0x488/0x7c8 fs/file_table.c:328 ____fput+0x20/0x30 fs/file_table.c:348 task_work_run+0x240/0x2f0 kernel/task_work.c:203 exit_task_work include/linux/task_work.h:39 [inline] do_exit+0x554/0x1a88 kernel/exit.c:871 do_group_exit+0x194/0x22c kernel/exit.c:1021 get_signal+0x14a0/0x158c kernel/signal.c:2871 do_signal arch/arm64/kernel/signal.c:1076 [inline] do_notify_resume+0x2f8/0x2cb8 arch/arm64/kernel/signal.c:1129 prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:137 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:142 [inline] el0_da+0xb8/0x184 arch/arm64/kernel/entry-common.c:516 el0t_64_sync_handler+0xcc/0xf0 arch/arm64/kernel/entry-common.c:658 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585