loop3: detected capacity change from 0 to 1024 ====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc2-syzkaller-00029-g9b6de136b5f0 #0 Not tainted ------------------------------------------------------ syz-executor.3/15436 is trying to acquire lock: ffff8880391658f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff888024df3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2da/0xb40 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x474/0xea0 fs/buffer.c:2399 filemap_read_folio+0x19c/0x780 mm/filemap.c:2323 do_read_cache_folio+0x134/0x810 mm/filemap.c:3691 do_read_cache_page+0x30/0x200 mm/filemap.c:3757 read_mapping_page include/linux/pagemap.h:854 [inline] hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x54d/0x1ad0 fs/buffer.c:2119 __block_write_begin fs/buffer.c:2168 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2227 cont_write_begin+0x643/0x880 fs/buffer.c:2582 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52 cont_expand_zero fs/buffer.c:2542 [inline] cont_write_begin+0x6e5/0x880 fs/buffer.c:2572 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52 generic_perform_write+0x31b/0x630 mm/filemap.c:3918 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4039 do_iter_readv_writev+0x330/0x4a0 do_iter_write+0x1f6/0x8d0 fs/read_write.c:860 vfs_writev fs/read_write.c:933 [inline] do_pwritev+0x21a/0x360 fs/read_write.c:1030 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e4/0x59f0 kernel/locking/lockdep.c:3868 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7d0/0xb40 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x174/0x220 hfsplus_unlink+0x512/0x790 fs/hfsplus/dir.c:405 hfsplus_rename+0xc8/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xaba/0xde0 fs/namei.c:4844 do_renameat2+0xd5a/0x1390 fs/namei.c:4996 __do_sys_renameat2 fs/namei.c:5029 [inline] __se_sys_renameat2 fs/namei.c:5026 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:5026 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 6 locks held by syz-executor.3/15436: #0: ffff88801a7cc418 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:404 #1: ffff888024df6180 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #1: ffff888024df6180 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3046 [inline] #1: ffff888024df6180 (&type->i_mutex_dir_key#12/1){+.+.}-{3:3}, at: do_renameat2+0x601/0x1390 fs/namei.c:4935 #2: ffff888024df2b80 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:837 [inline] #2: ffff888024df2b80 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: lock_two_inodes+0x100/0x180 fs/inode.c:1127 #3: ffff888024df3900 (&sb->s_type->i_mutex_key#25/4){+.+.}-{3:3}, at: vfs_rename+0x5eb/0xde0 fs/namei.c:4816 #4: ffff888039165998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x161/0x790 fs/hfsplus/dir.c:370 #5: ffff888024df3708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2da/0xb40 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 15436 Comm: syz-executor.3 Not tainted 6.7.0-rc2-syzkaller-00029-g9b6de136b5f0 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e4/0x59f0 kernel/locking/lockdep.c:3868 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7d0/0xb40 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x174/0x220 hfsplus_unlink+0x512/0x790 fs/hfsplus/dir.c:405 hfsplus_rename+0xc8/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xaba/0xde0 fs/namei.c:4844 do_renameat2+0xd5a/0x1390 fs/namei.c:4996 __do_sys_renameat2 fs/namei.c:5029 [inline] __se_sys_renameat2 fs/namei.c:5026 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:5026 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f5c8ac7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f5c8b9390c8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007f5c8ad9bf80 RCX: 00007f5c8ac7cae9 RDX: 0000000000000004 RSI: 00000000200001c0 RDI: 0000000000000004 RBP: 00007f5c8acc847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020000140 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f5c8ad9bf80 R15: 00007ffde888aa18 hfsplus: unable to mark blocks free: error -4 hfsplus: can't free extent