====================================================== WARNING: possible circular locking dependency detected 4.14.215-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/32630 is trying to acquire lock: (&ovl_i_mutex_dir_key[depth]){++++}, at: [] inode_lock_shared include/linux/fs.h:729 [inline] (&ovl_i_mutex_dir_key[depth]){++++}, at: [] lookup_slow+0x129/0x400 fs/namei.c:1674 but task is already holding lock: (&oi->lock){+.+.}, at: [] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&oi->lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:756 [inline] __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893 ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318 ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:630 ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:685 ovl_rename+0x164/0xf10 fs/overlayfs/dir.c:939 vfs_rename+0x560/0x1820 fs/namei.c:4496 SYSC_renameat2 fs/namei.c:4644 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4533 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #1 (sb_writers#3){.+.+}: percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline] percpu_down_read include/linux/percpu-rwsem.h:59 [inline] __sb_start_write+0x64/0x260 fs/super.c:1342 sb_start_write include/linux/fs.h:1549 [inline] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 ovl_create_object+0x75/0x1d0 fs/overlayfs/dir.c:538 lookup_open+0x77a/0x1750 fs/namei.c:3241 do_last fs/namei.c:3334 [inline] path_openat+0xe08/0x2970 fs/namei.c:3569 do_filp_open+0x179/0x3c0 fs/namei.c:3603 do_sys_open+0x296/0x410 fs/open.c:1081 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb -> #0 (&ovl_i_mutex_dir_key[depth]){++++}: lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_read+0x36/0x80 kernel/locking/rwsem.c:24 inode_lock_shared include/linux/fs.h:729 [inline] lookup_slow+0x129/0x400 fs/namei.c:1674 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595 ovl_lower_positive+0x184/0x345 fs/overlayfs/namei.c:783 ovl_rename+0x47c/0xf10 fs/overlayfs/dir.c:968 vfs_rename+0x560/0x1820 fs/namei.c:4496 SYSC_renameat2 fs/namei.c:4644 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4533 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb other info that might help us debug this: Chain exists of: &ovl_i_mutex_dir_key[depth] --> sb_writers#3 --> &oi->lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->lock); lock(sb_writers#3); lock(&oi->lock); lock(&ovl_i_mutex_dir_key[depth]); *** DEADLOCK *** 8 locks held by syz-executor.0/32630: #0: (sb_writers#22){.+.+}, at: [] sb_start_write include/linux/fs.h:1549 [inline] #0: (sb_writers#22){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #1: (&type->s_vfs_rename_key#3){+.+.}, at: [] lock_rename+0x54/0x280 fs/namei.c:2889 #2: (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #2: (&ovl_i_mutex_dir_key[depth]#2/1){+.+.}, at: [] lock_rename+0xa0/0x280 fs/namei.c:2893 #3: (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #3: (&ovl_i_mutex_dir_key[depth]#2/2){+.+.}, at: [] lock_rename+0xd4/0x280 fs/namei.c:2894 #4: (&ovl_i_mutex_key[depth]#2){+.+.}, at: [] inode_lock include/linux/fs.h:719 [inline] #4: (&ovl_i_mutex_key[depth]#2){+.+.}, at: [] lock_two_nondirectories+0xca/0xf0 fs/inode.c:990 #5: (&ovl_i_mutex_key[depth]#2/4){+.+.}, at: [] inode_lock_nested include/linux/fs.h:754 [inline] #5: (&ovl_i_mutex_key[depth]#2/4){+.+.}, at: [] lock_two_nondirectories+0xb2/0xf0 fs/inode.c:992 #6: (sb_writers#3){.+.+}, at: [] sb_start_write include/linux/fs.h:1549 [inline] #6: (sb_writers#3){.+.+}, at: [] mnt_want_write+0x3a/0xb0 fs/namespace.c:386 #7: (&oi->lock){+.+.}, at: [] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523 stack backtrace: CPU: 0 PID: 32630 Comm: syz-executor.0 Not tainted 4.14.215-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:17 [inline] dump_stack+0x1b2/0x283 lib/dump_stack.c:58 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258 check_prev_add kernel/locking/lockdep.c:1905 [inline] check_prevs_add kernel/locking/lockdep.c:2022 [inline] validate_chain kernel/locking/lockdep.c:2464 [inline] __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998 down_read+0x36/0x80 kernel/locking/rwsem.c:24 inode_lock_shared include/linux/fs.h:729 [inline] lookup_slow+0x129/0x400 fs/namei.c:1674 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595 ovl_lower_positive+0x184/0x345 fs/overlayfs/namei.c:783 ovl_rename+0x47c/0xf10 fs/overlayfs/dir.c:968 vfs_rename+0x560/0x1820 fs/namei.c:4496 SYSC_renameat2 fs/namei.c:4644 [inline] SyS_renameat2+0x95b/0xad0 fs/namei.c:4533 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292 entry_SYSCALL_64_after_hwframe+0x46/0xbb RIP: 0033:0x45e219 RSP: 002b:00007f8cf0230c68 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 0000000000000002 RCX: 000000000045e219 RDX: 0000000000000000 RSI: 0000000020000440 RDI: 0000000020000380 RBP: 000000000119bfb8 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 000000000119bf8c R13: 00007fff1419a7cf R14: 00007f8cf02319c0 R15: 000000000119bf8c overlayfs: invalid redirect (./file0) overlayfs: fs on '.' does not support file handles, falling back to index=off. sd 0:0:1:0: PR command failed: 134217730 sd 0:0:1:0: Sense Key : Illegal Request [current] overlayfs: maximum fs stacking depth exceeded sd 0:0:1:0: Add. Sense: Invalid command operation code overlayfs: filesystem on './bus' not supported as upperdir overlayfs: fs on 'file0' does not support file handles, falling back to index=off. sd 0:0:1:0: PR command failed: 134217730 sd 0:0:1:0: Sense Key : Illegal Request [current] sd 0:0:1:0: Add. Sense: Invalid command operation code overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: invalid redirect (./file0) overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. overlayfs: invalid redirect (./file0) overlayfs: fs on 'file0' does not support file handles, falling back to index=off. overlayfs: fs on './file0' does not support file handles, falling back to index=off. audit: type=1804 audit(1610884486.778:248): pid=589 uid=0 auid=0 ses=4 op="invalid_pcr" cause="open_writers" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/27/bus" dev="sda1" ino=16053 res=1 audit: type=1804 audit(1610884486.778:249): pid=589 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/27/bus" dev="sda1" ino=16053 res=1 audit: type=1804 audit(1610884486.858:250): pid=598 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/27/bus" dev="sda1" ino=16053 res=1 xt_connbytes: cannot load conntrack support for proto=10 audit: type=1804 audit(1610884486.918:251): pid=589 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/27/bus" dev="sda1" ino=16053 res=1 xt_connbytes: Forcing CT accounting to be enabled audit: type=1804 audit(1610884486.948:252): pid=598 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/27/bus" dev="sda1" ino=16053 res=1 cannot load conntrack support for proto=10 audit: type=1804 audit(1610884487.578:253): pid=637 uid=0 auid=0 ses=4 op="invalid_pcr" cause="open_writers" comm="syz-executor.5" name="bus" dev="sda1" ino=16020 res=1 audit: type=1804 audit(1610884487.588:254): pid=625 uid=0 auid=0 ses=4 op="invalid_pcr" cause="open_writers" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/28/bus" dev="sda1" ino=16004 res=1 audit: type=1804 audit(1610884487.608:255): pid=625 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.1" name="/root/syzkaller-testdir385322207/syzkaller.pogAMC/28/bus" dev="sda1" ino=16004 res=1 audit: type=1804 audit(1610884487.678:256): pid=627 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.5" name="bus" dev="sda1" ino=16020 res=1 audit: type=1804 audit(1610884487.718:257): pid=627 uid=0 auid=0 ses=4 op="invalid_pcr" cause="ToMToU" comm="syz-executor.5" name="bus" dev="sda1" ino=16020 res=1 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: unknown main item tag 0x0 hid-generic 0000:0000:0000.0001: hidraw0: HID v0.00 Device [syz1] on syz1 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x3 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x3 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x3 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: unknown main item tag 0x2 hid-generic 0000:0000:0000.0002: item fetching failed at offset 42/43 hid-generic: probe of 0000:0000:0000.0002 failed with error -22 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: unknown main item tag 0x0 hid-generic 0000:0000:0000.0003: hidraw0: HID v0.00 Device [syz1] on syz1 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: unknown main item tag 0x0 hid-generic 0000:0000:0000.0004: hidraw0: HID v0.00 Device [syz1] on syz1 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0 hid-generic 0000:0000:0000.0005: unknown main item tag 0x0