====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-00026-g59dbb9d81adf #0 Not tainted ------------------------------------------------------ syz-executor/27209 is trying to acquire lock: ffff88807ab047e0 (&ei->i_data_sem/2){++++}-{4:4}, at: ext4_map_blocks+0x3be/0x1990 fs/ext4/inode.c:665 but task is already holding lock: ffff888045f96210 (&s->s_dquot.dqio_sem){++++}-{4:4}, at: v2_write_dquot+0xab/0x270 fs/quota/quota_v2.c:367 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #7 (&s->s_dquot.dqio_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_mark_dquot_dirty+0x609/0xe00 fs/ocfs2/quota_global.c:961 mark_dquot_dirty fs/quota/dquot.c:370 [inline] do_set_dqblk fs/quota/dquot.c:2808 [inline] dquot_set_dqblk+0xcf5/0xf30 fs/quota/dquot.c:2825 quota_setquota+0x6de/0x850 fs/quota/quota.c:310 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl+0x2c4/0xa30 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #6 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 __ext4_journal_start_sb+0x239/0x600 fs/ext4/ext4_jbd2.c:112 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_dirty_inode+0x92/0x110 fs/ext4/inode.c:6038 __mark_inode_dirty+0x2f0/0xe90 fs/fs-writeback.c:2515 generic_update_time fs/inode.c:2112 [inline] inode_update_time fs/inode.c:2125 [inline] touch_atime+0x413/0x690 fs/inode.c:2197 file_accessed include/linux/fs.h:2539 [inline] ext4_file_mmap+0x18c/0x540 fs/ext4/file.c:816 call_mmap include/linux/fs.h:2183 [inline] mmap_file mm/internal.h:124 [inline] __mmap_new_file_vma mm/vma.c:2291 [inline] __mmap_new_vma mm/vma.c:2355 [inline] __mmap_region+0x2206/0x2cd0 mm/vma.c:2456 mmap_region+0x226/0x2c0 mm/mmap.c:1348 do_mmap+0x8f0/0x1000 mm/mmap.c:496 vm_mmap_pgoff+0x1dd/0x3d0 mm/util.c:580 ksys_mmap_pgoff+0x4eb/0x720 mm/mmap.c:542 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #5 (&mm->mmap_lock){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __might_fault+0xc6/0x120 mm/memory.c:6751 _inline_copy_from_user include/linux/uaccess.h:162 [inline] _copy_from_user+0x2a/0xc0 lib/usercopy.c:18 copy_from_user include/linux/uaccess.h:212 [inline] __blk_trace_setup kernel/trace/blktrace.c:626 [inline] blk_trace_setup+0xd2/0x1e0 kernel/trace/blktrace.c:648 sg_ioctl_common drivers/scsi/sg.c:1114 [inline] sg_ioctl+0xa46/0x2e80 drivers/scsi/sg.c:1156 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf7/0x170 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #4 (&q->debugfs_mutex){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 blk_mq_init_sched+0x3fa/0x830 block/blk-mq-sched.c:473 elevator_init_mq+0x20e/0x320 block/elevator.c:610 add_disk_fwnode+0x10d/0xf80 block/genhd.c:413 sd_probe+0xba6/0x1100 drivers/scsi/sd.c:4024 really_probe+0x2ba/0xad0 drivers/base/dd.c:658 __driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800 driver_probe_device+0x50/0x430 drivers/base/dd.c:830 __device_attach_driver+0x2d6/0x530 drivers/base/dd.c:958 bus_for_each_drv+0x250/0x2e0 drivers/base/bus.c:459 __device_attach_async_helper+0x22d/0x300 drivers/base/dd.c:987 async_run_entry_fn+0xaa/0x420 kernel/async.c:129 process_one_work kernel/workqueue.c:3229 [inline] process_scheduled_works+0xa68/0x1840 kernel/workqueue.c:3310 worker_thread+0x870/0xd30 kernel/workqueue.c:3391 kthread+0x2f2/0x390 kernel/kthread.c:389 ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #3 (&q->q_usage_counter(queue)#50){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 blk_queue_enter+0xe1/0x600 block/blk-core.c:328 blk_mq_alloc_request+0x4fa/0xaa0 block/blk-mq.c:652 scsi_alloc_request drivers/scsi/scsi_lib.c:1222 [inline] scsi_execute_cmd+0x177/0x1090 drivers/scsi/scsi_lib.c:304 read_capacity_16+0x2b4/0x1450 drivers/scsi/sd.c:2655 sd_read_capacity drivers/scsi/sd.c:2824 [inline] sd_revalidate_disk+0x1013/0xbce0 drivers/scsi/sd.c:3734 sd_probe+0x9fa/0x1100 drivers/scsi/sd.c:4010 really_probe+0x2ba/0xad0 drivers/base/dd.c:658 __driver_probe_device+0x1a2/0x390 drivers/base/dd.c:800 driver_probe_device+0x50/0x430 drivers/base/dd.c:830 __device_attach_driver+0x2d6/0x530 drivers/base/dd.c:958 bus_for_each_drv+0x250/0x2e0 drivers/base/bus.c:459 __device_attach_async_helper+0x22d/0x300 drivers/base/dd.c:987 async_run_entry_fn+0xaa/0x420 kernel/async.c:129 process_one_work kernel/workqueue.c:3229 [inline] process_scheduled_works+0xa68/0x1840 kernel/workqueue.c:3310 worker_thread+0x870/0xd30 kernel/workqueue.c:3391 kthread+0x2f2/0x390 kernel/kthread.c:389 ret_from_fork+0x4d/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #2 (&q->limits_lock){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 queue_limits_start_update include/linux/blkdev.h:947 [inline] loop_reconfigure_limits+0x43f/0x900 drivers/block/loop.c:998 loop_set_block_size drivers/block/loop.c:1473 [inline] lo_simple_ioctl drivers/block/loop.c:1496 [inline] lo_ioctl+0x1351/0x1f50 drivers/block/loop.c:1559 blkdev_ioctl+0x57f/0x6a0 block/ioctl.c:693 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:906 [inline] __se_sys_ioctl+0xf7/0x170 fs/ioctl.c:892 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&q->q_usage_counter(io)#24){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 bio_queue_enter block/blk.h:75 [inline] blk_mq_submit_bio+0x1536/0x2390 block/blk-mq.c:3090 __submit_bio+0x2c6/0x560 block/blk-core.c:629 __submit_bio_noacct_mq block/blk-core.c:710 [inline] submit_bio_noacct_nocheck+0x4d3/0xe30 block/blk-core.c:739 ext4_commit_super+0x2e0/0x450 fs/ext4/super.c:6236 ext4_handle_error+0x71a/0x8e0 fs/ext4/super.c:727 __ext4_error+0x277/0x3b0 fs/ext4/super.c:837 ext4_read_block_bitmap_nowait+0x2f0/0xa80 fs/ext4/balloc.c:482 ext4_mb_init_cache+0x413/0x13f0 fs/ext4/mballoc.c:1337 ext4_mb_init_group+0x329/0x600 fs/ext4/mballoc.c:1543 ext4_mb_good_group_nolock fs/ext4/mballoc.c:2704 [inline] ext4_mb_regular_allocator+0x1140/0x3bb0 fs/ext4/mballoc.c:2903 ext4_mb_new_blocks+0x10a8/0x4e00 fs/ext4/mballoc.c:6217 ext4_new_meta_blocks+0x20a/0x500 fs/ext4/balloc.c:750 ext4_ext_grow_indepth fs/ext4/extents.c:1329 [inline] ext4_ext_create_new_leaf fs/ext4/extents.c:1433 [inline] ext4_ext_insert_extent+0xf10/0x4bd0 fs/ext4/extents.c:2115 ext4_ext_map_blocks+0x1d9d/0x7d30 fs/ext4/extents.c:4400 ext4_map_create_blocks fs/ext4/inode.c:516 [inline] ext4_map_blocks+0x8bf/0x1990 fs/ext4/inode.c:702 ext4_getblk+0x1fa/0x880 fs/ext4/inode.c:849 ext4_bread+0x2e/0x180 fs/ext4/inode.c:912 ext4_quota_write+0x223/0x580 fs/ext4/super.c:7285 write_blk+0x125/0x240 fs/quota/quota_tree.c:70 do_insert_tree+0xca1/0x1490 fs/quota/quota_tree.c:407 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x496/0x5b0 fs/quota/quota_tree.c:451 v2_write_dquot+0x17a/0x270 fs/quota/quota_v2.c:372 dquot_acquire+0x351/0x680 fs/quota/dquot.c:470 ext4_acquire_dquot+0x301/0x4c0 fs/ext4/super.c:6934 dqget+0x772/0xeb0 fs/quota/dquot.c:977 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ext4_create+0xb5/0x550 fs/ext4/namei.c:2834 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x1c05/0x3590 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_creat fs/open.c:1495 [inline] __se_sys_creat fs/open.c:1489 [inline] __x64_sys_creat+0x123/0x170 fs/open.c:1489 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ei->i_data_sem/2){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ext4_map_blocks+0x3be/0x1990 fs/ext4/inode.c:665 ext4_getblk+0x1fa/0x880 fs/ext4/inode.c:849 ext4_bread+0x2e/0x180 fs/ext4/inode.c:912 ext4_quota_write+0x223/0x580 fs/ext4/super.c:7285 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x334/0x690 fs/quota/quota_tree.c:136 do_insert_tree+0x2c5/0x1490 fs/quota/quota_tree.c:347 do_insert_tree+0xbd6/0x1490 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x496/0x5b0 fs/quota/quota_tree.c:451 v2_write_dquot+0x17a/0x270 fs/quota/quota_v2.c:372 dquot_acquire+0x351/0x680 fs/quota/dquot.c:470 ext4_acquire_dquot+0x301/0x4c0 fs/ext4/super.c:6934 dqget+0x772/0xeb0 fs/quota/dquot.c:977 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ext4_unlink+0x144/0x5a0 fs/ext4/namei.c:3320 vfs_unlink+0x367/0x650 fs/namei.c:4523 do_unlinkat+0x4ae/0x830 fs/namei.c:4587 __do_sys_unlink fs/namei.c:4635 [inline] __se_sys_unlink fs/namei.c:4633 [inline] __x64_sys_unlink+0x47/0x50 fs/namei.c:4633 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> jbd2_handle --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(jbd2_handle); lock(&s->s_dquot.dqio_sem); rlock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz-executor/27209: #0: ffff888045f96420 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515 #1: ffff88807ab06708 (&type->i_mutex_dir_key#3/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:853 [inline] #1: ffff88807ab06708 (&type->i_mutex_dir_key#3/1){+.+.}-{4:4}, at: do_unlinkat+0x26a/0x830 fs/namei.c:4574 #2: ffff8880791903f8 (&sb->s_type->i_mutex_key#8){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #2: ffff8880791903f8 (&sb->s_type->i_mutex_key#8){++++}-{4:4}, at: vfs_unlink+0xe4/0x650 fs/namei.c:4512 #3: ffff88807aa5b5a8 (&dquot->dq_lock){+.+.}-{4:4}, at: dquot_acquire+0x69/0x680 fs/quota/dquot.c:458 #4: ffff888045f96210 (&s->s_dquot.dqio_sem){++++}-{4:4}, at: v2_write_dquot+0xab/0x270 fs/quota/quota_v2.c:367 stack backtrace: CPU: 0 UID: 0 PID: 27209 Comm: syz-executor Not tainted 6.13.0-rc3-syzkaller-00026-g59dbb9d81adf #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ext4_map_blocks+0x3be/0x1990 fs/ext4/inode.c:665 ext4_getblk+0x1fa/0x880 fs/ext4/inode.c:849 ext4_bread+0x2e/0x180 fs/ext4/inode.c:912 ext4_quota_write+0x223/0x580 fs/ext4/super.c:7285 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x334/0x690 fs/quota/quota_tree.c:136 do_insert_tree+0x2c5/0x1490 fs/quota/quota_tree.c:347 do_insert_tree+0xbd6/0x1490 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x496/0x5b0 fs/quota/quota_tree.c:451 v2_write_dquot+0x17a/0x270 fs/quota/quota_v2.c:372 dquot_acquire+0x351/0x680 fs/quota/dquot.c:470 ext4_acquire_dquot+0x301/0x4c0 fs/ext4/super.c:6934 dqget+0x772/0xeb0 fs/quota/dquot.c:977 __dquot_initialize+0x2e3/0xec0 fs/quota/dquot.c:1505 ext4_unlink+0x144/0x5a0 fs/ext4/namei.c:3320 vfs_unlink+0x367/0x650 fs/namei.c:4523 do_unlinkat+0x4ae/0x830 fs/namei.c:4587 __do_sys_unlink fs/namei.c:4635 [inline] __se_sys_unlink fs/namei.c:4633 [inline] __x64_sys_unlink+0x47/0x50 fs/namei.c:4633 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fa0a21852d7 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffc74743788 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fa0a21852d7 RDX: 00007ffc747437b0 RSI: 00007ffc74743840 RDI: 00007ffc74743840 RBP: 00007ffc74743840 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffc74744930 R13: 00007fa0a220180c R14: 00007ffc74746ae0 R15: 000000000000002b Quota error (device loop1): do_check_range: Getting dqdh_next_free 4294967294 out of range 0-8 Quota error (device loop1): qtree_write_dquot: Error -117 occurred while creating quota EXT4-fs error (device loop1): ext4_acquire_dquot:6938: comm syz-executor: Failed to acquire dquot type 0 EXT4-fs (loop1): unmounting filesystem 00000000-0000-0000-0000-000000d40000.