====================================================== WARNING: possible circular locking dependency detected 6.1.113-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor/3646 is trying to acquire lock: ffff88807c8a4ae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xc8/0x720 fs/gfs2/quota.c:682 but task is already holding lock: ffff888057e04918 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1512 [inline] ffff888057e04918 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x27e9/0x3ab0 fs/gfs2/bmap.c:1837 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 __gfs2_iomap_get+0x178/0x1480 fs/gfs2/bmap.c:856 gfs2_iomap_get+0xdb/0x150 fs/gfs2/bmap.c:1396 bh_get+0x286/0x800 fs/gfs2/quota.c:385 qdsb_get+0x209/0x3b0 fs/gfs2/quota.c:522 gfs2_quota_hold+0x19d/0x5c0 fs/gfs2/quota.c:608 gfs2_dinode_dealloc fs/gfs2/super.c:1210 [inline] evict_unlinked_inode+0x443/0x7b0 fs/gfs2/super.c:1408 gfs2_evict_inode+0x77b/0x1280 fs/gfs2/super.c:1497 evict+0x529/0x930 fs/inode.c:701 do_unlinkat+0x509/0x820 fs/namei.c:4397 __do_sys_unlink fs/namei.c:4438 [inline] __se_sys_unlink fs/namei.c:4436 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4436 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 do_qc+0xc8/0x720 fs/gfs2/quota.c:682 gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295 punch_hole+0x344a/0x3ab0 fs/gfs2/bmap.c:1938 evict_unlinked_inode+0x19b/0x7b0 fs/gfs2/super.c:1398 gfs2_evict_inode+0x77b/0x1280 fs/gfs2/super.c:1497 evict+0x529/0x930 fs/inode.c:701 do_unlinkat+0x509/0x820 fs/namei.c:4397 __do_sys_unlink fs/namei.c:4438 [inline] __se_sys_unlink fs/namei.c:4436 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4436 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 4 locks held by syz-executor/3646: #0: ffff88807c272460 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff88807c272650 (sb_internal#4){.+.+}-{0:0}, at: gfs2_trans_begin+0x6d/0xe0 fs/gfs2/trans.c:118 #2: ffff88807c8a5058 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x558/0x940 fs/gfs2/trans.c:87 #3: ffff888057e04918 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1512 [inline] #3: ffff888057e04918 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x27e9/0x3ab0 fs/gfs2/bmap.c:1837 stack backtrace: CPU: 1 PID: 3646 Comm: syz-executor Not tainted 6.1.113-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 do_qc+0xc8/0x720 fs/gfs2/quota.c:682 gfs2_quota_change+0x2db/0x8c0 fs/gfs2/quota.c:1295 punch_hole+0x344a/0x3ab0 fs/gfs2/bmap.c:1938 evict_unlinked_inode+0x19b/0x7b0 fs/gfs2/super.c:1398 gfs2_evict_inode+0x77b/0x1280 fs/gfs2/super.c:1497 evict+0x529/0x930 fs/inode.c:701 do_unlinkat+0x509/0x820 fs/namei.c:4397 __do_sys_unlink fs/namei.c:4438 [inline] __se_sys_unlink fs/namei.c:4436 [inline] __x64_sys_unlink+0x45/0x50 fs/namei.c:4436 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f882457d5a7 Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 57 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffc08b757d8 EFLAGS: 00000206 ORIG_RAX: 0000000000000057 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f882457d5a7 RDX: 00007ffc08b75800 RSI: 00007ffc08b75890 RDI: 00007ffc08b75890 RBP: 00007ffc08b75890 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffc08b76980 R13: 00007f88245f0134 R14: 000000000000ed23 R15: 00007ffc08b77a40 gfs2: fsid=syz:syz.0: fatal: invalid metadata block bh = 9376 (magic number) function = gfs2_meta_buffer, file = fs/gfs2/meta_io.c, line = 492 gfs2: fsid=syz:syz.0: about to withdraw this file system gfs2: fsid=syz:syz.0: Journal recovery skipped for jid 0 until next mount. gfs2: fsid=syz:syz.0: Glock dequeues delayed: 0 gfs2: fsid=syz:syz.0: File system withdrawn CPU: 1 PID: 3646 Comm: syz-executor Not tainted 6.1.113-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 gfs2_withdraw+0xfcb/0x1550 fs/gfs2/util.c:366 gfs2_meta_check_ii+0x6e/0x80 fs/gfs2/util.c:511 gfs2_metatype_check_i fs/gfs2/util.h:126 [inline] gfs2_meta_buffer+0x324/0x410 fs/gfs2/meta_io.c:492 gfs2_meta_inode_buffer fs/gfs2/meta_io.h:72 [inline] gfs2_inode_refresh+0xdc/0x1060 fs/gfs2/glops.c:480 gfs2_instantiate+0x188/0x250 fs/gfs2/glock.c:520 gfs2_glock_holder_ready fs/gfs2/glock.c:1328 [inline] gfs2_glock_wait+0x1db/0x2a0 fs/gfs2/glock.c:1348 gfs2_glock_nq_init fs/gfs2/glock.h:255 [inline] do_sync+0x48e/0xc70 fs/gfs2/quota.c:927 gfs2_quota_sync+0x379/0x810 fs/gfs2/quota.c:1329 gfs2_sync_fs+0x49/0xb0 fs/gfs2/super.c:660 sync_filesystem+0xe8/0x220 fs/sync.c:56 generic_shutdown_super+0x6b/0x340 fs/super.c:474 kill_block_super+0x7a/0xe0 fs/super.c:1470 deactivate_locked_super+0xa0/0x110 fs/super.c:332 cleanup_mnt+0x490/0x520 fs/namespace.c:1186 task_work_run+0x246/0x300 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f882457f327 Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8 RSP: 002b:00007ffc08b757d8 EFLAGS: 00000206 ORIG_RAX: 00000000000000a6 RAX: 0000000000000000 RBX: 0000000000000064 RCX: 00007f882457f327 RDX: 0000000000000200 RSI: 0000000000000009 RDI: 00007ffc08b76980 RBP: 00007f88245f0134 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffc08b76980 R13: 00007f88245f0134 R14: 000055558f9194a8 R15: 00007ffc08b77a40 gfs2: fsid=syz:syz.0: warning: assertion "!qd->qd_change" failed at function = gfs2_quota_cleanup, file = fs/gfs2/quota.c, line = 1485 CPU: 0 PID: 3646 Comm: syz-executor Not tainted 6.1.113-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 gfs2_assert_warn_i+0x19b/0x2e0 fs/gfs2/util.c:427 gfs2_quota_cleanup+0x4b1/0x6a0 fs/gfs2/quota.c:1485 gfs2_put_super+0x23d/0x8c0 fs/gfs2/super.c:601 generic_shutdown_super+0x130/0x340 fs/super.c:501 kill_block_super+0x7a/0xe0 fs/super.c:1470 deactivate_locked_super+0xa0/0x110 fs/super.c:332 cleanup_mnt+0x490/0x520 fs/namespace.c:1186 task_work_run+0x246/0x300 kernel/task_work.c:203 resume_user_mode_work include/linux/resume_user_mode.h:49 [inline] exit_to_user_mode_loop+0xde/0x100 kernel/entry/common.c:177 exit_to_user_mode_prepare+0xb1/0x140 kernel/entry/common.c:210 __syscall_exit_to_user_mode_work kernel/entry/common.c:292 [inline] syscall_exit_to_user_mode+0x60/0x270 kernel/entry/common.c:303 do_syscall_64+0x47/0xb0 arch/x86/entry/common.c:87 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f882457f327 Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8 RSP: 002b:00007ffc08b757d8 EFLAGS: 00000206 ORIG_RAX: 00000000000000a6 RAX: 0000000000000000 RBX: 0000000000000064 RCX: 00007f882457f327 RDX: 0000000000000200 RSI: 0000000000000009 RDI: 00007ffc08b76980 RBP: 00007f88245f0134 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000100 R11: 0000000000000206 R12: 00007ffc08b76980 R13: 00007f88245f0134 R14: 000055558f9194a8 R15: 00007ffc08b77a40