======================================================== WARNING: possible irq lock inversion dependency detected 5.9.0-syzkaller #0 Not tainted -------------------------------------------------------- syz-executor.5/7322 just changed the state of lock: ffff888214eea908 (&group->lock){..-.}-{2:2}, at: _snd_pcm_stream_lock_irqsave+0x9f/0xd0 sound/core/pcm_native.c:170 but this lock took another, SOFTIRQ-READ-unsafe lock in the past: (&card->ctl_files_rwlock){.+.+}-{2:2} and interrupts could create inverse lock ordering between them. other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&card->ctl_files_rwlock); local_irq_disable(); lock(&group->lock); lock(&card->ctl_files_rwlock); lock(&group->lock); *** DEADLOCK *** 2 locks held by syz-executor.5/7322: #0: ffffffff8a353460 (rcu_read_lock){....}-{1:2}, at: fast_dput fs/dcache.c:746 [inline] #0: ffffffff8a353460 (rcu_read_lock){....}-{1:2}, at: dput+0x35/0xbc0 fs/dcache.c:865 #1: ffffc90000007d80 ((&dpcm->timer)){+.-.}-{0:0}, at: lockdep_copy_map include/linux/lockdep.h:35 [inline] #1: ffffc90000007d80 ((&dpcm->timer)){+.-.}-{0:0}, at: call_timer_fn+0xd5/0x6b0 kernel/time/timer.c:1405 the shortest dependencies between 2nd lock and 1st lock: -> (&card->ctl_files_rwlock){.+.+}-{2:2} { HARDIRQ-ON-R at: lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 snd_ctl_notify.part.0+0x36/0x550 sound/core/control.c:153 snd_ctl_notify+0x8f/0xb0 sound/core/control.c:181 __snd_ctl_add_replace+0x638/0x800 sound/core/control.c:382 snd_ctl_add_replace+0x76/0x130 sound/core/control.c:399 snd_card_dummy_new_mixer sound/drivers/dummy.c:885 [inline] snd_dummy_probe+0xc22/0x1180 sound/drivers/dummy.c:1080 platform_drv_probe+0x87/0x140 drivers/base/platform.c:747 really_probe+0x282/0x9f0 drivers/base/dd.c:553 driver_probe_device+0xfe/0x1d0 drivers/base/dd.c:738 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:844 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 __device_attach+0x228/0x470 drivers/base/dd.c:912 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 device_add+0xb17/0x1c40 drivers/base/core.c:2926 platform_device_add+0x34f/0x6d0 drivers/base/platform.c:597 platform_device_register_full+0x38c/0x4e0 drivers/base/platform.c:720 platform_device_register_resndata include/linux/platform_device.h:131 [inline] platform_device_register_simple include/linux/platform_device.h:160 [inline] alsa_card_dummy_init+0x1e0/0x309 sound/drivers/dummy.c:1168 do_one_initcall+0x103/0x6f0 init/main.c:1205 do_initcall_level init/main.c:1278 [inline] do_initcalls init/main.c:1294 [inline] do_basic_setup init/main.c:1314 [inline] kernel_init_freeable+0x652/0x6d6 init/main.c:1514 kernel_init+0xd/0x1b8 init/main.c:1403 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 SOFTIRQ-ON-R at: lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 snd_ctl_notify.part.0+0x36/0x550 sound/core/control.c:153 snd_ctl_notify+0x8f/0xb0 sound/core/control.c:181 __snd_ctl_add_replace+0x638/0x800 sound/core/control.c:382 snd_ctl_add_replace+0x76/0x130 sound/core/control.c:399 snd_card_dummy_new_mixer sound/drivers/dummy.c:885 [inline] snd_dummy_probe+0xc22/0x1180 sound/drivers/dummy.c:1080 platform_drv_probe+0x87/0x140 drivers/base/platform.c:747 really_probe+0x282/0x9f0 drivers/base/dd.c:553 driver_probe_device+0xfe/0x1d0 drivers/base/dd.c:738 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:844 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 __device_attach+0x228/0x470 drivers/base/dd.c:912 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 device_add+0xb17/0x1c40 drivers/base/core.c:2926 platform_device_add+0x34f/0x6d0 drivers/base/platform.c:597 platform_device_register_full+0x38c/0x4e0 drivers/base/platform.c:720 platform_device_register_resndata include/linux/platform_device.h:131 [inline] platform_device_register_simple include/linux/platform_device.h:160 [inline] alsa_card_dummy_init+0x1e0/0x309 sound/drivers/dummy.c:1168 do_one_initcall+0x103/0x6f0 init/main.c:1205 do_initcall_level init/main.c:1278 [inline] do_initcalls init/main.c:1294 [inline] do_basic_setup init/main.c:1314 [inline] kernel_init_freeable+0x652/0x6d6 init/main.c:1514 kernel_init+0xd/0x1b8 init/main.c:1403 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 INITIAL READ USE at: lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 snd_ctl_notify.part.0+0x36/0x550 sound/core/control.c:153 snd_ctl_notify+0x8f/0xb0 sound/core/control.c:181 __snd_ctl_add_replace+0x638/0x800 sound/core/control.c:382 snd_ctl_add_replace+0x76/0x130 sound/core/control.c:399 snd_card_dummy_new_mixer sound/drivers/dummy.c:885 [inline] snd_dummy_probe+0xc22/0x1180 sound/drivers/dummy.c:1080 platform_drv_probe+0x87/0x140 drivers/base/platform.c:747 really_probe+0x282/0x9f0 drivers/base/dd.c:553 driver_probe_device+0xfe/0x1d0 drivers/base/dd.c:738 __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:844 bus_for_each_drv+0x15f/0x1e0 drivers/base/bus.c:431 __device_attach+0x228/0x470 drivers/base/dd.c:912 bus_probe_device+0x1e4/0x290 drivers/base/bus.c:491 device_add+0xb17/0x1c40 drivers/base/core.c:2926 platform_device_add+0x34f/0x6d0 drivers/base/platform.c:597 platform_device_register_full+0x38c/0x4e0 drivers/base/platform.c:720 platform_device_register_resndata include/linux/platform_device.h:131 [inline] platform_device_register_simple include/linux/platform_device.h:160 [inline] alsa_card_dummy_init+0x1e0/0x309 sound/drivers/dummy.c:1168 do_one_initcall+0x103/0x6f0 init/main.c:1205 do_initcall_level init/main.c:1278 [inline] do_initcalls init/main.c:1294 [inline] do_basic_setup init/main.c:1314 [inline] kernel_init_freeable+0x652/0x6d6 init/main.c:1514 kernel_init+0xd/0x1b8 init/main.c:1403 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 } ... key at: [] __key.11+0x0/0x40 ... acquired at: __raw_read_lock include/linux/rwlock_api_smp.h:149 [inline] _raw_read_lock+0x5b/0x70 kernel/locking/spinlock.c:223 snd_ctl_notify.part.0+0x36/0x550 sound/core/control.c:153 snd_ctl_notify+0x8f/0xb0 sound/core/control.c:181 loopback_check_format sound/drivers/aloop.c:358 [inline] loopback_trigger+0x112f/0x1ab0 sound/drivers/aloop.c:387 snd_pcm_do_start sound/core/pcm_native.c:1350 [inline] snd_pcm_do_start+0xb1/0xf0 sound/core/pcm_native.c:1345 snd_pcm_action_single sound/core/pcm_native.c:1207 [inline] snd_pcm_action+0xc8/0x170 sound/core/pcm_native.c:1290 __snd_pcm_lib_xfer+0x1202/0x1a90 sound/core/pcm_lib.c:2247 snd_pcm_oss_write3+0x107/0x320 sound/core/oss/pcm_oss.c:1221 io_playback_transfer+0x27e/0x330 sound/core/oss/io.c:47 snd_pcm_plug_write_transfer+0x2cd/0x3f0 sound/core/oss/pcm_plugin.c:624 snd_pcm_oss_write2+0x245/0x3f0 sound/core/oss/pcm_oss.c:1353 snd_pcm_oss_sync1+0x168/0x450 sound/core/oss/pcm_oss.c:1594 snd_pcm_oss_sync+0x638/0x800 sound/core/oss/pcm_oss.c:1670 snd_pcm_oss_ioctl+0x2137/0x33a0 sound/core/oss/pcm_oss.c:2590 __do_compat_sys_ioctl+0x1d3/0x230 fs/ioctl.c:842 do_syscall_32_irqs_on arch/x86/entry/common.c:78 [inline] __do_fast_syscall_32+0x56/0x80 arch/x86/entry/common.c:137 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:160 entry_SYSENTER_compat_after_hwframe+0x4d/0x5c -> (&group->lock){..-.}-{2:2} { IN-SOFTIRQ-W at: lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x94/0xd0 kernel/locking/spinlock.c:159 _snd_pcm_stream_lock_irqsave+0x9f/0xd0 sound/core/pcm_native.c:170 snd_pcm_period_elapsed+0x24/0x250 sound/core/pcm_lib.c:1799 loopback_jiffies_timer_function+0x1a8/0x220 sound/drivers/aloop.c:669 call_timer_fn+0x1a5/0x6b0 kernel/time/timer.c:1415 expire_timers kernel/time/timer.c:1460 [inline] __run_timers.part.0+0x67c/0xa50 kernel/time/timer.c:1757 __run_timers kernel/time/timer.c:1738 [inline] run_timer_softirq+0xb3/0x1d0 kernel/time/timer.c:1770 __do_softirq+0x203/0xac5 kernel/softirq.c:298 asm_call_irq_on_stack+0xf/0x20 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] do_softirq_own_stack+0xaa/0xd0 arch/x86/kernel/irq_64.c:77 invoke_softirq kernel/softirq.c:393 [inline] __irq_exit_rcu kernel/softirq.c:423 [inline] irq_exit_rcu+0x235/0x280 kernel/softirq.c:435 sysvec_apic_timer_interrupt+0x4d/0x100 arch/x86/kernel/apic/apic.c:1091 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581 get_current arch/x86/include/asm/current.h:15 [inline] __sanitizer_cov_trace_pc+0x9/0x60 kernel/kcov.c:196 rcu_read_unlock include/linux/rcupdate.h:684 [inline] dput+0x19f/0xbc0 fs/dcache.c:866 path_put+0x2d/0x60 fs/namei.c:496 do_loopback fs/namespace.c:2374 [inline] path_mount+0xceb/0x20a0 fs/namespace.c:3197 do_mount fs/namespace.c:3216 [inline] __do_sys_mount fs/namespace.c:3424 [inline] __se_sys_mount fs/namespace.c:3401 [inline] __ia32_sys_mount+0x27e/0x300 fs/namespace.c:3401 do_syscall_32_irqs_on arch/x86/entry/common.c:78 [inline] __do_fast_syscall_32+0x56/0x80 arch/x86/entry/common.c:137 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:160 entry_SYSENTER_compat_after_hwframe+0x4d/0x5c INITIAL USE at: lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0x94/0xd0 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:379 [inline] snd_pcm_group_lock_irq sound/core/pcm_native.c:97 [inline] snd_pcm_stream_lock_irq sound/core/pcm_native.c:136 [inline] snd_pcm_hw_params+0x12a/0x1920 sound/core/pcm_native.c:672 snd_pcm_kernel_ioctl+0xd1/0x240 sound/core/pcm_native.c:3325 snd_pcm_oss_change_params_locked+0x130a/0x3420 sound/core/oss/pcm_oss.c:941 snd_pcm_oss_make_ready_locked+0xb3/0x230 sound/core/oss/pcm_oss.c:1166 snd_pcm_oss_write1 sound/core/oss/pcm_oss.c:1384 [inline] snd_pcm_oss_write+0x45d/0x940 sound/core/oss/pcm_oss.c:2765 vfs_write+0x2b0/0x730 fs/read_write.c:584 ksys_write+0x12d/0x250 fs/read_write.c:639 do_syscall_32_irqs_on arch/x86/entry/common.c:78 [inline] __do_fast_syscall_32+0x56/0x80 arch/x86/entry/common.c:137 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:160 entry_SYSENTER_compat_after_hwframe+0x4d/0x5c } ... key at: [] __key.7+0x0/0x40 ... acquired at: mark_usage kernel/locking/lockdep.c:4305 [inline] __lock_acquire+0x1190/0x5590 kernel/locking/lockdep.c:4791 lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x94/0xd0 kernel/locking/spinlock.c:159 _snd_pcm_stream_lock_irqsave+0x9f/0xd0 sound/core/pcm_native.c:170 snd_pcm_period_elapsed+0x24/0x250 sound/core/pcm_lib.c:1799 loopback_jiffies_timer_function+0x1a8/0x220 sound/drivers/aloop.c:669 call_timer_fn+0x1a5/0x6b0 kernel/time/timer.c:1415 expire_timers kernel/time/timer.c:1460 [inline] __run_timers.part.0+0x67c/0xa50 kernel/time/timer.c:1757 __run_timers kernel/time/timer.c:1738 [inline] run_timer_softirq+0xb3/0x1d0 kernel/time/timer.c:1770 __do_softirq+0x203/0xac5 kernel/softirq.c:298 asm_call_irq_on_stack+0xf/0x20 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] do_softirq_own_stack+0xaa/0xd0 arch/x86/kernel/irq_64.c:77 invoke_softirq kernel/softirq.c:393 [inline] __irq_exit_rcu kernel/softirq.c:423 [inline] irq_exit_rcu+0x235/0x280 kernel/softirq.c:435 sysvec_apic_timer_interrupt+0x4d/0x100 arch/x86/kernel/apic/apic.c:1091 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581 get_current arch/x86/include/asm/current.h:15 [inline] __sanitizer_cov_trace_pc+0x9/0x60 kernel/kcov.c:196 rcu_read_unlock include/linux/rcupdate.h:684 [inline] dput+0x19f/0xbc0 fs/dcache.c:866 path_put+0x2d/0x60 fs/namei.c:496 do_loopback fs/namespace.c:2374 [inline] path_mount+0xceb/0x20a0 fs/namespace.c:3197 do_mount fs/namespace.c:3216 [inline] __do_sys_mount fs/namespace.c:3424 [inline] __se_sys_mount fs/namespace.c:3401 [inline] __ia32_sys_mount+0x27e/0x300 fs/namespace.c:3401 do_syscall_32_irqs_on arch/x86/entry/common.c:78 [inline] __do_fast_syscall_32+0x56/0x80 arch/x86/entry/common.c:137 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:160 entry_SYSENTER_compat_after_hwframe+0x4d/0x5c stack backtrace: CPU: 0 PID: 7322 Comm: syz-executor.5 Not tainted 5.9.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x198/0x1fb lib/dump_stack.c:118 print_irq_inversion_bug kernel/locking/lockdep.c:4410 [inline] check_usage_forwards kernel/locking/lockdep.c:3848 [inline] mark_lock_irq kernel/locking/lockdep.c:3980 [inline] mark_lock.cold+0x20/0x74 kernel/locking/lockdep.c:4408 mark_usage kernel/locking/lockdep.c:4305 [inline] __lock_acquire+0x1190/0x5590 kernel/locking/lockdep.c:4791 lock_acquire kernel/locking/lockdep.c:5442 [inline] lock_acquire+0x219/0x9d0 kernel/locking/lockdep.c:5407 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x94/0xd0 kernel/locking/spinlock.c:159 _snd_pcm_stream_lock_irqsave+0x9f/0xd0 sound/core/pcm_native.c:170 snd_pcm_period_elapsed+0x24/0x250 sound/core/pcm_lib.c:1799 loopback_jiffies_timer_function+0x1a8/0x220 sound/drivers/aloop.c:669 call_timer_fn+0x1a5/0x6b0 kernel/time/timer.c:1415 expire_timers kernel/time/timer.c:1460 [inline] __run_timers.part.0+0x67c/0xa50 kernel/time/timer.c:1757 __run_timers kernel/time/timer.c:1738 [inline] run_timer_softirq+0xb3/0x1d0 kernel/time/timer.c:1770 __do_softirq+0x203/0xac5 kernel/softirq.c:298 asm_call_irq_on_stack+0xf/0x20 __run_on_irqstack arch/x86/include/asm/irq_stack.h:26 [inline] run_on_irqstack_cond arch/x86/include/asm/irq_stack.h:77 [inline] do_softirq_own_stack+0xaa/0xd0 arch/x86/kernel/irq_64.c:77 invoke_softirq kernel/softirq.c:393 [inline] __irq_exit_rcu kernel/softirq.c:423 [inline] irq_exit_rcu+0x235/0x280 kernel/softirq.c:435 sysvec_apic_timer_interrupt+0x4d/0x100 arch/x86/kernel/apic/apic.c:1091 asm_sysvec_apic_timer_interrupt+0x12/0x20 arch/x86/include/asm/idtentry.h:581 RIP: 0010:preempt_count arch/x86/include/asm/preempt.h:26 [inline] RIP: 0010:check_kcov_mode kernel/kcov.c:163 [inline] RIP: 0010:__sanitizer_cov_trace_pc+0x9/0x60 kernel/kcov.c:197 Code: 5d be 03 00 00 00 e9 06 ca 43 02 66 0f 1f 44 00 00 48 8b be b0 01 00 00 e8 b4 ff ff ff 31 c0 c3 90 65 48 8b 14 25 c0 fe 01 00 <65> 8b 05 a0 40 8d 7e a9 00 01 ff 00 48 8b 34 24 74 0f f6 c4 01 74 RSP: 0018:ffffc900061e7d18 EFLAGS: 00000202 RAX: 0000000000000000 RBX: 0000000000000001 RCX: ffffffff81c66f36 RDX: ffff8880a8598100 RSI: ffff8880a8598100 RDI: 0000000000000005 RBP: ffff8880a9c03910 R08: 0000000000000000 R09: ffff8880a9c039a3 R10: 0000000000000000 R11: 0000000000000000 R12: ffff8880a9c039a0 R13: ffffffff81c66dd5 R14: 0000000000000425 R15: 0000000000000000 rcu_read_unlock include/linux/rcupdate.h:684 [inline] dput+0x19f/0xbc0 fs/dcache.c:866 path_put+0x2d/0x60 fs/namei.c:496 do_loopback fs/namespace.c:2374 [inline] path_mount+0xceb/0x20a0 fs/namespace.c:3197 do_mount fs/namespace.c:3216 [inline] __do_sys_mount fs/namespace.c:3424 [inline] __se_sys_mount fs/namespace.c:3401 [inline] __ia32_sys_mount+0x27e/0x300 fs/namespace.c:3401 do_syscall_32_irqs_on arch/x86/entry/common.c:78 [inline] __do_fast_syscall_32+0x56/0x80 arch/x86/entry/common.c:137 do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:160 entry_SYSENTER_compat_after_hwframe+0x4d/0x5c RIP: 0023:0xf7f73549 Code: b8 01 10 06 03 74 b4 01 10 07 03 74 b0 01 10 08 03 74 d8 01 00 00 00 00 00 00 00 00 00 00 00 00 00 51 52 55 89 e5 0f 34 cd 80 <5d> 5a 59 c3 90 90 90 90 eb 0d 90 90 90 90 90 90 90 90 90 90 90 90 RSP: 002b:00000000090bff60 EFLAGS: 00000212 ORIG_RAX: 0000000000000015 RAX: ffffffffffffffda RBX: 00000000080d9abe RCX: 00000000080d9aad RDX: 0000000000000000 RSI: 0000000000045000 RDI: 0000000000000000 RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000