====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc5-syzkaller-00063-g374a7f47bf40 #0 Not tainted ------------------------------------------------------ syz-executor.4/10862 is trying to acquire lock: ffff888033f248f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 but task is already holding lock: ffff8880234987c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2da/0xb40 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x47b/0x1000 fs/buffer.c:2412 filemap_read_folio+0x19d/0x7a0 mm/filemap.c:2389 do_read_cache_folio+0x134/0x820 mm/filemap.c:3696 do_read_cache_page+0x32/0x220 mm/filemap.c:3762 read_mapping_page include/linux/pagemap.h:776 [inline] hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa50/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x555/0x1a60 fs/buffer.c:2128 __block_write_begin fs/buffer.c:2178 [inline] block_write_begin+0x9c/0x1f0 fs/buffer.c:2239 cont_write_begin+0x643/0x880 fs/buffer.c:2597 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:52 generic_perform_write+0x31b/0x630 mm/filemap.c:3923 generic_file_write_iter+0xaf/0x310 mm/filemap.c:4044 call_write_iter include/linux/fs.h:1877 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x782/0xaf0 fs/read_write.c:584 ksys_write+0x1a0/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7d0/0xb40 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x174/0x220 hfsplus_unlink+0x511/0x7f0 fs/hfsplus/dir.c:405 hfsplus_rename+0xc8/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xaba/0xde0 fs/namei.c:4857 do_renameat2+0xd78/0x1660 fs/namei.c:5009 __do_sys_rename fs/namei.c:5055 [inline] __se_sys_rename fs/namei.c:5053 [inline] __x64_sys_rename+0x86/0x90 fs/namei.c:5053 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 6 locks held by syz-executor.4/10862: #0: ffff88807d2be410 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:403 #1: ffff88802349c680 (&type->i_mutex_dir_key#15/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #1: ffff88802349c680 (&type->i_mutex_dir_key#15/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3042 [inline] #1: ffff88802349c680 (&type->i_mutex_dir_key#15/1){+.+.}-{3:3}, at: do_renameat2+0x615/0x1660 fs/namei.c:4948 #2: ffff8880234989c0 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:806 [inline] #2: ffff8880234989c0 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: lock_two_inodes+0x100/0x180 fs/inode.c:1143 #3: ffff88802349ef00 (&sb->s_type->i_mutex_key#30/4){+.+.}-{3:3}, at: vfs_rename+0x5eb/0xde0 fs/namei.c:4829 #4: ffff888033f24998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_unlink+0x161/0x7f0 fs/hfsplus/dir.c:370 #5: ffff8880234987c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x2da/0xb40 fs/hfsplus/extents.c:576 stack backtrace: CPU: 1 PID: 10862 Comm: syz-executor.4 Not tainted 6.5.0-rc5-syzkaller-00063-g374a7f47bf40 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 hfsplus_block_free+0xbb/0x4d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x17a/0xae0 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0x7d0/0xb40 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x174/0x220 hfsplus_unlink+0x511/0x7f0 fs/hfsplus/dir.c:405 hfsplus_rename+0xc8/0x1c0 fs/hfsplus/dir.c:547 vfs_rename+0xaba/0xde0 fs/namei.c:4857 do_renameat2+0xd78/0x1660 fs/namei.c:5009 __do_sys_rename fs/namei.c:5055 [inline] __se_sys_rename fs/namei.c:5053 [inline] __x64_sys_rename+0x86/0x90 fs/namei.c:5053 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f3c20e7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3c21c640c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007f3c20f9bf80 RCX: 00007f3c20e7cae9 RDX: 0000000000000000 RSI: 0000000020000040 RDI: 0000000020000000 RBP: 00007f3c20ec847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f3c20f9bf80 R15: 00007ffeb34871a8 hfsplus: unable to mark blocks free: error -4 hfsplus: can't free extent